Hi,
I was trying to make a patch and looking over the Hadoop guidelines for code at
http://wiki.apache.org/hadoop/CodeReviewChecklist, trying to follow the
conventions.
Looking through code I found a few "patterns", however, these differ even in
the same class sometimes. Here's a collection of
My opinions on the groups of line numbers from that pastebin:
1-3: Definitely not - no reason for ) on its own line
5-8: no, "throws" should be indented
10-13: I think this is acceptable
15-19: also acceptable IMO
22-24: acceptable - lines wrapped due to column limit should indent their
wrappings
> So, IMO, the goal should be the examples on 10-24 or 31-36.
+1 I agree with Todd: the highlighted snippets are most appropriate as Java
coding style.
On 11/20/09 10:54 , Todd Lipcon wrote:
My opinions on the groups of line numbers from that pastebin:
1-3: Definitely not - no reason for ) o
[
https://issues.apache.org/jira/browse/HADOOP-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Chansler resolved HADOOP-3192.
-
Resolution: Fixed
Fix Version/s: 0.20.0
Some large cluster are running with 34GB!
