Re: when did static .* imports fall found of checkstyle

2017-06-26 Thread Steve Loughran
On 23 Jun 2017, at 19:24, Andrew Wang mailto:andrew.w...@cloudera.com>> wrote: This is my personal opinion, but I don't like wildcard imports in general. One example is that it makes it harder to determine the API impact when reviewing a patch that changes the version of a JAR. Given that IDEs

Re: when did static .* imports fall found of checkstyle

2017-06-23 Thread Andrew Wang
This is my personal opinion, but I don't like wildcard imports in general. One example is that it makes it harder to determine the API impact when reviewing a patch that changes the version of a JAR. Given that IDEs manage imports for you, I don't see much benefit from wildcard imports either. On

when did static .* imports fall found of checkstyle

2017-06-23 Thread Steve Loughran
I've justone a patch for HADOOP-15553 -moving Azure module to the parallel integration tests of hadoop-aws, and now checkstyle is telling me off for the same static .* imports as I've been using up till now org.apache.hadoop.fs.azure.metrics.AzureFileSystemInstrumentation. [UnusedImports] ./