[jira] [Created] (HADOOP-17011) Trailing whitespace in fs.defaultFS will crash namenode and datanode

Ctest created HADOOP-17011: -- Summary: Trailing whitespace in fs.defaultFS will crash namenode and datanode Key: HADOOP-17011 URL: https://issues.apache.org/jira/browse/HADOOP-17011 Project: Hadoop Common

[jira] [Created] (HADOOP-13258) Fix trailing whitespace in LICENSE.txt for pre-commit.

Xiao Chen created HADOOP-13258: -- Summary: Fix trailing whitespace in LICENSE.txt for pre-commit. Key: HADOOP-13258 URL: https://issues.apache.org/jira/browse/HADOOP-13258 Project: Hadoop Common

Re: Patch advice rerquired: trailing whitespace cleanup

We should probably file and work some liras to remove excess whitespace, tabs, etc. from the source files. > There are some known issues with false positives on the whitespace check > right now. Fixes are in progress. fixes for this and a bunch of other issues are already fixed upstream. ;)

Re: Patch advice rerquired: trailing whitespace cleanup

On 19/06/2015 17:19, Chris Nauroth wrote: If it flags a warning on a line of code that your patch touches, then go ahead and trim the whitespace. If you find that it flags a warning on a line of code in the surrounding diff context, but not something that you're actually changing, then don't bo

Re: Patch advice rerquired: trailing whitespace cleanup

ort/test-patch.sh I got some warnings about >trailing whitespace. I'll fix the 2 that I introduced but what about all >the others in the files I've touched, fix or leave? I can fix easily >enough but it makes the patches rather noisy. > >-- >Alan Burlison >--

Patch advice rerquired: trailing whitespace cleanup

While running the dev-support/test-patch.sh I got some warnings about trailing whitespace. I'll fix the 2 that I introduced but what about all the others in the files I've touched, fix or leave? I can fix easily enough but it makes the patches rather noisy. -- Alan Burlison --

Re: trailing whitespace

OK, if folks want to do something to get rid of trailing whitespace in the project I won't object, but it doesn't seem like that big a deal to me. A pre-commit hook makes sense to me. I just don't want to see the QA bot flag patches containing trailing whitespace, thus requiring m

Re: trailing whitespace

I've never understood why folks get worked up over a little trailing whitespace here and there, since you can't see it and it doesn't affect correctness. Spurious whitespace changes that make a review harder - those are annoying. Trailing whitespace inadvertently left on lines w

Re: trailing whitespace

wrote: > On Sun, Nov 25, 2012 at 11:14 AM, Radim Kolar wrote: > >> I propose addition to QA bot - check for trailing whitespace in patches. >> Probably checking for tabs in Java files would be also good idea. >> >> > Checking for tabs I could get behind; checking for

Re: trailing whitespace

On Sun, Nov 25, 2012 at 11:14 AM, Radim Kolar wrote: > I propose addition to QA bot - check for trailing whitespace in patches. > Probably checking for tabs in Java files would be also good idea. > > Checking for tabs I could get behind; checking for trailing whitespace not so much.

Re: trailing whitespace

IIRC we still have a checkstyle section in the QA bot's checking script, if that still is interesting for devs to turn on again. At some point it was probably disabled. On Mon, Nov 26, 2012 at 12:44 AM, Radim Kolar wrote: > I propose addition to QA bot - check for trailing whitespace in

trailing whitespace

I propose addition to QA bot - check for trailing whitespace in patches. Probably checking for tabs in Java files would be also good idea.