Confirming that is what the intent was all about, and wasn’t meant to single
anyone out. Everyone has made errors in the git log. The YARN-2429 one was a
great, timely example given the recent discussion here and in HADOOP-11731 to
showcase that the git log is not a single, trustworthy source
Tsuyoshi - don't worry about it. Happens to all of us, we all try but the
manual steps are understandably error-prone. I believe Allen's intent was
more to say why we shouldn't use git log for release notes than
highlighting these commits :)
On Tue, Apr 7, 2015 at 11:41 PM, Tsuyoshi Ozawa wrote:
Oops, sorry for YARN-2666. I forgot to include JIRA number in git repository.
I'll see to it more and more based on the result of this discussion.
- Tsuyoshi
On Wed, Apr 8, 2015 at 10:13 AM, Colin P. McCabe wrote:
> The solution to this problem (if it is really a problem) is to keep
> around a s
The solution to this problem (if it is really a problem) is to keep
around a side file with some errata. I have such a side file that I
use with my script which compares two branches via git log. There's
always commits where the wrong message got applied, or the jira number
was missing, or etc.
For those wondering, YARN-2429 is the wrong JIRA for that commit. Simple typo,
but deadly if one is using to use the git log to determine what’s actually
committed...
A proper precommit hook could have prevented YARN-2666 mishap.
On Tue, Apr 7, 2015 at 9:55 AM, Allen Wittenauer wrote:
>
> On Apr 7, 2015, at 8:56 AM, Allen Wittenauer wrote:
>
> >
> > Find and fix the mistake made in the past 24 hours to the git log (and
> changes.txt as well, so no help there
On Apr 7, 2015, at 10:03 AM, Chris Nauroth wrote:
> Is this a trick question, because you really can't "fix" prior commits in
> the git log without a forced push, which then invalidates everyone's
> cloned copy of the repo? :-)
There is an error that would require such a thing, yes. :D
Is this a trick question, because you really can't "fix" prior commits in
the git log without a forced push, which then invalidates everyone's
cloned copy of the repo? :-)
Chris Nauroth
Hortonworks
http://hortonworks.com/
On 4/7/15, 9:55 AM, "Allen Wittenauer" wrote:
>
>On Apr 7, 2015, at
On Apr 7, 2015, at 8:56 AM, Allen Wittenauer wrote:
>
> Find and fix the mistake made in the past 24 hours to the git log (and
> changes.txt as well, so no help there!).
>
>
… and no, it isn’t that YARN-2666 is missing it’s JIRA in the changes.txt.
That’s too easy and besides, I sai
Find and fix the mistake made in the past 24 hours to the git log (and
changes.txt as well, so no help there!).
10 matches
Mail list logo
