Re: Resolving find bug issue

2012-06-27 Thread madhu phatak
Hi Robert, Thanks for your input.I have updated the patch with public getter for the host. On Tue, Jun 26, 2012 at 7:44 PM, Robert Evans wrote: > The issue you are running into is because you made the HOST variable > public, when it was package previously. Findbugs thinks that you want HOST >

Re: Resolving find bug issue

2012-06-26 Thread Robert Evans
The issue you are running into is because you made the HOST variable public, when it was package previously. Findbugs thinks that you want HOST to be a constant because it is ALL CAPS and is only set once and read all other times. By making it public it is now difficult to ensure that it is ne

Resolving find bug issue

2012-06-26 Thread madhu phatak
Hi, I have submitted a patch for jira (HADOOP-8521) which is giving findbug( https://issues.apache.org/jira/browse/HADOOP-8521) error. To fix the issue,I have to duplicate the StreamUtil class to the newly introduced mapreduce package.Is it a good practice or is there other way to fix this? Rega