Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-12-11 Thread Yongjun Zhang
Sorry my bad, I named Andrew Wang for Andrew Bayer in my last mail, both of them helped anyways:-) So thanks to all for the help on this matter! --Yongjun On Thu, Dec 11, 2014 at 3:38 PM, Yongjun Zhang wrote: > Many thanks to Ted Yu, Steve Loughran and Andrew Wang for replying in the > jira and

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-12-11 Thread Yongjun Zhang
Many thanks to Ted Yu, Steve Loughran and Andrew Wang for replying in the jira and Steve/Andrew for making the related changes! --Yongjun On Thu, Dec 11, 2014 at 12:41 PM, Yongjun Zhang wrote: > Hi, > > I wonder if anyone can help on resolving HADOOP-11320 >

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-12-11 Thread Yongjun Zhang
Hi, I wonder if anyone can help on resolving HADOOP-11320 to increase timeout for jenkins test of crossing-subproject patches? Thanks a lot, --Yongjun On Tue, Dec 2, 2014 at 10:10 AM, Yongjun Zhang wrote: > Hi, > > Thank you all for the inp

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-12-02 Thread Yongjun Zhang
Hi, Thank you all for the input. https://issues.apache.org/jira/browse/HADOOP-11320 was created for this issue. Welcome to give your further comments there. Best, --Yongjun On Tue, Nov 25, 2014 at 10:26 PM, Colin McCabe wrote: > +1 for increasing the test timeout for tests spanning multiple

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-11-25 Thread Colin McCabe
+1 for increasing the test timeout for tests spanning multiple sub-projects. I can see the value in what Steve L. suggested... if you make a major change that touches a particular subproject, you should try to get the approval of a committer who knows that subproject. But I don't think that forci

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-11-25 Thread Yongjun Zhang
Thanks all for the feedback. To summarize (and I have a suggestion at the end of this email), there are two scenarios: 1. A change that span multiple *bigger* projects. r.g. hadoop, hbase. 2. A change that span multiple *sub* projects* within hadoop, e.g., common, hdfs, yarn For 1, it's

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-11-25 Thread Steve Loughran
On 25 November 2014 at 00:58, Bernd Eckenfels wrote: > Hello, > > Am Mon, 24 Nov 2014 16:16:00 -0800 > schrieb Colin McCabe : > > > Conceptually, I think it's important to support patches that modify > > multiple sub-projects. Otherwise refactoring things in common > > becomes a multi-step proce

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-11-24 Thread Bernd Eckenfels
Hello, Am Mon, 24 Nov 2014 16:16:00 -0800 schrieb Colin McCabe : > Conceptually, I think it's important to support patches that modify > multiple sub-projects. Otherwise refactoring things in common > becomes a multi-step process. This might be rather philosophical (and I dont want to argue the

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-11-24 Thread Vinayakumar B
As I mentioned jn HADOOP-11293, This is not issue of any script, but the execution time. Actually jenkins is getting triggered. But since changes involves multiple projects, executing tests for all those projects taking more time. currently in jenkins if build time is more than 5 hours, then that

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-11-24 Thread Colin McCabe
Multi-subproject patches used to work. If they don't work now, it is probably a bug in test-patch.sh that we should fix. The code there is written expecting multi-project changes, but maybe it doesn't get much of a workout normally. Conceptually, I think it's important to support patches that mo

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-11-19 Thread Yongjun Zhang
Thanks for your input Steve! --Yongjun On Wed, Nov 19, 2014 at 1:45 AM, Steve Loughran wrote: > If you have a change that spans the projects you need to submit a separate > JIRA for each one anyway, to give each team the ability to > review/accept/reject the patch > > On 18 November 2014 23:58

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-11-19 Thread Steve Loughran
If you have a change that spans the projects you need to submit a separate JIRA for each one anyway, to give each team the ability to review/accept/reject the patch On 18 November 2014 23:58, Ray Chiang wrote: > I had to go back and look, but it was Akira Ajisaka that had recommended it > back w

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-11-18 Thread Yongjun Zhang
Thanks Chris and Ray, I created https://issues.apache.org/jira/browse/INFRA-8655 for this matter. --Yongjun On Tue, Nov 18, 2014 at 2:58 PM, Ray Chiang wrote: > I had to go back and look, but it was Akira Ajisaka that had recommended it > back when I ran into the issue: > > > https://issues.a

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-11-18 Thread Ray Chiang
I had to go back and look, but it was Akira Ajisaka that had recommended it back when I ran into the issue: https://issues.apache.org/jira/browse/HADOOP-10946?focusedCommentId=14108880&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14108880 Fortunately, my patch was

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-11-18 Thread Chris Nauroth
That's an interesting find. This has not always been the case. In the past, we've provided consolidated patches on a HADOOP jira to get pre-commit coverage when changes span multiple sub-projects. Yongjun, if you haven't already done so, I suggest filing a jira for this. Chris Nauroth Hortonwor

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-11-15 Thread Yongjun Zhang
For all's info, confirmed what Ray stated, indeed it's the reason! Thanks. --Yongjun On Fri, Nov 14, 2014 at 2:40 PM, Yongjun Zhang wrote: > Many thanks Ray, good to know! > > --Yongjun > > On Fri, Nov 14, 2014 at 2:03 PM, Ray Chiang wrote: > >> Your patch covers multiple projects (I see 81

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-11-14 Thread Yongjun Zhang
Many thanks Ray, good to know! --Yongjun On Fri, Nov 14, 2014 at 2:03 PM, Ray Chiang wrote: > Your patch covers multiple projects (I see 81 files across > hadoop-common-project, hadoop-hdfs-project, hadoop-mapreduce-project, > hadoop-tools, hadoop-yarn-project). > > Jenkins had problems with th

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-11-14 Thread Ray Chiang
Your patch covers multiple projects (I see 81 files across hadoop-common-project, hadoop-hdfs-project, hadoop-mapreduce-project, hadoop-tools, hadoop-yarn-project). Jenkins had problems with that for me a few months back. If you break it up per-project, it should work just fine. -Ray On Fri, N

Re: submitting a hadoop patch doesn't trigger jenkins test run

2014-11-14 Thread Ted Yu
Adding builds@apache On Fri, Nov 14, 2014 at 1:34 PM, Yongjun Zhang wrote: > Hi, > > One issue to report here, any help would be greatly appreciated! > > I noticed that multiple patch submissions to > https://issues.apache.org/jira/browse/HADOOP-11293 > did not trigger jenkins test run. > > Than