Re: FYI: Major, long-standing Issue with trunk's test-patch

2015-10-30 Thread Colin P. McCabe
Thanks for finding this issue, Allen. This is somewhat of a tangent, but I'm curious who still uses hadoop-pipes. Certainly development has more or less stopped on it. I think the last 5 years of commits on it have been things like updating version numbers, fixing missing #includes, moving to CMa

RE: FYI: Major, long-standing Issue with trunk's test-patch

2015-10-29 Thread Vinayakumar B
@hadoop.apache.org Subject: Re: FYI: Major, long-standing Issue with trunk's test-patch Are these RAT errors related to the previous discussion about running RAT after tests? I thought we resolved to run RAT prior, since that's what a release tarball will look like. On Thu, Oct 29, 2015 at 8:40

Re: FYI: Major, long-standing Issue with trunk's test-patch

2015-10-29 Thread Andrew Wang
Are these RAT errors related to the previous discussion about running RAT after tests? I thought we resolved to run RAT prior, since that's what a release tarball will look like. On Thu, Oct 29, 2015 at 8:40 AM, Chris Nauroth wrote: > +1 to treating it as a bug in Hadoop code if a test writes a

Re: FYI: Major, long-standing Issue with trunk's test-patch

2015-10-29 Thread Chris Nauroth
+1 to treating it as a bug in Hadoop code if a test writes a file outside of the target directory. This has the side effect that "mvn clean" doesn't really clean up fully. HADOOP-12519 is a recent patch I committed to fix this kind of problem in hadoop-azure. Let's follow up with similar fixes i

Re: FYI: Major, long-standing Issue with trunk's test-patch

2015-10-29 Thread Steve Loughran
> On 29 Oct 2015, at 04:18, Sean Busbey wrote: > > > At a quick glance, I see ASF license failures on HADOOP-9613, but > looking at the flagged files: > > https://builds.apache.org/job/PreCommit-HADOOP-Build/7966/artifact/patchprocess/patch-asflicense-problems.txt > > It is dumping test files

Re: FYI: Major, long-standing Issue with trunk's test-patch

2015-10-29 Thread Sean Busbey
In Maven projects, all build generated files (including test working space) is supposed to be under directories named 'target'. I believe a few folks already have an issue open to correct the HDFS tests: https://issues.apache.org/jira/browse/HDFS-9263 Please make sure these incorrect paths are c

Re: FYI: Major, long-standing Issue with trunk's test-patch

2015-10-29 Thread Vinayakumar B
Thanks, In HDFS precommmit builds we can see ASF licence check. HDFS uses /build as a test directory for some tests, I think this is an exception case. https://builds.apache.org/job/PreCommit-HDFS-Build/13268/artifact/patchprocess/patch-asflicense-problems.txt Regards, Vinay On Thu, Oct 29, 201

Re: FYI: Major, long-standing Issue with trunk's test-patch

2015-10-28 Thread Sean Busbey
On Wed, Oct 28, 2015 at 9:23 PM, Vinayakumar B wrote: > So I’m going to turn on Yetus for *ALL* Hadoop precommit jobs >> later tonight. (Given how backed up Jenkins is at the moment, there is >> plenty of time. haha) Anyway, if you see “Powered by Yetus” in the Hadoop >> QA posts, you’ve got Yet

Re: FYI: Major, long-standing Issue with trunk's test-patch

2015-10-28 Thread Vinayakumar B
So I’m going to turn on Yetus for *ALL* Hadoop precommit jobs > later tonight. (Given how backed up Jenkins is at the moment, there is > plenty of time. haha) Anyway, if you see “Powered by Yetus” in the Hadoop > QA posts, you’ve got Yetus. If you don’t see it, it ran on trunk’s > test-patch. +

Re: FYI: Major, long-standing Issue with trunk's test-patch

2015-10-28 Thread Karthik Kambatla
On Tue, Oct 27, 2015 at 7:44 PM, Allen Wittenauer wrote: > > Today I discovered that an old, old code change (circa 2012) > caused certain maven modules to be skipped during the precommit testing. > That code had been carried forward through all the rewrites, bug fixes, > etc, over the ye

Re: FYI: Major, long-standing Issue with trunk's test-patch

2015-10-28 Thread Tsuyoshi Ozawa
> So I’m going to turn on Yetus for *ALL* Hadoop precommit jobs later tonight. Thank you for sharing, Allen. I think this activity will make quality of Hadoop code better. Best - Tsuyoshi On Wed, Oct 28, 2015 at 11:44 AM, Allen Wittenauer wrote: > > Today I discovered that an old, o