Re: CMake and CMAKE_LD_FLAGS

2015-06-18 Thread Alan Burlison
On 15/06/2015 22:59, Colin P. McCabe wrote: I think you are right that CMAKE_LD_FLAGS has never done anything, and setting it was always a mistake. The uses of CMAKE_LD_FLAGS in JNIFlags.cmake are harmless, since the -m32 option is not needed for the linker. However, it's more concerning that

Re: CMake and CMAKE_LD_FLAGS

2015-06-15 Thread Colin P. McCabe
Hi Alan, I think you are right that CMAKE_LD_FLAGS has never done anything, and setting it was always a mistake. The uses of CMAKE_LD_FLAGS in JNIFlags.cmake are harmless, since the -m32 option is not needed for the linker. However, it's more concerning that hadoop-mapreduce-client-nativetask se

Re: CMake and CMAKE_LD_FLAGS

2015-06-04 Thread Alan Burlison
On 03/06/2015 21:23, Alan Burlison wrote: hadoop-common-project/hadoop-common/src/JNIFlags.cmake sets the CMAKE_LD_FLAGS variable to the flags required for the linker. However, despite the name, CMAKE_LD_FLAGS is *not* a valid standard CMake variable Confirmed, I've put nonsense flags in CMAKE