Re: [DISCUSS] HADOOP-9122 Add power mock library for writing better unit tests

2017-10-27 Thread Chris Douglas
kages that can not work with powermock reflection. > > Hence, I rest my case for re-opening this issue. > > > > Regards, > > Eric > > > > From: Steve Loughran > > Date: Sunday, October 1, 2017 at 12:36 PM > > To: Eri

Re: [DISCUSS] HADOOP-9122 Add power mock library for writing better unit tests

2017-10-02 Thread Eric Yang
nce, I rest my case for re-opening this issue. > > Regards, > Eric > > From: Steve Loughran > Date: Sunday, October 1, 2017 at 12:36 PM > To: Eric Yang > Cc: Andrew Wang , Chris Douglas , "common-dev@hadoop.apache.org" > S

Re: [DISCUSS] HADOOP-9122 Add power mock library for writing better unit tests

2017-10-02 Thread Chris Douglas
> > Regards, > Eric > > From: Steve Loughran > Date: Sunday, October 1, 2017 at 12:36 PM > To: Eric Yang > Cc: Andrew Wang , Chris Douglas > , "common-dev@hadoop.apache.org" > > Subject: Re: [DISCUSS] HADOOP-9122 Add power mock library for writing better

Re: [DISCUSS] HADOOP-9122 Add power mock library for writing better unit tests

2017-10-02 Thread Eric Yang
hran Date: Sunday, October 1, 2017 at 12:36 PM To: Eric Yang Cc: Andrew Wang , Chris Douglas , "common-dev@hadoop.apache.org" Subject: Re: [DISCUSS] HADOOP-9122 Add power mock library for writing better unit tests On 29 Sep 2017, at 22:46, Eric Yang mailto:ey...@hortonworks.com&g

Re: [DISCUSS] HADOOP-9122 Add power mock library for writing better unit tests

2017-10-01 Thread Steve Loughran
On 29 Sep 2017, at 22:46, Eric Yang mailto:ey...@hortonworks.com>> wrote: Hi Chris and Andrew, The intend is for new code to have better unit test cases without resort to invocation of miniHDFSCluster or miniYarnCluster. Existing code don’t require refactoring, if the test cases already have

Re: [DISCUSS] HADOOP-9122 Add power mock library for writing better unit tests

2017-09-30 Thread Chris Douglas
> Eric > > > > From: Andrew Wang > Date: Friday, September 29, 2017 at 1:55 PM > To: Chris Douglas > Cc: Eric Yang , "common-dev@hadoop.apache.org" > > Subject: Re: [DISCUSS] HADOOP-9122 Add power mock library for writing better > unit tests > >

Re: [DISCUSS] HADOOP-9122 Add power mock library for writing better unit tests

2017-09-29 Thread Eric Yang
rethink the improvement that Powermock can bring to the table. Thank you for your considation. Regards, Eric From: Andrew Wang Date: Friday, September 29, 2017 at 1:55 PM To: Chris Douglas Cc: Eric Yang , "common-dev@hadoop.apache.org" Subject: Re: [DISCUSS] HADOOP-9122 Add

Re: [DISCUSS] HADOOP-9122 Add power mock library for writing better unit tests

2017-09-29 Thread Andrew Wang
Making code testable is about a lot more than your mocking library. In HDFS, the NameNode is very monolithic, so it's hard to instantiate little pieces of functionality in isolation and mock things out. I have my doubts that Powermock will help with this unless someone's willing to invest in signif

Re: [DISCUSS] HADOOP-9122 Add power mock library for writing better unit tests

2017-09-29 Thread Chris Douglas
Eric- Can you explain how Powermock differs from/augments Mockito, why we should adopt it, and maybe an example of an existing test that could be improved using this library? -C On Fri, Sep 29, 2017 at 10:12 AM, Eric Yang wrote: > Hi Hadoop-dev, > > Long time ago, Hadoop community decided to put