Re: Question about how to best contribute

+1 for Steve's and Chris's sentiments.  Mass reformatting of existing code can make maintaining anything released prior to the makeover very difficult.  Almost all of Apache Hadoop's users are not on trunk or branch-2, and I'm not sure we want large refactoring patches going into stability lines

Re: Question about how to best contribute

> On 8 Aug 2017, at 21:33, Chris Douglas wrote: > > Lars- > > Welcome! > > As a mild refinement of enthusiasm for this proposal: when you > approach a "cleanup", please consider the cost to tracing the lineage > of changes in the codebase. Working on a project as large and > long-running as Ha

Re: Question about how to best contribute

Lars- Welcome! As a mild refinement of enthusiasm for this proposal: when you approach a "cleanup", please consider the cost to tracing the lineage of changes in the codebase. Working on a project as large and long-running as Hadoop, we often need to trace what motivated a particular change using

Re: Question about how to best contribute

Hi Akira, > > So, this is my request for comments on these questions: > > * Is there any interest in this at all? > > ** "This" being patches for code style & things like FindBugs & > Checkstyle > > warnings > > Yes. I'm interested in this. > > > * Size of the patches: Rather one big patch or sma

Re: Question about how to best contribute

Thanks John, another one for my list of things to look at. On Mon, Aug 7, 2017 at 11:24 PM, John Zhuge wrote: > And check out HADOOP-12145 > Organize and update > CodeReviewChecklist wiki. > > Thanks, your contribution will be greatly apprecia

Re: Question about how to best contribute

Thanks for the ideas Steve. Hi Lars & Welcome! > > Maybe the first step here would be look at those style guides and think > how to bring them up to date, especially with stuff like lambda-expressions > in java 8, and mnodules forthcoming in in java 9, SLF4J logging, Junit 5 -> > 5 testing, code i

Re: Question about how to best contribute

Hi Lars, Thank you for your questions! > So, this is my request for comments on these questions: > * Is there any interest in this at all? > ** "This" being patches for code style & things like FindBugs & Checkstyle > warnings Yes. I'm interested in this. > * Size of the patches: Rather one bi

Re: Question about how to best contribute

And check out HADOOP-12145 Organize and update CodeReviewChecklist wiki. Thanks, your contribution will be greatly appreciated! On Mon, Aug 7, 2017 at 5:53 AM, Steve Loughran wrote: > > Hi Lars & Welcome! > > Maybe the first step here would

Re: Question about how to best contribute

Hi Lars & Welcome! Maybe the first step here would be look at those style guides and think how to bring them up to date, especially with stuff like lambda-expressions in java 8, and mnodules forthcoming in in java 9, SLF4J logging, Junit 5 -> 5 testing, code instrumentation, diagnostics, log s

Question about how to best contribute

Hi, a few words about me: I've contributed to Hadoop (and it's ecosystem[4]) in the past am a Hive committer and have used Hadoop for 10 years now, so I'm not totally inexperienced. I'm earning my money as a Hadoop consultant so I've seen dozens of real-life clusters in my life. As part of a few