Re: Code coverage report on github PRs

2022-11-27 Thread Wilfred Spiegelenburg
Ayush, For YuniKorn we have codecov working. We did have to make some minor changes to get that done. It is all github action driven [1]. The action is approved for Apache repos. The first thing is that we asked INFRA to get the codecov app added to our repos [2]. Beside that to get codecov worki

Re: Code coverage report on github PRs

2022-11-24 Thread Ayush Saxena
I tried to explore a bit more about codecov and tried to set that up in my local fork by allowing access and adding the Github Action in the yaml file(& lots of follow up fixes), I think it needs the tests as well to be executed as part of the github workflow, which we don't do, or there is some ca

Re: Code coverage report on github PRs

2022-11-23 Thread Wei-Chiu Chuang
I believe most of them can be added by us using GitHub Workflow. There's a marketplace for these tools and most of them are free for open source projects. On Wed, Nov 23, 2022 at 11:43 AM Ayush Saxena wrote: > A simple Infra ticket I suppose should get it done for us, eg. > https://issues.apache

Re: Code coverage report on github PRs

2022-11-23 Thread Ayush Saxena
A simple Infra ticket I suppose should get it done for us, eg. https://issues.apache.org/jira/browse/INFRA-23561 -Ayush On Thu, 24 Nov 2022 at 01:00, Iñigo Goiri wrote: > Now that we are using mostly GitHub PRs for the reviews and we have decent > integration for the builds etc there, I was won

Code coverage report on github PRs

2022-11-23 Thread Iñigo Goiri
Now that we are using mostly GitHub PRs for the reviews and we have decent integration for the builds etc there, I was wondering about code coverage and reporting. Is code coverage setup at all? Does this come from the INFRA team? What would it take to enable it otherwise?