Re: [NOTICE] Building trunk needs protoc 3.7.1

2019-09-23 Thread Duo Zhang
The new protobuf plugin related issues have all been pushed to trunk(though I think we'd better port them to all active branches). So what's the next step? Shade and relocated protobuf? HBase has already done this before so I do not think it will take too much time. If we all agree on the solution

Re: [NOTICE] Building trunk needs protoc 3.7.1

2019-09-23 Thread Wangda Tan
Hi Vinay, Thanks for the clarification. Do you have a timeline about all you described works w.r.t. the compatibility will be completed? I'm asking this is because we need to release 3.3.0 earlier if possible since there're 1k+ of patches in 3.3.0 already, we should get it out earlier. If the P

Re: [NOTICE] Building trunk needs protoc 3.7.1

2019-09-23 Thread Steve Loughran
aah, that makes sense On Sun, Sep 22, 2019 at 6:11 PM Vinayakumar B wrote: > Thanks Steve. > > Idea is not to shade all artifacts. > Instead maintain one artifact ( hadoop-thirdparty) which have all such > dependencies ( com.google.* may be), add this artifact as dependency in > hadoop modules.

Re: [NOTICE] Building trunk needs protoc 3.7.1

2019-09-22 Thread Vinayakumar B
Thanks Steve. Idea is not to shade all artifacts. Instead maintain one artifact ( hadoop-thirdparty) which have all such dependencies ( com.google.* may be), add this artifact as dependency in hadoop modules. Use shaded classes directly in the code of hadoop modules instead of shading at package

Re: [NOTICE] Building trunk needs protoc 3.7.1

2019-09-22 Thread Steve Loughran
On Sun, Sep 22, 2019 at 3:22 PM Vinayakumar B wrote: >Protobuf provides Wire compatibility between releases.. but not > guarantees the source compatibility in generated sources. There will be a > problem in compatibility if anyone uses generated protobuf message outside > of Hadoop modules. W

Re: [NOTICE] Building trunk needs protoc 3.7.1

2019-09-22 Thread Vinayakumar B
Protobuf provides Wire compatibility between releases.. but not guarantees the source compatibility in generated sources. There will be a problem in compatibility if anyone uses generated protobuf message outside of Hadoop modules. Which ideally shouldn't be as generated sources are not public A

Re: [NOTICE] Building trunk needs protoc 3.7.1

2019-09-22 Thread Vinod Kumar Vavilapalli
Quick question, being lazy here, lots of JIRA updates on HADOOP-13363 over the years not helping either. Does anyone know what this upgrade will mean w.r.t compatibility for the Hadoop releases themselves? Remember that trunk is still 3.x. Thanks +Vinod > On Sep 21, 2019, at 9:55 AM, Vinayakum

Re: [NOTICE] Building trunk needs protoc 3.7.1

2019-09-20 Thread Vinayakumar B
@Wangda Tan , Sorry for the confusion. HADOOP-13363 is umbrella jira to track multiple stages of protobuf upgrade in subtasks. (jar upgrade, Docker update, plugin upgrade, shading, etc). Right now, first task of jar upgrade is done. So need to update the protoc executable in the in build environme

Re: [NOTICE] Building trunk needs protoc 3.7.1

2019-09-20 Thread Duo Zhang
I think this one is alread in place so we have to upgrade... https://issues.apache.org/jira/browse/HADOOP-16557 Wangda Tan 于2019年9月21日周六 上午7:19写道: > Hi Vinay, > > A bit confused, I saw the HADOOP-13363 is still pending. Do we need to > upgrade protobuf version to 3.7.1 NOW or once HADOOP-13363

Re: [NOTICE] Building trunk needs protoc 3.7.1

2019-09-20 Thread Duo Zhang
As suggested before, please consider switching to maven protobuf plugin first before upgrading the protobuf dependency. https://www.xolstice.org/protobuf-maven-plugin/examples/protoc-artifact.html This plugin will download the protoc binary automatically so we do not need to have developers inst

Re: [NOTICE] Building trunk needs protoc 3.7.1

2019-09-20 Thread Wangda Tan
Hi Vinay, A bit confused, I saw the HADOOP-13363 is still pending. Do we need to upgrade protobuf version to 3.7.1 NOW or once HADOOP-13363 is completed? Thanks, Wangda On Fri, Sep 20, 2019 at 8:11 AM Vinayakumar B wrote: > Hi All, > > A very long pending task, protobuf upgrade is happening in

[NOTICE] Building trunk needs protoc 3.7.1

2019-09-20 Thread Vinayakumar B
Hi All, A very long pending task, protobuf upgrade is happening in HADOOP-13363. As part of that protobuf version is upgraded to 3.7.1. Please update your build environments to have 3.7.1 protobuf version. BUILIDING.txt has been updated with latest instructions. This pre-requisite to update pro