Thank you for the discussion.
I didn't know that assertj is already on the test classpath for some modules.
> I think it'd be good to make the new tests Junit 5+ aspect, rather than
> mixed, as it'll confuse backporting a lot.
+1 for the idea.
Here is a summary:
- Let's upgrade the existing te
+1, on AssertJ usage, thanks for getting this done.
--Anu
On 3/31/19, 9:37 PM, "Akira Ajisaka" wrote:
Hi folks,
Now I'm going to upgrade the JUnit version from 4 to 5 for Java 11 support.
I wanted to start with the small module, so I uploaded a patch to upgrade
the API in h
assertj is already on the test classpath for some modules already, though
an older version (3.8.0) from what's current (3.12.0)
No problems seem to have surfaced, so I don't see anything wrong with
picking it up more broadly.
if someone wants to update the assertj version, it's only a test artifa
>
>>
> + if any can point to some good articles/presentations on junit5+assertJ,
> then please share the links
>
>
>
On Mon, Apr 1, 2019 at 5:37 AM Akira Ajisaka wrote:
> Hi folks,
>
> Now I'm going to upgrade the JUnit version from 4 to 5 for Java 11 support.
> I wanted to start with the small module, so I uploaded a patch to upgrade
> the API in hadoop-yarn-api module at first (YARN-8943), and in this JIRA,
>
Thanks Akira. +1 for your opinion. I will review YARN-8943 after this
discussion has finished.
- Takanobu
on 2019/04/01 14:07, "Sree V" wrote:
My opinion:
- Upgrade to JUnit5.- Use an Assertion Framework. Preferably, AssertJ as
JUnit5 user guide full of it.
Thank you./Sree
My opinion:
- Upgrade to JUnit5.- Use an Assertion Framework. Preferably, AssertJ as JUnit5
user guide full of it.
Thank you./Sree
On Sunday, March 31, 2019, 9:37:52 PM PDT, Akira Ajisaka
wrote:
Hi folks,
Now I'm going to upgrade the JUnit version from 4 to 5 for Java 11 support.
I
Hi folks,
Now I'm going to upgrade the JUnit version from 4 to 5 for Java 11 support.
I wanted to start with the small module, so I uploaded a patch to upgrade
the API in hadoop-yarn-api module at first (YARN-8943), and in this JIRA,
Szilard Nemeth suggested using AssertJ with JUnit 5. (Thanks Szi
