Re: [DISCUSS] Integration of Volcano Engine TOS in Hadoop.

2025-03-14 Thread Jinglun
Thanks xiaoqiao for your nice suggestion, agree for a formal VOTE. About the jenkins report. The pr is too big (over 2 lines) for jenkins to apply the patch (https://github.com/apache/hadoop/pull/7194). My plan is to split it into 2 pull request. The first pr includes the core implementati

Re: [DISCUSS] Integration of Volcano Engine TOS in Hadoop.

2025-03-13 Thread Xiaoqiao He
Thanks Jinglun for your work. LGTM. +1 from my side. BTW, Please check Jenkins report, it is better to get +1 from Jenkins before check in. cc @PJ Fanning @Steve Loughran @slfan1989 would you mind taking another check? If there are no more other comments or concerns, I just suggest launching ano

Re: [DISCUSS] Integration of Volcano Engine TOS in Hadoop.

2025-03-11 Thread Jinglun
**Update** Hello everyone, thanks a lot for your attention. I'm happy to share the progress here. 1. Kotlin is removed. The library ve-tos-java-sdk has been updated to ve-tos-java-sdk-hadoop (https://github.com/volcengine/ve-tos-java-sdk/tree/ve-tos-java-sdk-hadoop), which is developed based

Re: [DISCUSS] Integration of Volcano Engine TOS in Hadoop.

2025-02-18 Thread Jinglun
**Update** I discussed with the main tos sdk developer xiang(evansxi...@126.com), he would be happy to provide a new sdk depends on apache http-client. The new sdk would be released at 3/15. Thanks xiang for your help. If there are any other questions, please feel free to comment. On 2025/0

Re: [DISCUSS] Integration of Volcano Engine TOS in Hadoop.

2025-02-16 Thread Jinglun
Thanks PJ Fanning and slfan for your suggestions ! > Would it be possible to consider using a lightweight HTTP client instead? Thanks for reminding me, this makes sense to me. I'll try to solve it as soon as possible. > We are upgrading to Junit5 and need TOS's Unit Tests to be developed in the

Re: [DISCUSS] Integration of Volcano Engine TOS in Hadoop.

2025-02-14 Thread slfan1989
Thanks to Jinglun for initiating the discussion on TOS. +1 from my personal perspective. However, considering that we are upgrading to Junit5 and need TOS's Unit Tests to be developed in the Junit5 way, we can discuss it together under the relevant PR. Regarding PJ Fanning's suggestion, I think

Re: [DISCUSS] Integration of Volcano Engine TOS in Hadoop.

2025-02-14 Thread PJ Fanning
Just one thing to note is that we recently removed or reduced the okhttp3 dependency in Hadoop because the kotlin dependency brings in big jars and more complicated management of transitive dependencies. Would it be possible to consider using a lightweight HTTP client instead? The built-in Java cli

Re: [DISCUSS] Integration of Volcano Engine TOS in Hadoop.

2025-02-14 Thread Jinglun
Thanks xiaoqiao and steve for your attention and comments. Let me answer the dependencies and tests. **Dependencies** Hadoop-tos involves a new dependency com.volcengine:ve-tos-java-sdk:2.8.6. It is an open source project with apache 2.0 license (https://github.com/volcengine/ve-tos-java-sdk/b

Re: [DISCUSS] Integration of Volcano Engine TOS in Hadoop.

2025-02-13 Thread Steve Loughran
Sounds good, though expect no commitment from me to review anything. My main concerns are about dependency libraries (what are they?) and testing. On Tue, 11 Feb 2025 at 05:10, Xiaoqiao He wrote: > Thanks Jinglun for your work. Basically +1 from me to involve it into the > Hadoop codebase. > a.

Re: [DISCUSS] Integration of Volcano Engine TOS in Hadoop.

2025-02-10 Thread Xiaoqiao He
Thanks Jinglun for your work. Basically +1 from me to involve it into the Hadoop codebase. a. After a quick review of JIRA and PR, I think it is solid including document and code style. b. Contributors involved here are diverse who are from different projects and companies, and active enough. c. Co