[jira] [Created] (HADOOP-11404) Clarify the "expected client Kerberos principal is null" authorization message

2014-12-13 Thread Stephen Chu (JIRA)
Stephen Chu created HADOOP-11404: Summary: Clarify the "expected client Kerberos principal is null" authorization message Key: HADOOP-11404 URL: https://issues.apache.org/jira/browse/HADOOP-11404 Proj

Re: Solaris Port SOLVED!

2014-12-13 Thread malcolm
I am checking on the latest release of Solaris 11 and yes, it is still thread safe (or MT Safe as documented on the man page). strerror checks the error code, and returns the same "unknown error" string as terror does, if it receives an invalid code. I checked this on Windows, Solaris and Linu

Re: a friendly suggestion for developers when uploading patches

2014-12-13 Thread Yongjun Zhang
Hi Konst, Thanks for the good suggestion, certainly that would help. Here are the advantages to include revision number in the patch name: - we would have the same ordering by name or by date - it would be easier to refer to individual patch, say, when we need to refer to multiple patch

RE: Solaris Port SOLVED!

2014-12-13 Thread Asokan, M
Malcom, That's great! Is strerror() thread-safe in the recent version of Solaris? In any case, to be correct you still need to make sure that the code passed to strerror() is a valid one. For this you need to check errno after the call to strerror(). Please check the code snippet I sent ea

[jira] [Created] (HADOOP-11403) Solaris does not support sys_errlist requires use of strerror instead

2014-12-13 Thread Malcolm Kavalsky (JIRA)
Malcolm Kavalsky created HADOOP-11403: - Summary: Solaris does not support sys_errlist requires use of strerror instead Key: HADOOP-11403 URL: https://issues.apache.org/jira/browse/HADOOP-11403 Pro

Re: a friendly suggestion for developers when uploading patches

2014-12-13 Thread Andrew Wang
Konst, Sometimes it's also useful to refer to patches by revision number during an extended review. The upload time doesn't perfectly fulfill this requirement since reviewers often download patch files locally. This is why I still like having a revision number, even though I'm aware of "sort by d

Re: Solaris Port SOLVED!

2014-12-13 Thread malcolm
Wiping egg off face ... After consulting with the Solaris team (and looking at the source code and man page) , it turns out that strerror itself on Solaris is MT-Safe ! (Just like HPUX) So, after all this effort, all I need to do is modify terror as follows: const char* terror(int errnu

Re: a friendly suggestion for developers when uploading patches

2014-12-13 Thread Konstantin Shvachko
Hello guys, The problem here is not in a patch naming conventions, but in the jira default ordering schema for attachments. Mentioned it on several occasions. Currently attachments use "sort by name" sorting as the default. And it should be changed to "sort by date". Then you don't need any naming

Re: Solaris Port

2014-12-13 Thread Steve Loughran
On 13 December 2014 at 09:29, malcolm wrote: > I am not sure what you mean by a thread-local buffer (in native code). In > Java this is pretty standard, but I couldn't find any implementation for C > code. There's stuff around; I don't know how well it works across different platforms; certainl

Re: Solaris Port

2014-12-13 Thread malcolm
Thanks Asokan, Looked up Gcc's thread local variables, seems a bit complex though and quite specific to Gnu. Intialization of the static errlist array should be thread safe i.e. initially the array is nulled out, and afterwards if two threads write to the same address, then they would be wri

Re: Solaris Port

2014-12-13 Thread Asokan, M
Malcom, Gcc supports thread-local variables. See https://gcc.gnu.org/onlinedocs/gcc-3.3.1/gcc/Thread-Local.html I am not sure about native compilers on Solaris, HPUX, or AIX. In any case, I found out that the Windows native code in Hadoop seems to handle error messages properly. Here is what

Re: Solaris Port

2014-12-13 Thread Steve Loughran
On 12 December 2014 at 04:35, malcolm wrote: > So, turns out that if I had naively changed all calls to terror or > references to sys_errlist, to using strerror_r, then I would have broken > code for Windows and HPUX (and possibly other OSes). > > If we are to assume that current code runs fine o

Build failed in Jenkins: Hadoop-common-trunk-Java8 #42

2014-12-13 Thread Apache Jenkins Server
See Changes: [wheat9] HDFS-7517. Remove redundant non-null checks in FSNamesystem#getBlockLocations. Contributed by Haohui Mai. [arp] HDFS-7514. TestTextCommand fails on Windows. (Arpit Agarwal) [jing9] HDFS-7059. Avoid resol

Build failed in Jenkins: Hadoop-Common-trunk #1342

2014-12-13 Thread Apache Jenkins Server
See Changes: [stevel] YARN-2912 Jersey Tests failing with port in use. (varun saxena via stevel) [wheat9] HDFS-7517. Remove redundant non-null checks in FSNamesystem#getBlockLocations. Contributed by Haohui Mai. [arp] HDFS-7514

Re: Solaris Port

2014-12-13 Thread malcolm
Colin, I am not sure what you mean by a thread-local buffer (in native code). In Java this is pretty standard, but I couldn't find any implementation for C code. Here is the terror function: const char* terror(int errnum) { if ((errnum < 0) || (errnum >= sys_nerr)) { re