Re: test patch fails with -1 findbugs

2013-05-11 Thread Ted Yu
Here was the command I used (on MacBook): ant test-patch -Dpatch.file=../ted-1.0.txt -Dfindbugs.home=/Users/tyu/findbugs-2.0.2 -Dforrest.home=/Users/tyu/apache-forrest-0.9 But I didn't get very far: [exec] BUILD FAILED [exec] /Users/tyu/apache-forrest-0.9/main/forrest.build.xml:54: /User

Re: test patch fails with -1 findbugs

2013-05-11 Thread Amit Sela
Following Ted Yu's advice, I created an empty patch and got the same results... any ideas ? I do notice findbugs complaining of missing classes: [exec] [findbugs] The following classes needed for analysis were missing: [exec] [findbugs] org.apache.tools.ant.Task [exec] [findbugs]

Re: test patch fails with -1 findbugs

2013-05-11 Thread Ted Yu
As validation step, you can run an empty patch (adding whitespace in any file) through test-patch. You would have base number of findbugs warnings. Cheers On Sat, May 11, 2013 at 12:24 PM, Amit Sela wrote: > Hi all, > > I've recently added a patch to branch-1 and I wanted to run test-patch. > I

test patch fails with -1 findbugs

2013-05-11 Thread Amit Sela
Hi all, I've recently added a patch to branch-1 and I wanted to run test-patch. I run: ant test-patch -Dpatch.file=../HADOOP-6103-branch-1.patch -Dfindbugs.home=/usr/local/findbugs-1.3.9 -Dforrest.home=/usr/local/apache-forrest-0.9 and I get: BUILD SUCCESSFUL [exec] Total time: 3 minutes 16

Re: [VOTE] Hadoop release candidate 1.2.0-rc1

2013-05-11 Thread Matt Foley
Hi Jason, It's taken me so long to get this 1.2.0 RC out, that I'd like to finish it and move on with a 1.2.1 stabilization release. If I commit to doing 1.2.1 in 3 to 4 weeks, including this HADOOP-9504, would that be acceptable to you? Regards, --Matt On Fri, May 10, 2013 at 6:35 PM, Jason Low