Re: [PR] [Improve][Connector-v2] Optimize the way of databases and tables are checked for existence [seatunnel]

2024-07-29 Thread via GitHub
Hisoka-X commented on code in PR #7261: URL: https://github.com/apache/seatunnel/pull/7261#discussion_r1694700491 ## seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java: ## @@ -277,15 +285,24 @@ pub

Re: [I] [Feature][Prometheus] Support Prometheus connector source/sink [seatunnel]

2024-07-29 Thread via GitHub
CosmosNi commented on issue #7201: URL: https://github.com/apache/seatunnel/issues/7201#issuecomment-2255229524 hi,@hailin0,for writer,I haven't found a good way. use pushgateway or vm writer?for pushgateway,it cannot take timestamp -- This is an automated message from the Apache Git Ser

Re: [PR] [Improve][Connector-v2] Optimize the way of databases and tables are checked for existence [seatunnel]

2024-07-29 Thread via GitHub
dailai commented on code in PR #7261: URL: https://github.com/apache/seatunnel/pull/7261#discussion_r1694760837 ## seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java: ## @@ -277,15 +285,24 @@ publi

Re: [PR] [Improve][Connector-v2] Optimize the way of databases and tables are checked for existence [seatunnel]

2024-07-29 Thread via GitHub
Hisoka-X commented on code in PR #7261: URL: https://github.com/apache/seatunnel/pull/7261#discussion_r1694769571 ## seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java: ## @@ -277,15 +285,24 @@ pub

Re: [PR] [Improve][Connector-v2] Optimize the way of databases and tables are checked for existence [seatunnel]

2024-07-29 Thread via GitHub
dailai commented on code in PR #7261: URL: https://github.com/apache/seatunnel/pull/7261#discussion_r1694773452 ## seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java: ## @@ -277,15 +285,24 @@ publi

Re: [PR] [Improve][Connector-v2] Optimize the way of databases and tables are checked for existence [seatunnel]

2024-07-29 Thread via GitHub
Hisoka-X commented on code in PR #7261: URL: https://github.com/apache/seatunnel/pull/7261#discussion_r1694781715 ## seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java: ## @@ -277,15 +285,24 @@ pub

Re: [PR] [Improve][Connector-v2] Optimize the way of databases and tables are checked for existence [seatunnel]

2024-07-29 Thread via GitHub
dailai commented on code in PR #7261: URL: https://github.com/apache/seatunnel/pull/7261#discussion_r1694786247 ## seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java: ## @@ -277,15 +285,24 @@ publi

Re: [PR] [Improve][Connector-v2] Optimize the way of databases and tables are checked for existence [seatunnel]

2024-07-29 Thread via GitHub
dailai commented on code in PR #7261: URL: https://github.com/apache/seatunnel/pull/7261#discussion_r1694786247 ## seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java: ## @@ -277,15 +285,24 @@ publi

Re: [PR] [Improve][Connector-v2] Optimize the way of databases and tables are checked for existence [seatunnel]

2024-07-29 Thread via GitHub
Hisoka-X commented on code in PR #7261: URL: https://github.com/apache/seatunnel/pull/7261#discussion_r1694796297 ## seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java: ## @@ -277,15 +285,24 @@ pub

Re: [PR] [Improve][Connector-v2] Optimize the way of databases and tables are checked for existence [seatunnel]

2024-07-29 Thread via GitHub
dailai commented on code in PR #7261: URL: https://github.com/apache/seatunnel/pull/7261#discussion_r1694809411 ## seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java: ## @@ -277,15 +285,24 @@ publi

[PR] [Feature][Spark] Support multiple tables read and write [seatunnel]

2024-07-29 Thread via GitHub
Carl-Zhou-CN opened a new pull request, #7283: URL: https://github.com/apache/seatunnel/pull/7283 close #7009 ### Purpose of this pull request ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ### C

Re: [PR] [Bug][Connector-v2][KafkaSource]Fix the abnormal exit of KafkaConsumerThread. [seatunnel]

2024-07-29 Thread via GitHub
lightzhao commented on PR #7273: URL: https://github.com/apache/seatunnel/pull/7273#issuecomment-2255319232 > If we modify the logic like this, is it possible that the Kafka cluster is abnormal, but SeaTunnel cannot exit normally? Yes, the expectation is that the consumer thread will

Re: [PR] [Bug][Connector-v2][KafkaSource]Fix the abnormal exit of KafkaConsumerThread. [seatunnel]

2024-07-29 Thread via GitHub
Hisoka-X commented on PR #7273: URL: https://github.com/apache/seatunnel/pull/7273#issuecomment-2255389761 > > If we modify the logic like this, is it possible that the Kafka cluster is abnormal, but SeaTunnel cannot exit normally? > > Yes, the expectation is that the consumer thread

Re: [I] [Doc][Improve] support chinese [seatunnel]

2024-07-29 Thread via GitHub
Zengwenliang0416 commented on issue #6378: URL: https://github.com/apache/seatunnel/issues/6378#issuecomment-2255407253 Please assign it to me : start-v2/docker/docker.md Thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [Improve][Core] Improve base on plugin name of lookup strategy [seatunnel]

2024-07-29 Thread via GitHub
Carl-Zhou-CN commented on PR #7278: URL: https://github.com/apache/seatunnel/pull/7278#issuecomment-2255439998 good job @corgy-w -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

(seatunnel) branch dev updated: [Improve][Core] Improve base on plugin name of lookup strategy (#7278)

2024-07-29 Thread zhouyao2023
This is an automated email from the ASF dual-hosted git repository. zhouyao2023 pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 21c4f5245e [Improve][Core] Improve base on plu

Re: [I] [Bug] [plugin-discovery] Jar found with same prefix [seatunnel]

2024-07-29 Thread via GitHub
Carl-Zhou-CN closed issue #7271: [Bug] [plugin-discovery] Jar found with same prefix URL: https://github.com/apache/seatunnel/issues/7271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [Improve][Core] Improve base on plugin name of lookup strategy [seatunnel]

2024-07-29 Thread via GitHub
Carl-Zhou-CN merged PR #7278: URL: https://github.com/apache/seatunnel/pull/7278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@sea

Re: [PR] [Improve] Improve thrift shade packages in doris jar [seatunnel]

2024-07-29 Thread via GitHub
Carl-Zhou-CN merged PR #7279: URL: https://github.com/apache/seatunnel/pull/7279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@sea

Re: [I] [Bug] Unable to create a source for identifier 'Iceberg'. [seatunnel]

2024-07-29 Thread via GitHub
Carl-Zhou-CN closed issue #7182: [Bug] Unable to create a source for identifier 'Iceberg'. URL: https://github.com/apache/seatunnel/issues/7182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

(seatunnel) branch dev updated: fix [Bug] Unable to create a source for identifier 'Iceberg'. #7182 (#7279)

2024-07-29 Thread zhouyao2023
This is an automated email from the ASF dual-hosted git repository. zhouyao2023 pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 4897491708 fix [Bug] Unable to create a source

Re: [PR] [Bug][Connector-v2][KafkaSource]Fix the abnormal exit of KafkaConsumerThread. [seatunnel]

2024-07-29 Thread via GitHub
lightzhao commented on PR #7273: URL: https://github.com/apache/seatunnel/pull/7273#issuecomment-2255459194 > In this case, users cannot use the SeaTunnel job status to determine whether the data reading is running normally. This is unacceptable OK, SeaTunnel expects that after the ka

Re: [PR] [Bug][Connector-v2][KafkaSource]Fix the abnormal exit of KafkaConsumerThread. [seatunnel]

2024-07-29 Thread via GitHub
Hisoka-X commented on PR #7273: URL: https://github.com/apache/seatunnel/pull/7273#issuecomment-2255518370 > > In this case, users cannot use the SeaTunnel job status to determine whether the data reading is running normally. This is unacceptable > > OK, SeaTunnel expects that after t

Re: [PR] [Bug][Connector-v2][KafkaSource]Fix the abnormal exit of KafkaConsumerThread. [seatunnel]

2024-07-29 Thread via GitHub
lightzhao commented on PR #7273: URL: https://github.com/apache/seatunnel/pull/7273#issuecomment-225442 > > > In this case, users cannot use the SeaTunnel job status to determine whether the data reading is running normally. This is unacceptable > > > > > > OK, SeaTunnel expec

Re: [PR] [Bug][Connector-v2][KafkaSource]Fix the abnormal exit of KafkaConsumerThread. [seatunnel]

2024-07-29 Thread via GitHub
corgy-w commented on PR #7273: URL: https://github.com/apache/seatunnel/pull/7273#issuecomment-2255566145 > > > > In this case, users cannot use the SeaTunnel job status to determine whether the data reading is running normally. This is unacceptable > > > > > > > > > OK, SeaTunnel

Re: [PR] [Bug][Connector-v2][KafkaSource]Fix the abnormal exit of KafkaConsumerThread. [seatunnel]

2024-07-29 Thread via GitHub
Hisoka-X commented on PR #7273: URL: https://github.com/apache/seatunnel/pull/7273#issuecomment-2255592078 > OK, but the current mechanism is that the consumer thread just exits, the job does not fail and continues to run. I think this is unreasonable. Yes, it's a bug. Could you help

Re: [I] [Feature][Qdrant] Support qdrant connector source/sink [seatunnel]

2024-07-29 Thread via GitHub
Anush008 commented on issue #7190: URL: https://github.com/apache/seatunnel/issues/7190#issuecomment-2255786959 Hey! I'll be trying to implement this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [Improve][Connector-v2] Optimize the way of databases and tables are checked for existence [seatunnel]

2024-07-29 Thread via GitHub
hailin0 merged PR #7261: URL: https://github.com/apache/seatunnel/pull/7261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunne

(seatunnel) branch dev updated: [Improve][Connector-v2] Optimize the way of databases and tables are checked for existence (#7261)

2024-07-29 Thread wanghailin
This is an automated email from the ASF dual-hosted git repository. wanghailin pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new f012b2a6f0 [Improve][Connector-v2] Optimize the

(seatunnel) branch dev updated: [Docs]translate event-listener doc into chinese (#7274)

2024-07-29 Thread wanghailin
This is an automated email from the ASF dual-hosted git repository. wanghailin pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new ec1c3198bc [Docs]translate event-listener doc i

Re: [PR] [Docs]translate event-listener doc into chinese [seatunnel]

2024-07-29 Thread via GitHub
hailin0 merged PR #7274: URL: https://github.com/apache/seatunnel/pull/7274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunne

Re: [PR] [Feature][Spark] Support multiple tables read and write [seatunnel]

2024-07-29 Thread via GitHub
hailin0 commented on code in PR #7283: URL: https://github.com/apache/seatunnel/pull/7283#discussion_r1695284719 ## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-1/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcMysqlMultipleTablesI

Re: [PR] [Feature] [Activemq] Added activemq sink [seatunnel]

2024-07-29 Thread via GitHub
hailin0 commented on code in PR #7251: URL: https://github.com/apache/seatunnel/pull/7251#discussion_r1695289671 ## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-activemq-e2e/src/test/java/org/apache/seatunnel/e2e/connector/activemq/ActivemqIT.java: ## @@ -0,0 +1,56 @@ +/*

[PR] [Feature][Transforms] Support cast to bytes function of sql [seatunnel]

2024-07-29 Thread via GitHub
hailin0 opened a new pull request, #7284: URL: https://github.com/apache/seatunnel/pull/7284 ### Purpose of this pull request ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ### Check list * [

Re: [I] [Feature][Prometheus] Support Prometheus connector source/sink [seatunnel]

2024-07-29 Thread via GitHub
hailin0 commented on issue #7201: URL: https://github.com/apache/seatunnel/issues/7201#issuecomment-2256122076 @CosmosNi I see remote_write, you need to compare https://prometheus.io/docs/specs/remote_write_spec/ -- This is an automated message from the Apache Git Service. To respond to

Re: [I] [Feature][Qdrant] Support qdrant connector source/sink [seatunnel]

2024-07-29 Thread via GitHub
hailin0 commented on issue #7190: URL: https://github.com/apache/seatunnel/issues/7190#issuecomment-2256147443 @Anush008 good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [I] [Feature][CDC] Support tidb cdc connector source [seatunnel]

2024-07-29 Thread via GitHub
hailin0 commented on issue #7199: URL: https://github.com/apache/seatunnel/issues/7199#issuecomment-2256149495 hi @sunxiaojian Is there any progress on this task? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] [Feature][clickhouse] Support multi-table source read [seatunnel]

2024-07-29 Thread via GitHub
hailin0 commented on issue #6230: URL: https://github.com/apache/seatunnel/issues/6230#issuecomment-2256151891 hi @zhilinli123 Is there any progress on this task? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] [Feature][Typesense] Support typesense connector source/sink [seatunnel]

2024-07-29 Thread via GitHub
hailin0 commented on issue #7191: URL: https://github.com/apache/seatunnel/issues/7191#issuecomment-2256152550 hi @zhangshenghang Is there any progress on this task? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] [Bug] [FTP Connector] The reading and writing of FTP are very slow [seatunnel]

2024-07-29 Thread via GitHub
github-actions[bot] commented on issue #7048: URL: https://github.com/apache/seatunnel/issues/7048#issuecomment-2257238494 This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future. -- This is a

Re: [I] [Bug] [FTP Connector] The reading and writing of FTP are very slow [seatunnel]

2024-07-29 Thread via GitHub
github-actions[bot] closed issue #7048: [Bug] [FTP Connector] The reading and writing of FTP are very slow URL: https://github.com/apache/seatunnel/issues/7048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [Feature][CDC] Support tidb cdc connector source [seatunnel]

2024-07-29 Thread via GitHub
dailai commented on issue #7199: URL: https://github.com/apache/seatunnel/issues/7199#issuecomment-2257284098 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [improve][Transform] DynamicCompile improve transform [seatunnel]

2024-07-29 Thread via GitHub
jacky commented on code in PR #7264: URL: https://github.com/apache/seatunnel/pull/7264#discussion_r1696151973 ## seatunnel-e2e/seatunnel-transforms-v2-e2e/seatunnel-transforms-v2-e2e-part-2/src/test/java/org/apache/seatunnel/e2e/transform/TestDynamicCompileIT.java: ## @

Re: [PR] [fix] [connector-tdengine] fix sql exception and concurrentmodifyexception when connect to taos and read data [seatunnel]

2024-07-29 Thread via GitHub
liugddx commented on code in PR #6088: URL: https://github.com/apache/seatunnel/pull/6088#discussion_r1696160438 ## seatunnel-connectors-v2/connector-tdengine/src/main/java/org/apache/seatunnel/connectors/seatunnel/tdengine/source/TDengineSourceReader.java: ## @@ -39,84 +35,76 @

Re: [PR] [Feature] [Activemq] Added activemq sink [seatunnel]

2024-07-29 Thread via GitHub
jacky commented on code in PR #7251: URL: https://github.com/apache/seatunnel/pull/7251#discussion_r1696171992 ## seatunnel-connectors-v2/connector-activemq/src/main/java/org/apache/seatunnel/connectors/seatunnel/activemq/exception/ActivemqConnectorErrorCode.java: ## @@

Re: [PR] [Feature] [Activemq] Added activemq sink [seatunnel]

2024-07-29 Thread via GitHub
jacky commented on code in PR #7251: URL: https://github.com/apache/seatunnel/pull/7251#discussion_r1696171992 ## seatunnel-connectors-v2/connector-activemq/src/main/java/org/apache/seatunnel/connectors/seatunnel/activemq/exception/ActivemqConnectorErrorCode.java: ## @@

Re: [PR] [Feature] [Activemq] Added activemq sink [seatunnel]

2024-07-29 Thread via GitHub
jacky commented on code in PR #7251: URL: https://github.com/apache/seatunnel/pull/7251#discussion_r1696171992 ## seatunnel-connectors-v2/connector-activemq/src/main/java/org/apache/seatunnel/connectors/seatunnel/activemq/exception/ActivemqConnectorErrorCode.java: ## @@

Re: [PR] [improve][Transform] DynamicCompile improve transform [seatunnel]

2024-07-29 Thread via GitHub
Hisoka-X commented on code in PR #7264: URL: https://github.com/apache/seatunnel/pull/7264#discussion_r1696179515 ## seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/dynamiccompile/parse/JavaClassLayer.java: ## @@ -21,24 +21,29 @@ import java.util.function

Re: [PR] [Bug][Connector-v2][KafkaSource]Fix the abnormal exit of KafkaConsumerThread. [seatunnel]

2024-07-29 Thread via GitHub
lightzhao commented on PR #7273: URL: https://github.com/apache/seatunnel/pull/7273#issuecomment-2257384869 > > OK, but the current mechanism is that the consumer thread just exits, the job does not fail and continues to run. I think this is unreasonable. > > Yes, it's a bug. Could yo

[PR] Update Oracle-CDC.md [seatunnel]

2024-07-29 Thread via GitHub
virvle opened a new pull request, #7285: URL: https://github.com/apache/seatunnel/pull/7285 Add privileges to resolve the issue: ORA-01031: insufficient privileges. ### Purpose of this pull request ### Does this PR introduce _any_ user-facing change?

Re: [PR] Update Oracle-CDC.md [seatunnel]

2024-07-29 Thread via GitHub
virvle commented on PR #7285: URL: https://github.com/apache/seatunnel/pull/7285#issuecomment-2257517830 ### Error Exception ``` === Exception in thread "main" org.apache.seatunnel.core.star

Re: [PR] Update Oracle-CDC.md [seatunnel]

2024-07-29 Thread via GitHub
virvle commented on PR #7285: URL: https://github.com/apache/seatunnel/pull/7285#issuecomment-2257519665 Reference link : https://www.modb.pro/db/1817798526220460032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [improve][Transform] DynamicCompile improve transform [seatunnel]

2024-07-29 Thread via GitHub
jacky commented on code in PR #7264: URL: https://github.com/apache/seatunnel/pull/7264#discussion_r1696363507 ## seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/dynamiccompile/parse/JavaClassLayer.java: ## @@ -21,24 +21,29 @@ import java.util.fun

Re: [I] [Bug] [seatunnel-connectors-v2] when I use connector-cdc-mysql to read mysql-bin data,a ClassCastException error is reported [seatunnel]

2024-07-29 Thread via GitHub
gmlworld commented on issue #3929: URL: https://github.com/apache/seatunnel/issues/3929#issuecomment-2257570704 按网上的教程部署中,有一步操作是将 connnect下的jar包拷贝到lib目录下,使用sh脚本启动的时候加载了两份相同的jar,导致了对象冲突。删除lib中拷贝过去的connect-*.jar 就没问题了。 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [Feature] [Activemq] Added activemq sink [seatunnel]

2024-07-29 Thread via GitHub
Hisoka-X commented on code in PR #7251: URL: https://github.com/apache/seatunnel/pull/7251#discussion_r1696392342 ## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-activemq-e2e/src/test/resources/e2e.json: ## Review Comment: This file has more than 8,000 lines. Is it po

Re: [PR] Update Oracle-CDC.md [seatunnel]

2024-07-29 Thread via GitHub
virvle commented on PR #7285: URL: https://github.com/apache/seatunnel/pull/7285#issuecomment-2257587635 Update Oracle-CDC.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Feature] [Activemq] Added activemq sink [seatunnel]

2024-07-29 Thread via GitHub
asapekia commented on code in PR #7251: URL: https://github.com/apache/seatunnel/pull/7251#discussion_r1696400062 ## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-activemq-e2e/src/test/resources/e2e.json: ## Review Comment: 8k was the avg number of messages we used to

Re: [PR] [Feature] [Activemq] Added activemq sink [seatunnel]

2024-07-29 Thread via GitHub
Hisoka-X commented on code in PR #7251: URL: https://github.com/apache/seatunnel/pull/7251#discussion_r1696408909 ## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-activemq-e2e/src/test/resources/e2e.json: ## Review Comment: Yes please. We just need to make sure there i