[GitHub] [seatunnel] TaoZex commented on a diff in pull request #5101: [Doc] Improve S3File Source & S3File Sink document

2023-07-19 Thread via GitHub
TaoZex commented on code in PR #5101: URL: https://github.com/apache/seatunnel/pull/5101#discussion_r1267630568 ## docs/en/connector-v2/sink/S3File.md: ## @@ -30,60 +23,106 @@ By default, we use 2PC commit to ensure `exactly-once` - [x] json - [x] excel -## Options - -|

[GitHub] [seatunnel] hailin0 commented on pull request #5044: [Feature] make data block balance before importing data #5026

2023-07-19 Thread via GitHub
hailin0 commented on PR #5044: URL: https://github.com/apache/seatunnel/pull/5044#issuecomment-1641548600 https://github.com/apache/seatunnel/assets/14371345/157564f2-c7bb-4b30-8ab2-bc6af1c145c5";> -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [seatunnel] TyrantLucifer commented on pull request #5044: [Feature] make data block balance before importing data #5026

2023-07-19 Thread via GitHub
TyrantLucifer commented on PR #5044: URL: https://github.com/apache/seatunnel/pull/5044#issuecomment-1641563886 > I checked the logs, the CI error is caused by related modules of seatunnel-connecotr-e2e and seatunnel-transforms-v2-e2e, it should have nothing to do with this PR Your c

[GitHub] [seatunnel] MonsterChenzhuo commented on pull request #5085: [Improve][Docs][Clickhouse] Reconstruct the clickhouse connec…

2023-07-19 Thread via GitHub
MonsterChenzhuo commented on PR #5085: URL: https://github.com/apache/seatunnel/pull/5085#issuecomment-1641576907 @EricJoy2048 PTAL,thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [seatunnel] MonsterChenzhuo commented on pull request #5085: [Improve][Docs][Clickhouse] Reconstruct the clickhouse connec…

2023-07-19 Thread via GitHub
MonsterChenzhuo commented on PR #5085: URL: https://github.com/apache/seatunnel/pull/5085#issuecomment-1641666372 @hailin0 PTAL,thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [seatunnel] Hisoka-X commented on pull request #5114: [Feature][Zeta] Support history service record job execute error

2023-07-19 Thread via GitHub
Hisoka-X commented on PR #5114: URL: https://github.com/apache/seatunnel/pull/5114#issuecomment-1641674869 Can you add some test case for this? Thanks. eg: submit a error job the use client method query error msg. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [seatunnel] Hisoka-X commented on a diff in pull request #5085: [Improve][Docs][Clickhouse] Reconstruct the clickhouse connec…

2023-07-19 Thread via GitHub
Hisoka-X commented on code in PR #5085: URL: https://github.com/apache/seatunnel/pull/5085#discussion_r1267762022 ## docs/en/connector-v2/source/Clickhouse.md: ## @@ -2,93 +2,96 @@ > Clickhouse source connector -## Description +## Support Those Engines -Used to read data

[GitHub] [seatunnel] liunaijie commented on pull request #5083: [Feature] support compress on Text File Read

2023-07-19 Thread via GitHub
liunaijie commented on PR #5083: URL: https://github.com/apache/seatunnel/pull/5083#issuecomment-1641713347 > LGTM But the doc needs to be modified. doc updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [seatunnel] MonsterChenzhuo commented on a diff in pull request #5085: [Improve][Docs][Clickhouse] Reconstruct the clickhouse connec…

2023-07-19 Thread via GitHub
MonsterChenzhuo commented on code in PR #5085: URL: https://github.com/apache/seatunnel/pull/5085#discussion_r1267801088 ## docs/en/connector-v2/source/Clickhouse.md: ## @@ -2,93 +2,96 @@ > Clickhouse source connector -## Description +## Support Those Engines -Used to rea

[GitHub] [seatunnel] MonsterChenzhuo commented on a diff in pull request #5085: [Improve][Docs][Clickhouse] Reconstruct the clickhouse connec…

2023-07-19 Thread via GitHub
MonsterChenzhuo commented on code in PR #5085: URL: https://github.com/apache/seatunnel/pull/5085#discussion_r1267801088 ## docs/en/connector-v2/source/Clickhouse.md: ## @@ -2,93 +2,96 @@ > Clickhouse source connector -## Description +## Support Those Engines -Used to rea

[GitHub] [seatunnel] MonsterChenzhuo commented on a diff in pull request #5085: [Improve][Docs][Clickhouse] Reconstruct the clickhouse connec…

2023-07-19 Thread via GitHub
MonsterChenzhuo commented on code in PR #5085: URL: https://github.com/apache/seatunnel/pull/5085#discussion_r1267801088 ## docs/en/connector-v2/source/Clickhouse.md: ## @@ -2,93 +2,96 @@ > Clickhouse source connector -## Description +## Support Those Engines -Used to rea

[GitHub] [seatunnel] MonsterChenzhuo commented on a diff in pull request #5085: [Improve][Docs][Clickhouse] Reconstruct the clickhouse connec…

2023-07-19 Thread via GitHub
MonsterChenzhuo commented on code in PR #5085: URL: https://github.com/apache/seatunnel/pull/5085#discussion_r1267805819 ## docs/en/connector-v2/source/Clickhouse.md: ## @@ -2,93 +2,96 @@ > Clickhouse source connector -## Description +## Support Those Engines -Used to rea

[GitHub] [seatunnel] MonsterChenzhuo commented on a diff in pull request #5085: [Improve][Docs][Clickhouse] Reconstruct the clickhouse connec…

2023-07-19 Thread via GitHub
MonsterChenzhuo commented on code in PR #5085: URL: https://github.com/apache/seatunnel/pull/5085#discussion_r1267801088 ## docs/en/connector-v2/source/Clickhouse.md: ## @@ -2,93 +2,96 @@ > Clickhouse source connector -## Description +## Support Those Engines -Used to rea

[GitHub] [seatunnel] wu-a-ge commented on pull request #5114: [Feature][Zeta] Support history service record job execute error

2023-07-19 Thread via GitHub
wu-a-ge commented on PR #5114: URL: https://github.com/apache/seatunnel/pull/5114#issuecomment-1641739122 > Can you add some test case for this? Thanks. eg: submit a error job the use client method query error msg. OK! I will try -- This is an automated message from the Apache Git

[GitHub] [seatunnel] Hisoka-X merged pull request #5085: [Improve][Docs][Clickhouse] Reconstruct the clickhouse connec…

2023-07-19 Thread via GitHub
Hisoka-X merged PR #5085: URL: https://github.com/apache/seatunnel/pull/5085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunn

[seatunnel] branch dev updated: [Improve][Docs][Clickhouse] Reconstruct the clickhouse connector doc (#5085)

2023-07-19 Thread fanjia
This is an automated email from the ASF dual-hosted git repository. fanjia pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 70ec3a360 [Improve][Docs][Clickhouse] Reconstruct t

[GitHub] [seatunnel] Hisoka-X opened a new pull request, #5117: [Improve][Zeta] Add sleep for SinkAggregatedCommitterTask

2023-07-19 Thread via GitHub
Hisoka-X opened a new pull request, #5117: URL: https://github.com/apache/seatunnel/pull/5117 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar binary package ad

[GitHub] [seatunnel] lightzhao commented on a diff in pull request #4975: [Feature][Connector-v2][RedisSink]Support redis to set expiration time.

2023-07-19 Thread via GitHub
lightzhao commented on code in PR #4975: URL: https://github.com/apache/seatunnel/pull/4975#discussion_r1267896639 ## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-redis-e2e/src/test/java/org/apache/seatunnel/e2e/connector/redis/RedisIT.java: ## @@ -192,4 +192,15 @@ public

[GitHub] [seatunnel] lightzhao commented on pull request #4382: [Feature][Connector-v2][PulsarSink]Add Pulsar Sink Connector.

2023-07-19 Thread via GitHub
lightzhao commented on PR #4382: URL: https://github.com/apache/seatunnel/pull/4382#issuecomment-1641853037 @TyrantLucifer @hailin0 @EricJoy2048 @Hisoka-X PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [seatunnel] liugddx commented on pull request #4975: [Feature][Connector-v2][RedisSink]Support redis to set expiration time.

2023-07-19 Thread via GitHub
liugddx commented on PR #4975: URL: https://github.com/apache/seatunnel/pull/4975#issuecomment-1641859069 Wait for ci to complete -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [seatunnel-web] dependabot[bot] opened a new pull request, #82: Bump mysql-connector-java from 8.0.16 to 8.0.28 in /seatunnel-datasource/seatunnel-datasource-plugins/datasource-mysql-cdc

2023-07-19 Thread via GitHub
dependabot[bot] opened a new pull request, #82: URL: https://github.com/apache/seatunnel-web/pull/82 Bumps [mysql-connector-java](https://github.com/mysql/mysql-connector-j) from 8.0.16 to 8.0.28. Changelog Sourced from https://github.com/mysql/mysql-connector-j/blob/release/8.x/CH

[seatunnel-web] branch dependabot/maven/seatunnel-datasource/seatunnel-datasource-plugins/datasource-mysql-cdc/mysql-mysql-connector-java-8.0.28 created (now eb38507d)

2023-07-19 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/seatunnel-datasource/seatunnel-datasource-plugins/datasource-mysql-cdc/mysql-mysql-connector-java-8.0.28 in repository https://gitbox.apache.org/repos/asf/seatunnel-web.git

[GitHub] [seatunnel-web] dependabot[bot] opened a new pull request, #83: Bump clickhouse-jdbc from 0.3.2-patch11 to 0.4.6 in /seatunnel-datasource/seatunnel-datasource-plugins/datasource-jdbc-clickhou

2023-07-19 Thread via GitHub
dependabot[bot] opened a new pull request, #83: URL: https://github.com/apache/seatunnel-web/pull/83 Bumps [clickhouse-jdbc](https://github.com/ClickHouse/clickhouse-java) from 0.3.2-patch11 to 0.4.6. Release notes Sourced from https://github.com/ClickHouse/clickhouse-java/releases

[GitHub] [seatunnel-web] dependabot[bot] opened a new pull request, #84: Bump gson from 2.8.6 to 2.8.9

2023-07-19 Thread via GitHub
dependabot[bot] opened a new pull request, #84: URL: https://github.com/apache/seatunnel-web/pull/84 Bumps [gson](https://github.com/google/gson) from 2.8.6 to 2.8.9. Release notes Sourced from https://github.com/google/gson/releases";>gson's releases. Gson 2.8.9 Make

[seatunnel-web] branch dependabot/maven/seatunnel-datasource/seatunnel-datasource-plugins/datasource-jdbc-clickhouse/com.clickhouse-clickhouse-jdbc-0.4.6 created (now 004d0b67)

2023-07-19 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/seatunnel-datasource/seatunnel-datasource-plugins/datasource-jdbc-clickhouse/com.clickhouse-clickhouse-jdbc-0.4.6 in repository https://gitbox.apache.org/repos/asf/seatunnel-w

[seatunnel-web] branch dependabot/maven/com.google.code.gson-gson-2.8.9 created (now 1c9d5847)

2023-07-19 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.google.code.gson-gson-2.8.9 in repository https://gitbox.apache.org/repos/asf/seatunnel-web.git at 1c9d5847 Bump gson from 2.8.6 to 2.8.9 No new revisions were ad

[GitHub] [seatunnel-web] dependabot[bot] opened a new pull request, #85: Bump jsoup from 1.14.3 to 1.15.3

2023-07-19 Thread via GitHub
dependabot[bot] opened a new pull request, #85: URL: https://github.com/apache/seatunnel-web/pull/85 Bumps [jsoup](https://github.com/jhy/jsoup) from 1.14.3 to 1.15.3. Release notes Sourced from https://github.com/jhy/jsoup/releases";>jsoup's releases. jsoup 1.15.3 jsoup

[seatunnel-web] branch dependabot/maven/org.jsoup-jsoup-1.15.3 created (now abfbfcc0)

2023-07-19 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.jsoup-jsoup-1.15.3 in repository https://gitbox.apache.org/repos/asf/seatunnel-web.git at abfbfcc0 Bump jsoup from 1.14.3 to 1.15.3 No new revisions were added by

[GitHub] [seatunnel-web] dependabot[bot] opened a new pull request, #86: Bump mysql-connector-java from 8.0.16 to 8.0.28 in /seatunnel-datasource/seatunnel-datasource-plugins/datasource-starrocks

2023-07-19 Thread via GitHub
dependabot[bot] opened a new pull request, #86: URL: https://github.com/apache/seatunnel-web/pull/86 Bumps [mysql-connector-java](https://github.com/mysql/mysql-connector-j) from 8.0.16 to 8.0.28. Changelog Sourced from https://github.com/mysql/mysql-connector-j/blob/release/8.x/CH

[seatunnel-web] branch dependabot/maven/seatunnel-datasource/seatunnel-datasource-plugins/datasource-starrocks/mysql-mysql-connector-java-8.0.28 created (now 6ae8d195)

2023-07-19 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/seatunnel-datasource/seatunnel-datasource-plugins/datasource-starrocks/mysql-mysql-connector-java-8.0.28 in repository https://gitbox.apache.org/repos/asf/seatunnel-web.git

[GitHub] [seatunnel] liugddx commented on pull request #5107: [Feature][Zeta][REST-API]Add REST API To Submit Job

2023-07-19 Thread via GitHub
liugddx commented on PR #5107: URL: https://github.com/apache/seatunnel/pull/5107#issuecomment-1641864513 Test failed, please deal with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[seatunnel] branch dev updated: [Pom]update version to 2.3.3-SNAPSHOT (#5043)

2023-07-19 Thread liugddx
This is an automated email from the ASF dual-hosted git repository. liugddx pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 2e92c987e [Pom]update version to 2.3.3-SNAPSHOT (#

[GitHub] [seatunnel] liugddx merged pull request #5043: [Pom]update version to 2.3.3-SNAPSHOT

2023-07-19 Thread via GitHub
liugddx merged PR #5043: URL: https://github.com/apache/seatunnel/pull/5043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunne

[GitHub] [seatunnel] liugddx commented on a diff in pull request #5097: [Improve][Connector-v2][Jdbc] check url not null throw friendly message

2023-07-19 Thread via GitHub
liugddx commented on code in PR #5097: URL: https://github.com/apache/seatunnel/pull/5097#discussion_r1267912054 ## seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/JdbcDialectLoader.java: ## @@ -46,6 +48,8 @@ p

[GitHub] [seatunnel] liugddx commented on pull request #5096: [Improve][Connector-v2][Jdbc] Refactor AbstractJdbcCatalog

2023-07-19 Thread via GitHub
liugddx commented on PR #5096: URL: https://github.com/apache/seatunnel/pull/5096#issuecomment-1641877022 > Mockito Refer to `seatunnel-e2e/connector-jdbc-e2e` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [seatunnel] liugddx commented on pull request #5072: [Feature][connector-v2][Iceberg] sink plugin

2023-07-19 Thread via GitHub
liugddx commented on PR #5072: URL: https://github.com/apache/seatunnel/pull/5072#issuecomment-1641881311 > @liugddx PTAL Fix CI error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [seatunnel] lightzhao opened a new pull request, #5118: [Bug][Improve][LocalFileSink]Fix LocalFile Sink file_format_type.

2023-07-19 Thread via GitHub
lightzhao opened a new pull request, #5118: URL: https://github.com/apache/seatunnel/pull/5118 ## Purpose of this pull request #5116 ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar binary pack

[GitHub] [seatunnel] whhe commented on pull request #5096: [Improve][Connector-v2][Jdbc] Refactor AbstractJdbcCatalog

2023-07-19 Thread via GitHub
whhe commented on PR #5096: URL: https://github.com/apache/seatunnel/pull/5096#issuecomment-1641895425 > > Mockito > > Refer to `seatunnel-e2e/connector-jdbc-e2e` So I should add IT cases in module connector-jdbc-e2e instead of UT cases in the modified module, am I right? --

[GitHub] [seatunnel] wulinzhai opened a new issue, #5119: 数据无法同步到s3上

2023-07-19 Thread via GitHub
wulinzhai opened a new issue, #5119: URL: https://github.com/apache/seatunnel/issues/5119 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/seatunnel/issues?q=is%3Aissue+label%3A%22bug%22) and found no similar issues. ### What happened

[GitHub] [seatunnel] zhibinF commented on pull request #5107: [Feature][Zeta][REST-API]Add REST API To Submit Job

2023-07-19 Thread via GitHub
zhibinF commented on PR #5107: URL: https://github.com/apache/seatunnel/pull/5107#issuecomment-1641964308 > Test failed, please deal with it. ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [seatunnel] Lifu12 commented on issue #5110: [Bug] [mysql-cdc] mysqlcdc同步至postgresql9.5以下版本upsert语法不支持

2023-07-19 Thread via GitHub
Lifu12 commented on issue #5110: URL: https://github.com/apache/seatunnel/issues/5110#issuecomment-1642262020 please view compatibleMode parameter usage ![image](https://github.com/apache/seatunnel/assets/66303359/8756ae0b-fab5-41fe-9d73-69987faafa9f) ![image](https://github.com/apac

[GitHub] [seatunnel] Hisoka-X commented on pull request #5105: [Bugfix][Connector-V2][mysql cdc] Conversion of tinyint(1) to boolean is supported

2023-07-19 Thread via GitHub
Hisoka-X commented on PR #5105: URL: https://github.com/apache/seatunnel/pull/5105#issuecomment-1642271906 Does MySQL will create boolean as tinyint? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [seatunnel] Lifu12 commented on issue #5110: [Bug] [mysql-cdc] mysqlcdc同步至postgresql9.5以下版本upsert语法不支持

2023-07-19 Thread via GitHub
Lifu12 commented on issue #5110: URL: https://github.com/apache/seatunnel/issues/5110#issuecomment-1642272556 please view compatibleMode parameter usage and rewrite PostgresDialectFactory.create() method support it ![image](https://github.com/apache/seatunnel/assets/66303359/0d68411

[GitHub] [seatunnel] silenceland commented on issue #3018: [Umbrella][Connector-V2] SeaTunnel Connector V2 Tracking Table

2023-07-19 Thread via GitHub
silenceland commented on issue #3018: URL: https://github.com/apache/seatunnel/issues/3018#issuecomment-1642504251 hi, I can work for DolphinDB source & sink, please assign to me, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [seatunnel] github-actions[bot] commented on issue #4944: [Bug] [E2E] mysql-cdc e2e error

2023-07-19 Thread via GitHub
github-actions[bot] commented on issue #4944: URL: https://github.com/apache/seatunnel/issues/4944#issuecomment-1642932740 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

[GitHub] [seatunnel] github-actions[bot] commented on issue #4934: [Feature][Connector] Databricks Lakehouse Sink Support

2023-07-19 Thread via GitHub
github-actions[bot] commented on issue #4934: URL: https://github.com/apache/seatunnel/issues/4934#issuecomment-1642932791 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

[GitHub] [seatunnel] github-actions[bot] commented on issue #4948: MySQL-CDC SparkTaskExecuteCommand: Run SeaTunnel on spark failed.

2023-07-19 Thread via GitHub
github-actions[bot] commented on issue #4948: URL: https://github.com/apache/seatunnel/issues/4948#issuecomment-1642932693 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

[GitHub] [seatunnel] github-actions[bot] commented on issue #4909: [Bug] [hazelcast] During the execution of hazelcast, an error has been reported when operating the keyboard Ctrl+c, please handle it

2023-07-19 Thread via GitHub
github-actions[bot] commented on issue #4909: URL: https://github.com/apache/seatunnel/issues/4909#issuecomment-1642932884 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

[GitHub] [seatunnel] wu-a-ge commented on a diff in pull request #5114: [Feature][Zeta] Support history service record job execute error

2023-07-19 Thread via GitHub
wu-a-ge commented on code in PR #5114: URL: https://github.com/apache/seatunnel/pull/5114#discussion_r1268826767 ## seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/CoordinatorService.java: ## @@ -495,10 +495,11 @@ public PassiveCompletab

[GitHub] [seatunnel-website] scorpig closed pull request #254: Fix InfluxDB.md Examples code

2023-07-19 Thread via GitHub
scorpig closed pull request #254: Fix InfluxDB.md Examples code URL: https://github.com/apache/seatunnel-website/pull/254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [seatunnel] hailin0 commented on a diff in pull request #4917: [Feature][Catalog] Add JDBC Catalog auto create table

2023-07-19 Thread via GitHub
hailin0 commented on code in PR #4917: URL: https://github.com/apache/seatunnel/pull/4917#discussion_r1268863104 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/Column.java: ## @@ -1,13 +1,12 @@ /* - * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [seatunnel] jackyyyyyssss commented on a diff in pull request #5097: [Improve][Connector-v2][Jdbc] check url not null throw friendly message

2023-07-19 Thread via GitHub
jacky commented on code in PR #5097: URL: https://github.com/apache/seatunnel/pull/5097#discussion_r1268868352 ## seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/JdbcDialectLoader.java: ## @@ -46,6 +48,

[GitHub] [seatunnel] XiaoJiang521 commented on a diff in pull request #4917: [Feature][Catalog] Add JDBC Catalog auto create table

2023-07-19 Thread via GitHub
XiaoJiang521 commented on code in PR #4917: URL: https://github.com/apache/seatunnel/pull/4917#discussion_r1268874341 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/Column.java: ## @@ -1,13 +1,12 @@ /* - * Licensed to the Apache Software Foundation (ASF)

[GitHub] [seatunnel] davidzollo commented on issue #4686: Parameter transfer error -i

2023-07-19 Thread via GitHub
davidzollo commented on issue #4686: URL: https://github.com/apache/seatunnel/issues/4686#issuecomment-1643040137 not support replace the variables in the conf file for now, the command -i is used to directly pass the param value to Spark or Flink engine, it seems like {FLINK_HOME}/bin/fli

[GitHub] [seatunnel] hailin0 commented on pull request #4885: [Feature][Connector-V2] Introduce milvus connector

2023-07-19 Thread via GitHub
hailin0 commented on PR #4885: URL: https://github.com/apache/seatunnel/pull/4885#issuecomment-1643052171 good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [seatunnel] hailin0 commented on a diff in pull request #4885: [Feature][Connector-V2] Introduce milvus connector

2023-07-19 Thread via GitHub
hailin0 commented on code in PR #4885: URL: https://github.com/apache/seatunnel/pull/4885#discussion_r1268892333 ## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-milvus-v2-e2e/src/test/resources/fake_to_milvus.conf: ## @@ -0,0 +1,81 @@ +# +# Licensed to the Apache Software

[GitHub] [seatunnel] Carl-Zhou-CN commented on pull request #5105: [Bugfix][Connector-V2][mysql cdc] Conversion of tinyint(1) to boolean is supported

2023-07-19 Thread via GitHub
Carl-Zhou-CN commented on PR #5105: URL: https://github.com/apache/seatunnel/pull/5105#issuecomment-1643182332 > Does MySQL will create boolean as tinyint? ![image](https://github.com/apache/seatunnel/assets/67902676/12bca275-c73d-4566-9225-55cc65ec517c) yes,it is possible to perfo

[GitHub] [seatunnel] Carl-Zhou-CN commented on pull request #5105: [Bugfix][Connector-V2][mysql cdc] Conversion of tinyint(1) to boolean is supported

2023-07-19 Thread via GitHub
Carl-Zhou-CN commented on PR #5105: URL: https://github.com/apache/seatunnel/pull/5105#issuecomment-1643184355 > Does MySQL will create boolean as tinyint? ![image](https://github.com/apache/seatunnel/assets/67902676/81fc38d3-1235-42b3-8267-285c61f47190) yes,It is possi

[GitHub] [seatunnel] Hisoka-X merged pull request #5105: [Bugfix][Connector-V2][mysql cdc] Conversion of tinyint(1) to boolean is supported

2023-07-19 Thread via GitHub
Hisoka-X merged PR #5105: URL: https://github.com/apache/seatunnel/pull/5105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunn

[GitHub] [seatunnel] Hisoka-X closed issue #5095: [Bug] [mysql cdc] where binlog create table tinyint(1) default false then error

2023-07-19 Thread via GitHub
Hisoka-X closed issue #5095: [Bug] [mysql cdc] where binlog create table tinyint(1) default false then error URL: https://github.com/apache/seatunnel/issues/5095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[seatunnel] branch dev updated: [Feature][Connector-V2][mysql cdc] Conversion of tinyint(1) to bool is supported (#5105)

2023-07-19 Thread fanjia
This is an automated email from the ASF dual-hosted git repository. fanjia pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 86b1b7e31 [Feature][Connector-V2][mysql cdc] Conver

[GitHub] [seatunnel] Lifu12 opened a new pull request, #5120: [Bug] [connector-v2] PostgreSQL versions below 9.5 are compatible wit…

2023-07-19 Thread via GitHub
Lifu12 opened a new pull request, #5120: URL: https://github.com/apache/seatunnel/pull/5120 https://github.com/apache/seatunnel/issues/5110 …h CDC ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not ne

[GitHub] [seatunnel] liugddx commented on a diff in pull request #4885: [Feature][Connector-V2] Introduce milvus connector

2023-07-19 Thread via GitHub
liugddx commented on code in PR #4885: URL: https://github.com/apache/seatunnel/pull/4885#discussion_r1268959399 ## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-milvus-v2-e2e/src/test/resources/fake_to_milvus.conf: ## @@ -0,0 +1,81 @@ +# +# Licensed to the Apache Software

[GitHub] [seatunnel] TaoZex commented on pull request #5120: [Bug] [connector-v2] PostgreSQL versions below 9.5 are compatible wit…

2023-07-19 Thread via GitHub
TaoZex commented on PR #5120: URL: https://github.com/apache/seatunnel/pull/5120#issuecomment-1643318213 Thanks for your contribution. It would be better if you changed the title of this pr. Is there any mention of this in the PostgreSQL documentation? -- This is an automated message from

[GitHub] [seatunnel] liugddx commented on pull request #4975: [Feature][Connector-v2][RedisSink]Support redis to set expiration time.

2023-07-19 Thread via GitHub
liugddx commented on PR #4975: URL: https://github.com/apache/seatunnel/pull/4975#issuecomment-1643354192 @TyrantLucifer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To