Re: [PR] [improve] update clickhouse connector config option [seatunnel]

2025-02-19 Thread via GitHub
Hisoka-X merged PR #8755: URL: https://github.com/apache/seatunnel/pull/8755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunn

Re: [PR] [improve] update clickhouse connector config option [seatunnel]

2025-02-19 Thread via GitHub
liunaijie commented on PR #8755: URL: https://github.com/apache/seatunnel/pull/8755#issuecomment-2670125176 LGTM, Thanks! @lyne7-sc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [improve] update clickhouse connector config option [seatunnel]

2025-02-19 Thread via GitHub
lyne7-sc commented on PR #8755: URL: https://github.com/apache/seatunnel/pull/8755#issuecomment-2668837296 Hi , @liunaijie I noticed that the CI license header check failed in the previous PR. To address this, I've added a new commit to include the missing license headers for the follow

[PR] [improve] update clickhouse connector config option [seatunnel]

2025-02-17 Thread via GitHub
lyne7-sc opened a new pull request, #8755: URL: https://github.com/apache/seatunnel/pull/8755 ### Purpose of this pull request subtask of https://github.com/apache/seatunnel/issues/8576 ### Does this PR introduce _any_ user-facing change? ### How w

Re: [PR] [improve] update clickhouse connector config option [seatunnel]

2025-02-17 Thread via GitHub
lyne7-sc closed pull request #8747: [improve] update clickhouse connector config option URL: https://github.com/apache/seatunnel/pull/8747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [improve] update clickhouse connector config option [seatunnel]

2025-02-16 Thread via GitHub
liunaijie commented on code in PR #8747: URL: https://github.com/apache/seatunnel/pull/8747#discussion_r1957467592 ## seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/file/ClickhouseFileSinkFactory.java: ## @@ -

[PR] [improve] update clickhouse connector config option [seatunnel]

2025-02-16 Thread via GitHub
lyne7-sc opened a new pull request, #8747: URL: https://github.com/apache/seatunnel/pull/8747 ### Purpose of this pull request subtask of #8576 ### Does this PR introduce _any_ user-facing change? ### How was this patch tested?