Re: [PR] [improve] RabbitMq connector options [seatunnel]

2025-02-20 Thread via GitHub
liunaijie closed pull request #8699: [improve] RabbitMq connector options URL: https://github.com/apache/seatunnel/pull/8699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [improve] RabbitMq connector options [seatunnel]

2025-02-20 Thread via GitHub
liunaijie commented on PR #8699: URL: https://github.com/apache/seatunnel/pull/8699#issuecomment-2673157897 Hi @akulabs8, I will close this PR since the changes have already been merged in [PR #8740](https://github.com/apache/seatunnel/pull/8740). Feel free to contribute with another PR!

Re: [PR] [improve] RabbitMq connector options [seatunnel]

2025-02-16 Thread via GitHub
liunaijie commented on code in PR #8699: URL: https://github.com/apache/seatunnel/pull/8699#discussion_r1957305586 ## seatunnel-connectors-v2/connector-rabbitmq/src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/config/RabbitmqBaseOptions.java: ## @@ -22,21 +22,19

Re: [PR] [improve] RabbitMq connector options [seatunnel]

2025-02-16 Thread via GitHub
akulabs8 commented on code in PR #8699: URL: https://github.com/apache/seatunnel/pull/8699#discussion_r1957299778 ## seatunnel-connectors-v2/connector-rabbitmq/src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/config/RabbitmqBaseOptions.java: ## @@ -22,21 +22,19 @

Re: [PR] [improve] RabbitMq connector options [seatunnel]

2025-02-15 Thread via GitHub
liunaijie commented on code in PR #8699: URL: https://github.com/apache/seatunnel/pull/8699#discussion_r1957225337 ## seatunnel-connectors-v2/connector-rabbitmq/src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/config/RabbitmqBaseOptions.java: ## @@ -22,21 +22,19

Re: [PR] [improve] RabbitMq connector options [seatunnel]

2025-02-15 Thread via GitHub
akulabs8 commented on code in PR #8699: URL: https://github.com/apache/seatunnel/pull/8699#discussion_r1957164386 ## seatunnel-connectors-v2/connector-rabbitmq/src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/config/RabbitmqBaseOptions.java: ## @@ -22,21 +22,19 @

Re: [PR] [improve] RabbitMq connector options [seatunnel]

2025-02-15 Thread via GitHub
liunaijie commented on code in PR #8699: URL: https://github.com/apache/seatunnel/pull/8699#discussion_r1957098837 ## seatunnel-connectors-v2/connector-rabbitmq/src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/config/RabbitmqBaseOptions.java: ## @@ -22,21 +22,19

Re: [PR] [improve] RabbitMq connector options [seatunnel]

2025-02-14 Thread via GitHub
akulabs8 commented on PR #8699: URL: https://github.com/apache/seatunnel/pull/8699#issuecomment-2659965311 @liunaijie updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [improve] RabbitMq connector options [seatunnel]

2025-02-13 Thread via GitHub
liunaijie commented on code in PR #8699: URL: https://github.com/apache/seatunnel/pull/8699#discussion_r1955434129 ## seatunnel-connectors-v2/connector-rabbitmq/src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/config/RabbitmqBaseOptions.java: ## @@ -0,0 +1,185 @@

[PR] [improve] RabbitMq connector options [seatunnel]

2025-02-13 Thread via GitHub
akulabs8 opened a new pull request, #8699: URL: https://github.com/apache/seatunnel/pull/8699 ### Purpose of this pull request subtask of https://github.com/apache/seatunnel/issues/8576 ### Does this PR introduce _any_ user-facing change? ### H

Re: [PR] [improve] RabbitMq connector options [seatunnel]

2025-02-11 Thread via GitHub
liunaijie commented on code in PR #8633: URL: https://github.com/apache/seatunnel/pull/8633#discussion_r1951829682 ## seatunnel-connectors-v2/connector-rabbitmq/src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/config/RabbitmqOptions.java: ## @@ -36,7 +36,7 @@ @S

Re: [PR] [improve] RabbitMq connector options [seatunnel]

2025-02-11 Thread via GitHub
akulabs8 commented on code in PR #8633: URL: https://github.com/apache/seatunnel/pull/8633#discussion_r1951290740 ## seatunnel-connectors-v2/connector-rabbitmq/src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/config/RabbitmqOptions.java: ## @@ -36,7 +36,7 @@ @Se

Re: [PR] [improve] RabbitMq connector options [seatunnel]

2025-02-09 Thread via GitHub
liunaijie commented on code in PR #8633: URL: https://github.com/apache/seatunnel/pull/8633#discussion_r1948303509 ## seatunnel-connectors-v2/connector-rabbitmq/src/main/java/org/apache/seatunnel/connectors/seatunnel/rabbitmq/config/RabbitmqOptions.java: ## @@ -36,7 +36,7 @@ @S

[PR] [improve] RabbitMq connector options [seatunnel]

2025-02-09 Thread via GitHub
akulabs8 opened a new pull request, #8633: URL: https://github.com/apache/seatunnel/pull/8633 ### Purpose of this pull request subtask of https://github.com/apache/seatunnel/issues/8576 ### Check list * [ ] If any new Jar binary package adding in your PR, plea