Re: [PR] [feature][core] Unified engine initialization connector logic [seatunnel]

2025-01-21 Thread via GitHub
hailin0 commented on PR #8536: URL: https://github.com/apache/seatunnel/pull/8536#issuecomment-2606486051 waiting for ci passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [feature][core] Unified engine initialization connector logic [seatunnel]

2025-01-20 Thread via GitHub
liugddx commented on code in PR #8536: URL: https://github.com/apache/seatunnel/pull/8536#discussion_r1922045982 ## seatunnel-plugin-discovery/src/main/java/org/apache/seatunnel/plugin/discovery/AbstractPluginDiscovery.java: ## @@ -75,12 +76,24 @@ public abstract class AbstractP

Re: [PR] [feature][core] Unified engine initialization connector logic [seatunnel]

2025-01-20 Thread via GitHub
liugddx commented on code in PR #8536: URL: https://github.com/apache/seatunnel/pull/8536#discussion_r1922045663 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/factory/FactoryUtil.java: ## @@ -351,4 +401,29 @@ public static SeaTunnelTransform createAndPrepareMult

Re: [PR] [feature][core] Unified engine initialization connector logic [seatunnel]

2025-01-20 Thread via GitHub
liugddx commented on code in PR #8536: URL: https://github.com/apache/seatunnel/pull/8536#discussion_r1922045077 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/factory/FactoryUtil.java: ## @@ -65,31 +73,53 @@ public final class FactoryUtil { public static

Re: [PR] [feature][core] Unified engine initialization connector logic [seatunnel]

2025-01-19 Thread via GitHub
Hisoka-X commented on code in PR #8536: URL: https://github.com/apache/seatunnel/pull/8536#discussion_r1921855247 ## seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/execution/PluginUtil.java: ## @@ -163,87 +75,6 @@ public static Optional cre

[PR] [feature][core] Unified engine initialization connector logic [seatunnel]

2025-01-16 Thread via GitHub
liugddx opened a new pull request, #8536: URL: https://github.com/apache/seatunnel/pull/8536 ### Purpose of this pull request ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? ### Check list