Re: [PR] [Fix][transform-v2]SQL transform support max/min function [seatunnel]

2025-02-10 Thread via GitHub
hailin0 merged PR #8625: URL: https://github.com/apache/seatunnel/pull/8625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunne

Re: [PR] [Fix][transform-v2]SQL transform support max/min function [seatunnel]

2025-02-09 Thread via GitHub
hailin0 commented on code in PR #8625: URL: https://github.com/apache/seatunnel/pull/8625#discussion_r1948326811 ## seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/functions/NumericFunction.java: ## @@ -443,4 +446,52 @@ public static Number trunc(Li

Re: [PR] [Fix][transform-v2]SQL transform support max/min function [seatunnel]

2025-02-09 Thread via GitHub
CosmosNi commented on PR #8625: URL: https://github.com/apache/seatunnel/pull/8625#issuecomment-2646709685 @Hisoka-X PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Fix][transform-v2]SQL transform support max/min function [seatunnel]

2025-02-08 Thread via GitHub
CosmosNi commented on code in PR #8625: URL: https://github.com/apache/seatunnel/pull/8625#discussion_r1947545294 ## docs/en/transform-v2/sql-functions.md: ## @@ -385,6 +385,26 @@ Example: ACOS(D) +### MAX + +```MAX(ARRAY)``` Review Comment: get -- This is an automa

Re: [PR] [Fix][transform-v2]SQL transform support max/min function [seatunnel]

2025-02-08 Thread via GitHub
hailin0 commented on code in PR #8625: URL: https://github.com/apache/seatunnel/pull/8625#discussion_r1947540154 ## docs/en/transform-v2/sql-functions.md: ## @@ -385,6 +385,26 @@ Example: ACOS(D) +### MAX + +```MAX(ARRAY)``` Review Comment: rename to ARRAY_MAX ? --

[PR] [Fix][transform-v2]SQL transform support max/min function [seatunnel]

2025-02-07 Thread via GitHub
CosmosNi opened a new pull request, #8625: URL: https://github.com/apache/seatunnel/pull/8625 SQL transform support max/min function ### Purpose of this pull request ### Does this PR introduce _any_ user-facing change? ### How was this patc