Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

2024-08-10 Thread via GitHub
TyrantLucifer commented on code in PR #7355: URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712907833 ## seatunnel-translation/seatunnel-translation-flink/seatunnel-translation-flink-common/src/main/java/org/apache/seatunnel/translation/flink/source/FlinkRowCollector.ja

Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

2024-08-10 Thread via GitHub
Carl-Zhou-CN commented on code in PR #7355: URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712906351 ## seatunnel-translation/seatunnel-translation-flink/seatunnel-translation-flink-common/src/main/java/org/apache/seatunnel/translation/flink/source/FlinkRowCollector.jav

Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

2024-08-10 Thread via GitHub
Carl-Zhou-CN commented on code in PR #7355: URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712906351 ## seatunnel-translation/seatunnel-translation-flink/seatunnel-translation-flink-common/src/main/java/org/apache/seatunnel/translation/flink/source/FlinkRowCollector.jav

Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

2024-08-10 Thread via GitHub
TyrantLucifer commented on code in PR #7355: URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712905056 ## seatunnel-translation/seatunnel-translation-flink/seatunnel-translation-flink-common/src/main/java/org/apache/seatunnel/translation/flink/source/FlinkRowCollector.ja

Re: [I] 错误: 找不到或无法加载主类 [seatunnel]

2024-08-10 Thread via GitHub
inuex commented on issue #7364: URL: https://github.com/apache/seatunnel/issues/7364#issuecomment-2282371239 > Compiled by yourself? And the system is window It is a Windows 11 system. After extracting version 2.3.6 and testing it in the home directory, sometimes this error may be rep

Re: [I] 错误: 找不到或无法加载主类 [seatunnel]

2024-08-10 Thread via GitHub
Carl-Zhou-CN commented on issue #7364: URL: https://github.com/apache/seatunnel/issues/7364#issuecomment-2282353324 Compiled by yourself? And the system is window -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

2024-08-10 Thread via GitHub
Carl-Zhou-CN commented on code in PR #7355: URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712870775 ## seatunnel-translation/seatunnel-translation-flink/seatunnel-translation-flink-common/src/main/java/org/apache/seatunnel/translation/flink/source/FlinkRowCollector.jav

Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

2024-08-10 Thread via GitHub
Carl-Zhou-CN commented on code in PR #7355: URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712864081 ## seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/execution/DataStreamTableInfo.java: ##

Re: [PR] [Feature][Spark] Support multiple tables read and write [seatunnel]

2024-08-10 Thread via GitHub
Carl-Zhou-CN commented on code in PR #7283: URL: https://github.com/apache/seatunnel/pull/7283#discussion_r1712862376 ## seatunnel-core/seatunnel-spark-starter/seatunnel-spark-starter-common/src/main/java/org/apache/seatunnel/core/starter/spark/execution/SparkRuntimeEnvironment.java: ##

Re: [PR] [Feature][Spark] Support multiple tables read and write [seatunnel]

2024-08-10 Thread via GitHub
Carl-Zhou-CN commented on code in PR #7283: URL: https://github.com/apache/seatunnel/pull/7283#discussion_r1712862182 ## seatunnel-core/seatunnel-spark-starter/seatunnel-spark-starter-common/src/main/java/org/apache/seatunnel/core/starter/spark/execution/TransformExecuteProcessor.java:

Re: [PR] [Feature][Spark] Support multiple tables read and write [seatunnel]

2024-08-10 Thread via GitHub
Carl-Zhou-CN commented on code in PR #7283: URL: https://github.com/apache/seatunnel/pull/7283#discussion_r1712858303 ## seatunnel-core/seatunnel-spark-starter/seatunnel-spark-starter-common/src/main/java/org/apache/seatunnel/core/starter/spark/execution/TransformExecuteProcessor.java:

Re: [PR] [Feature][Spark] Support multiple tables read and write [seatunnel]

2024-08-10 Thread via GitHub
Carl-Zhou-CN commented on code in PR #7283: URL: https://github.com/apache/seatunnel/pull/7283#discussion_r1712858303 ## seatunnel-core/seatunnel-spark-starter/seatunnel-spark-starter-common/src/main/java/org/apache/seatunnel/core/starter/spark/execution/TransformExecuteProcessor.java:

Re: [I] Whether the paging function of the http connector can specify the page from which to read [seatunnel]

2024-08-10 Thread via GitHub
github-actions[bot] commented on issue #7114: URL: https://github.com/apache/seatunnel/issues/7114#issuecomment-2282327442 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

Re: [I] [Bug] [Seatunnel-Core] Too much flink-table-planner.jar in the tmp dir [seatunnel]

2024-08-10 Thread via GitHub
github-actions[bot] commented on issue #7163: URL: https://github.com/apache/seatunnel/issues/7163#issuecomment-2282327427 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

Re: [PR] [Improve] refactor clickhouse connector, using Factory to create source/sink [seatunnel]

2024-08-10 Thread via GitHub
jovezhong commented on PR #6975: URL: https://github.com/apache/seatunnel/pull/6975#issuecomment-2282199774 @liunaijie , any plan to merge this PR soon? I also noticed your branch name is `clickhouse-savemode` but it seems that save mode of ClickHouse sink is not in the PR. Look forward to

Re: [PR] [Feature][Connector-V2] Support TableSourceFactory/TableSinkFactory on clickhouse connector [seatunnel]

2024-08-10 Thread via GitHub
jovezhong commented on PR #6416: URL: https://github.com/apache/seatunnel/pull/6416#issuecomment-2282197913 Probably close this PR since it's duplicated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Bump org.apache.activemq:activemq-client from 5.14.5 to 5.15.16 in /seatunnel-connectors-v2/connector-activemq [seatunnel]

2024-08-10 Thread via GitHub
Hisoka-X commented on PR #7323: URL: https://github.com/apache/seatunnel/pull/7323#issuecomment-2282197358 thanks @asapekia -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bump org.apache.activemq:activemq-client from 5.14.5 to 5.15.16 in /seatunnel-connectors-v2/connector-activemq [seatunnel]

2024-08-10 Thread via GitHub
asapekia commented on PR #7323: URL: https://github.com/apache/seatunnel/pull/7323#issuecomment-2282191284 we can merge this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

(seatunnel) branch dev updated: [Feature] Split transform and move jar into connectors directory (#7218)

2024-08-10 Thread wanghailin
This is an automated email from the ASF dual-hosted git repository. wanghailin pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new d46cf16e5a [Feature] Split transform and move j

Re: [PR] [Feature] Split transform and move jar into connectors directory [seatunnel]

2024-08-10 Thread via GitHub
hailin0 merged PR #7218: URL: https://github.com/apache/seatunnel/pull/7218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunne

Re: [PR] 2.3.6 release [seatunnel]

2024-08-10 Thread via GitHub
hailin0 closed pull request #7320: 2.3.6 release URL: https://github.com/apache/seatunnel/pull/7320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

Re: [PR] Bump org.apache.activemq:activemq-client from 5.14.5 to 5.15.16 in /seatunnel-connectors-v2/connector-activemq [seatunnel]

2024-08-10 Thread via GitHub
hailin0 commented on PR #7323: URL: https://github.com/apache/seatunnel/pull/7323#issuecomment-2282190187 > will test this once in local and confirm @asapekia -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

2024-08-10 Thread via GitHub
hailin0 commented on code in PR #7355: URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712664758 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java: ## @@ -66,6 +75,10 @@ public RowKind getRowKind() { return this.kind;

Re: [PR] [Feature][Rabbitmq] Allow configuration of queue durability and deletion policy [seatunnel]

2024-08-10 Thread via GitHub
zqr10159 commented on PR #7365: URL: https://github.com/apache/seatunnel/pull/7365#issuecomment-2281995245 > Thanks @zqr10159 for contribute this! Could you add a test case in https://github.com/apache/seatunnel/blob/862e2055cec6a4428ec4cf67b472ba41ca364d05/seatunnel-e2e/seatunnel-connector-

Re: [PR] [Feature][Connector-V2] add Aliyun SLS connector #3733 [seatunnel]

2024-08-10 Thread via GitHub
XenosK commented on PR #7348: URL: https://github.com/apache/seatunnel/pull/7348#issuecomment-2281786961 cc @Hisoka-X A screenshot of the successful test and Is it as indicated in the screenshot to disable the test case -- This is an automated message from the Apache Git Service. To respo

Re: [PR] [Feature][Seatunnel-web] Add FakeSource and Console data sources into seatunnel-web [seatunnel-web]

2024-08-10 Thread via GitHub
arshadmohammad commented on PR #176: URL: https://github.com/apache/seatunnel-web/pull/176#issuecomment-2281676372 Thanks @Hisoka-X for reviewing and merging the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

(seatunnel-web) branch main updated: [Feature][Seatunnel-web] Add FakeSource and Console data sources into seatunnel-web (#176)

2024-08-10 Thread fanjia
This is an automated email from the ASF dual-hosted git repository. fanjia pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/seatunnel-web.git The following commit(s) were added to refs/heads/main by this push: new b12506d2 [Feature][Seatunnel-web] Add FakeSou

Re: [PR] [Feature][Seatunnel-web] Add FakeSource and Console data sources into seatunnel-web [seatunnel-web]

2024-08-10 Thread via GitHub
Hisoka-X merged PR #176: URL: https://github.com/apache/seatunnel-web/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatu

Re: [I] [Feature][Seatunnel-web] Add FakeSource and Console data sources into seatunnel-web [seatunnel]

2024-08-10 Thread via GitHub
Hisoka-X closed issue #7347: [Feature][Seatunnel-web] Add FakeSource and Console data sources into seatunnel-web URL: https://github.com/apache/seatunnel/issues/7347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Feature][Rabbitmq] Allow configuration of queue durability and deletion policy [seatunnel]

2024-08-10 Thread via GitHub
Hisoka-X commented on PR #7365: URL: https://github.com/apache/seatunnel/pull/7365#issuecomment-2281518524 Thanks @zqr10159 for contribute this! Could you add a test case in https://github.com/apache/seatunnel/blob/862e2055cec6a4428ec4cf67b472ba41ca364d05/seatunnel-e2e/seatunnel-connector-v2

Re: [PR] [Bug][Connector-v2][KafkaSource]Fix the abnormal exit of KafkaConsumerThread. [seatunnel]

2024-08-10 Thread via GitHub
Hisoka-X commented on code in PR #7273: URL: https://github.com/apache/seatunnel/pull/7273#discussion_r1712635485 ## seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaConsumerThread.java: ## @@ -58,8 +61,7 @@ public

Re: [PR] [Bug][Connector-v2][KafkaSource]Fix the abnormal exit of KafkaConsumerThread. [seatunnel]

2024-08-10 Thread via GitHub
Hisoka-X commented on code in PR #7273: URL: https://github.com/apache/seatunnel/pull/7273#discussion_r1712635332 ## seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaConsumerThread.java: ## @@ -58,8 +61,7 @@ public

Re: [PR] [Feature][Spark] Support multiple tables read and write [seatunnel]

2024-08-10 Thread via GitHub
CheneyYin commented on code in PR #7283: URL: https://github.com/apache/seatunnel/pull/7283#discussion_r1712635210 ## seatunnel-core/seatunnel-spark-starter/seatunnel-spark-starter-common/src/main/java/org/apache/seatunnel/core/starter/spark/execution/TransformExecuteProcessor.java: ###

Re: [PR] [Feature][Spark] Support multiple tables read and write [seatunnel]

2024-08-10 Thread via GitHub
CheneyYin commented on code in PR #7283: URL: https://github.com/apache/seatunnel/pull/7283#discussion_r1712634235 ## seatunnel-core/seatunnel-spark-starter/seatunnel-spark-starter-common/src/main/java/org/apache/seatunnel/core/starter/spark/execution/TransformExecuteProcessor.java: ###

Re: [PR] [Feature][Spark] Support multiple tables read and write [seatunnel]

2024-08-10 Thread via GitHub
CheneyYin commented on code in PR #7283: URL: https://github.com/apache/seatunnel/pull/7283#discussion_r1712634320 ## seatunnel-core/seatunnel-spark-starter/seatunnel-spark-starter-common/src/main/java/org/apache/seatunnel/core/starter/spark/execution/TransformExecuteProcessor.java: ###

Re: [PR] [Feature][Spark] Support multiple tables read and write [seatunnel]

2024-08-10 Thread via GitHub
CheneyYin commented on code in PR #7283: URL: https://github.com/apache/seatunnel/pull/7283#discussion_r1712634235 ## seatunnel-core/seatunnel-spark-starter/seatunnel-spark-starter-common/src/main/java/org/apache/seatunnel/core/starter/spark/execution/TransformExecuteProcessor.java: ###

Re: [PR] [Feature][Spark] Support multiple tables read and write [seatunnel]

2024-08-10 Thread via GitHub
CheneyYin commented on code in PR #7283: URL: https://github.com/apache/seatunnel/pull/7283#discussion_r1712633043 ## seatunnel-core/seatunnel-spark-starter/seatunnel-spark-starter-common/src/main/java/org/apache/seatunnel/core/starter/spark/execution/SparkRuntimeEnvironment.java: #

Re: [PR] [Feature][Seatunnel-web] Add FakeSource and Console data sources into seatunnel-web [seatunnel-web]

2024-08-10 Thread via GitHub
arshadmohammad commented on code in PR #176: URL: https://github.com/apache/seatunnel-web/pull/176#discussion_r1712631548 ## seatunnel-datasource/seatunnel-datasource-plugins/datasource-console/src/main/java/org/apache/seatunnel/datasource/plugin/console/ConsoleDataSourceConfig.java: ##

Re: [PR] [Feature][Seatunnel-web] Add FakeSource and Console data sources into seatunnel-web [seatunnel-web]

2024-08-10 Thread via GitHub
arshadmohammad commented on code in PR #176: URL: https://github.com/apache/seatunnel-web/pull/176#discussion_r1712622362 ## seatunnel-datasource/seatunnel-datasource-plugins/datasource-console/src/main/java/org/apache/seatunnel/datasource/plugin/console/ConsoleDataSourceConfig.java: ##

Re: [PR] [Feature][Seatunnel-web] Add FakeSource and Console data sources into seatunnel-web [seatunnel-web]

2024-08-10 Thread via GitHub
Hisoka-X commented on code in PR #176: URL: https://github.com/apache/seatunnel-web/pull/176#discussion_r1712612509 ## seatunnel-datasource/seatunnel-datasource-plugins/datasource-console/src/main/java/org/apache/seatunnel/datasource/plugin/console/ConsoleDataSourceConfig.java:

Re: [PR] [Feature][Seatunnel-web] Add FakeSource and Console data sources into seatunnel-web [seatunnel-web]

2024-08-10 Thread via GitHub
arshadmohammad commented on code in PR #176: URL: https://github.com/apache/seatunnel-web/pull/176#discussion_r1712606007 ## seatunnel-datasource/seatunnel-datasource-plugins/datasource-console/src/main/java/org/apache/seatunnel/datasource/plugin/console/ConsoleDataSourceConfig.java: ##

Re: [PR] [Feature][Seatunnel-web] Add FakeSource and Console data sources into seatunnel-web [seatunnel-web]

2024-08-10 Thread via GitHub
Hisoka-X commented on code in PR #176: URL: https://github.com/apache/seatunnel-web/pull/176#discussion_r1712602664 ## seatunnel-datasource/seatunnel-datasource-plugins/datasource-console/src/main/java/org/apache/seatunnel/datasource/plugin/console/ConsoleDataSourceConfig.java:

Re: [PR] [Feature][Seatunnel-web] Add FakeSource and Console data sources into seatunnel-web [seatunnel-web]

2024-08-10 Thread via GitHub
arshadmohammad commented on code in PR #176: URL: https://github.com/apache/seatunnel-web/pull/176#discussion_r1712595787 ## seatunnel-datasource/seatunnel-datasource-plugins/datasource-console/src/main/java/org/apache/seatunnel/datasource/plugin/console/ConsoleDataSourceConfig.java: ##

Re: [PR] [Fix] Fix http e2e case [seatunnel]

2024-08-10 Thread via GitHub
Hisoka-X commented on code in PR #7356: URL: https://github.com/apache/seatunnel/pull/7356#discussion_r1712586654 ## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-http-e2e/pom.xml: ## @@ -98,6 +98,20 @@ ${project.version} test + +

Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

2024-08-10 Thread via GitHub
TyrantLucifer commented on code in PR #7355: URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712580747 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java: ## @@ -50,7 +50,17 @@ public void setTableId(String tableId) { th

Re: [I] [Bug] [Module Name] Doris custom_sql can't work [seatunnel]

2024-08-10 Thread via GitHub
Hisoka-X commented on issue #7367: URL: https://github.com/apache/seatunnel/issues/7367#issuecomment-2279990900 cc @chl-wxp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

2024-08-10 Thread via GitHub
Hisoka-X commented on code in PR #7355: URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712576185 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java: ## @@ -50,7 +50,17 @@ public void setTableId(String tableId) { this.ta

Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

2024-08-10 Thread via GitHub
hailin0 commented on code in PR #7355: URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712574403 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java: ## @@ -54,6 +54,10 @@ public void setRowKind(RowKind kind) { this.kind

Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

2024-08-10 Thread via GitHub
hailin0 commented on code in PR #7355: URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712574243 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java: ## @@ -54,6 +54,10 @@ public void setRowKind(RowKind kind) { this.kind

Re: [PR] [Improve][Document] Change deprecated connector name in setup.md [seatunnel]

2024-08-10 Thread via GitHub
TyrantLucifer merged PR #7366: URL: https://github.com/apache/seatunnel/pull/7366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@se

(seatunnel) branch dev updated: [Improve][Document] Change deprecated connector name in setup.md (#7366)

2024-08-10 Thread tyrantlucifer
This is an automated email from the ASF dual-hosted git repository. tyrantlucifer pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 862e2055ce [Improve][Document] Change deprec

Re: [PR] [Improve][Connector] Add multi-table sink option check [seatunnel]

2024-08-10 Thread via GitHub
Hisoka-X commented on code in PR #7360: URL: https://github.com/apache/seatunnel/pull/7360#discussion_r1712574052 ## seatunnel-dist/src/test/java/org/apache/seatunnel/api/connector/ConnectorSpecificationCheckTest.java: ## @@ -152,16 +154,29 @@ public void testAllConnectorImplem

Re: [PR] [Core][Flink] refactor flink proxy source/sink [seatunnel]

2024-08-10 Thread via GitHub
hailin0 commented on code in PR #7355: URL: https://github.com/apache/seatunnel/pull/7355#discussion_r1712573879 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java: ## @@ -54,6 +54,10 @@ public void setRowKind(RowKind kind) { this.kind