[GitHub] [incubator-seatunnel] general7078 commented on issue #2736: [Bug] --variable无法替换配置文件里的${}变量

2023-02-20 Thread via GitHub
general7078 commented on issue #2736: URL: https://github.com/apache/incubator-seatunnel/issues/2736#issuecomment-1437983478 > I use 2.3.0 and the developing 2.3.1, found the same bug. it can replace with environment variable which use 'export param = param_val' from shell, but it fails wh

[GitHub] [incubator-seatunnel] general7078 commented on issue #2736: [Bug] --variable无法替换配置文件里的${}变量

2023-02-20 Thread via GitHub
general7078 commented on issue #2736: URL: https://github.com/apache/incubator-seatunnel/issues/2736#issuecomment-1437981672 I use 2.3.0 and the developing 2.3.1, found the same bug. it can replace with environment variable which use 'export param = param_val' from shell, but it fails when

[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #4128: [Bug] [Spark] The configured streaming mode does not take effect when the spark engine is used

2023-02-20 Thread via GitHub
TyrantLucifer commented on code in PR #4128: URL: https://github.com/apache/incubator-seatunnel/pull/4128#discussion_r1112626227 ## seatunnel-core/seatunnel-spark-starter/seatunnel-spark-3-starter/src/main/java/org/apache/seatunnel/core/starter/spark/execution/SinkExecuteProcessor.java

[incubator-seatunnel] branch cdc-multiple-table updated: [improve][DAG] use multi-table config parser (#4176)

2023-02-20 Thread zongwen
This is an automated email from the ASF dual-hosted git repository. zongwen pushed a commit to branch cdc-multiple-table in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/cdc-multiple-table by this push: new 5d2415117

[GitHub] [incubator-seatunnel] ashulin merged pull request #4176: [improve][DAG] use multi-table config parser

2023-02-20 Thread via GitHub
ashulin merged PR #4176: URL: https://github.com/apache/incubator-seatunnel/pull/4176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [incubator-seatunnel] ashulin opened a new pull request, #4176: [improve][DAG] use multi-table config parser

2023-02-20 Thread via GitHub
ashulin opened a new pull request, #4176: URL: https://github.com/apache/incubator-seatunnel/pull/4176 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar binary p

[GitHub] [incubator-seatunnel] EricJoy2048 commented on issue #4150: [OnlineMeeting&Feb.21]SeaTunnel community meeting Topic collect

2023-02-20 Thread via GitHub
EricJoy2048 commented on issue #4150: URL: https://github.com/apache/incubator-seatunnel/issues/4150#issuecomment-1437891190 > SQL Parser and Generate PhysicalQueryPlan execution It seems `SQL Parser and Generate PhysicalQueryPlan execution` is better way for us. -- This is an aut

[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #4135: [Improve] [CI] Determine whether the plugin_config and pom.xml configurations match the updated connector

2023-02-20 Thread via GitHub
EricJoy2048 commented on code in PR #4135: URL: https://github.com/apache/incubator-seatunnel/pull/4135#discussion_r1112534032 ## tools/update_modules_check/update_modules_check.py: ## @@ -159,6 +159,37 @@ def get_sub_it_modules(modules, total_num, current_num): output = o

[incubator-seatunnel] branch cdc-multiple-table updated: [improve][api] add multi-table parser (#4175)

2023-02-20 Thread zongwen
This is an automated email from the ASF dual-hosted git repository. zongwen pushed a commit to branch cdc-multiple-table in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/cdc-multiple-table by this push: new c407ec5c2

[GitHub] [incubator-seatunnel] ashulin merged pull request #4175: [improve][api] add multiple table parser

2023-02-20 Thread via GitHub
ashulin merged PR #4175: URL: https://github.com/apache/incubator-seatunnel/pull/4175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #4174: [Hotfix][Zeta][Config] config advanced-network-configuration

2023-02-20 Thread via GitHub
TyrantLucifer commented on PR #4174: URL: https://github.com/apache/incubator-seatunnel/pull/4174#issuecomment-1437781173 > I have been tested,PTAL thanks. @TyrantLucifer Give me some time. cc @john8628 Could you please help us test it? -- This is an automated message from the Apac

[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #3679: [Feature][Connector-V2] StarRocks source connector

2023-02-20 Thread via GitHub
hailin0 commented on code in PR #3679: URL: https://github.com/apache/incubator-seatunnel/pull/3679#discussion_r1112470799 ## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-starrocks-e2e/src/test/resources/starrocks-thrift-to-starrocks-streamload.conf: ## @@ -21,12 +21,31 @

[GitHub] [incubator-seatunnel] ashulin opened a new pull request, #4175: [improve][api] add multiple table parser

2023-02-20 Thread via GitHub
ashulin opened a new pull request, #4175: URL: https://github.com/apache/incubator-seatunnel/pull/4175 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar binary p

[GitHub] [incubator-seatunnel] wineternity commented on pull request #4172: [Bug] [Connector-V2] Clickhouse File Connector failed to sink to table with settings like storage_policy

2023-02-20 Thread via GitHub
wineternity commented on PR #4172: URL: https://github.com/apache/incubator-seatunnel/pull/4172#issuecomment-1437755956 > Can you add e2e test for this pr? OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-seatunnel] liugddx commented on pull request #4164: [Feature][ConnectorV2]add file excel sink

2023-02-20 Thread via GitHub
liugddx commented on PR #4164: URL: https://github.com/apache/incubator-seatunnel/pull/4164#issuecomment-1437737669 you also should update release-note https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md -- This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-seatunnel] liugddx commented on pull request #4174: [Hotfix][Zeta][Config] config advanced-network-configuration

2023-02-20 Thread via GitHub
liugddx commented on PR #4174: URL: https://github.com/apache/incubator-seatunnel/pull/4174#issuecomment-1437730991 I have been tested,PTAL thanks. @TyrantLucifer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [incubator-seatunnel] github-actions[bot] closed issue #2789: [Improve] [Connector-V2-Clickhouse] Improve Clickhouse Connector

2023-02-20 Thread via GitHub
github-actions[bot] closed issue #2789: [Improve] [Connector-V2-Clickhouse] Improve Clickhouse Connector URL: https://github.com/apache/incubator-seatunnel/issues/2789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [incubator-seatunnel] github-actions[bot] commented on issue #2789: [Improve] [Connector-V2-Clickhouse] Improve Clickhouse Connector

2023-02-20 Thread via GitHub
github-actions[bot] commented on issue #2789: URL: https://github.com/apache/incubator-seatunnel/issues/2789#issuecomment-1437698147 This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future. --

[GitHub] [incubator-seatunnel] github-actions[bot] commented on issue #3869: The maxcompute source does not support the conversion of date type

2023-02-20 Thread via GitHub
github-actions[bot] commented on issue #3869: URL: https://github.com/apache/incubator-seatunnel/issues/3869#issuecomment-1437698103 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity

[GitHub] [incubator-seatunnel] rewerma commented on issue #4150: [OnlineMeeting&Feb.21]SeaTunnel community meeting Topic collect

2023-02-20 Thread via GitHub
rewerma commented on issue #4150: URL: https://github.com/apache/incubator-seatunnel/issues/4150#issuecomment-1437175304 > H2 insert increase data to memory is not the main problem of worse performance, but the JDBC executeQuery operation is. As the benchmark, the operation of qu

[GitHub] [incubator-seatunnel] TyrantLucifer merged pull request #4155: [Feature][Connector-V2][Github] Adding Github Source Connector

2023-02-20 Thread via GitHub
TyrantLucifer merged PR #4155: URL: https://github.com/apache/incubator-seatunnel/pull/4155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[incubator-seatunnel] branch dev updated: [Improve][Shell] Remove redundant code of install-plugin.sh (#4153)

2023-02-20 Thread tyrantlucifer
This is an automated email from the ASF dual-hosted git repository. tyrantlucifer pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new e109db903 [Improve][Shell] Remove

[GitHub] [incubator-seatunnel] TyrantLucifer merged pull request #4153: [Improve] [bin] Remove redundant shell for install-plugin.sh

2023-02-20 Thread via GitHub
TyrantLucifer merged PR #4153: URL: https://github.com/apache/incubator-seatunnel/pull/4153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [incubator-seatunnel] TaoZex commented on a diff in pull request #4153: [Improve] [bin] Remove redundant shell for install-plugin.sh

2023-02-20 Thread via GitHub
TaoZex commented on code in PR #4153: URL: https://github.com/apache/incubator-seatunnel/pull/4153#discussion_r1112044239 ## seatunnel-examples/seatunnel-spark-connector-v2-example/src/main/resources/examples/spark.batch.conf: ## @@ -1,98 +1,35 @@ -# Review Comment: Sorry,

[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #4153: [Improve] [bin] Remove redundant shell for install-plugin.sh

2023-02-20 Thread via GitHub
liugddx commented on code in PR #4153: URL: https://github.com/apache/incubator-seatunnel/pull/4153#discussion_r1112035405 ## seatunnel-examples/seatunnel-spark-connector-v2-example/src/main/resources/examples/spark.batch.conf: ## @@ -1,98 +1,35 @@ -# Review Comment: Why ch

[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #4153: [Improve] [bin] Remove redundant shell for install-plugin.sh

2023-02-20 Thread via GitHub
TyrantLucifer commented on code in PR #4153: URL: https://github.com/apache/incubator-seatunnel/pull/4153#discussion_r1112034856 ## seatunnel-examples/seatunnel-spark-connector-v2-example/src/main/resources/examples/spark.batch.conf: ## @@ -1,98 +1,35 @@ -# -# Licensed to the A

[GitHub] [incubator-seatunnel] Al-assad commented on pull request #4155: [Feature][Connector-V2][Github] Adding Github Source Connector

2023-02-20 Thread via GitHub
Al-assad commented on PR #4155: URL: https://github.com/apache/incubator-seatunnel/pull/4155#issuecomment-1437121401 > > I just submitted an update to the release-note and the approval status will be dimissed again in the github mechanism, please re-add your approval, thanks

[GitHub] [incubator-seatunnel] liugddx closed pull request #4159: [Hotfix][Zeta][Config] config advanced-network-configuration

2023-02-20 Thread via GitHub
liugddx closed pull request #4159: [Hotfix][Zeta][Config] config advanced-network-configuration URL: https://github.com/apache/incubator-seatunnel/pull/4159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-seatunnel] liugddx commented on pull request #4159: [Hotfix][Zeta][Config] config advanced-network-configuration

2023-02-20 Thread via GitHub
liugddx commented on PR #4159: URL: https://github.com/apache/incubator-seatunnel/pull/4159#issuecomment-1437117177 I will close this pr and refer to #4174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-seatunnel] liugddx opened a new pull request, #4174: [Hotfix][Zeta][Config] config advanced-network-configuration

2023-02-20 Thread via GitHub
liugddx opened a new pull request, #4174: URL: https://github.com/apache/incubator-seatunnel/pull/4174 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar binary p

[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #4153: [Improve] [bin] Remove redundant shell for install-plugin.sh

2023-02-20 Thread via GitHub
TyrantLucifer commented on code in PR #4153: URL: https://github.com/apache/incubator-seatunnel/pull/4153#discussion_r1112025381 ## bin/install-plugin.sh: ## @@ -43,61 +43,18 @@ if [ ! -d ${SEATUNNEL_HOME}/connectors ]; echo "create connectors directory" fi -# create

[GitHub] [incubator-seatunnel] liugddx commented on pull request #4155: [Feature][Connector-V2][Github] Adding Github Source Connector

2023-02-20 Thread via GitHub
liugddx commented on PR #4155: URL: https://github.com/apache/incubator-seatunnel/pull/4155#issuecomment-1437101584 > > Update https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml > > Resolved 😃. You should update `release-note.md` for this pr. -- T

[GitHub] [incubator-seatunnel] Al-assad commented on pull request #4155: [Feature][Connector-V2][Github] Adding Github Source Connector

2023-02-20 Thread via GitHub
Al-assad commented on PR #4155: URL: https://github.com/apache/incubator-seatunnel/pull/4155#issuecomment-1437087172 > Update https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml Resolved 😃. -- This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-seatunnel] ic4y closed pull request #4088: [Feature][Zeta] Enable Task thread share

2023-02-20 Thread via GitHub
ic4y closed pull request #4088: [Feature][Zeta] Enable Task thread share URL: https://github.com/apache/incubator-seatunnel/pull/4088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [incubator-seatunnel] ic4y opened a new pull request, #4173: [Feature][Zeta] Enable Task thread share

2023-02-20 Thread via GitHub
ic4y opened a new pull request, #4173: URL: https://github.com/apache/incubator-seatunnel/pull/4173 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar binary pack

[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #4153: [Improve] [bin] Remove redundant shell for install-plugin.sh

2023-02-20 Thread via GitHub
liugddx commented on code in PR #4153: URL: https://github.com/apache/incubator-seatunnel/pull/4153#discussion_r1112004533 ## bin/install-plugin.sh: ## @@ -43,61 +43,18 @@ if [ ! -d ${SEATUNNEL_HOME}/connectors ]; echo "create connectors directory" fi -# create the fl

[GitHub] [incubator-seatunnel] wineternity opened a new pull request, #4172: [Bug] [Connector-V2] Clickhouse File Connector failed to sink to table with settings like storage_policy

2023-02-20 Thread via GitHub
wineternity opened a new pull request, #4172: URL: https://github.com/apache/incubator-seatunnel/pull/4172 ## Purpose of this pull request ## Check list * [x] Code changed are covered with tests, or it does not need tests for reason: * [x] If any new Jar bina

[GitHub] [incubator-seatunnel] laglangyue commented on issue #4150: [OnlineMeeting&Feb.21]SeaTunnel community meeting Topic collect

2023-02-20 Thread via GitHub
laglangyue commented on issue #4150: URL: https://github.com/apache/incubator-seatunnel/issues/4150#issuecomment-1437066588 For H2, we need to write data into H2, and then query the results. With the increase of data volume, the performance will be much worse. For calcite, IO is not need.

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #4155: [Feature][Connector-V2][Github] Adding Github Source Connector

2023-02-20 Thread via GitHub
TyrantLucifer commented on PR #4155: URL: https://github.com/apache/incubator-seatunnel/pull/4155#issuecomment-1437051503 > > Update https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml > > Sorry my fault, you also should update release-note https://github.c

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #4155: [Feature][Connector-V2][Github] Adding Github Source Connector

2023-02-20 Thread via GitHub
TyrantLucifer commented on PR #4155: URL: https://github.com/apache/incubator-seatunnel/pull/4155#issuecomment-1437051066 > Update https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml Sorry my fault, you also should update release-note https://github.com/apa

[incubator-seatunnel-web] branch main updated: [Feat][UI] Adjust menu structure. (#25)

2023-02-20 Thread songjian
This is an automated email from the ASF dual-hosted git repository. songjian pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel-web.git The following commit(s) were added to refs/heads/main by this push: new c1c0f862 [Feat][UI] Adjust menu s

[GitHub] [incubator-seatunnel-web] songjianet merged pull request #25: [Feat][UI] Adjust menu structure.

2023-02-20 Thread via GitHub
songjianet merged PR #25: URL: https://github.com/apache/incubator-seatunnel-web/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [incubator-seatunnel] Al-assad commented on pull request #4155: [Feature][Connector-V2][Github] Adding Github Source Connector

2023-02-20 Thread via GitHub
Al-assad commented on PR #4155: URL: https://github.com/apache/incubator-seatunnel/pull/4155#issuecomment-1437029872 @liugddx @TyrantLucifer Thanks for your suggestions, please take a look agian. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-seatunnel-web] songjianet opened a new pull request, #25: [Feat][UI] Adjust menu structure.

2023-02-20 Thread via GitHub
songjianet opened a new pull request, #25: URL: https://github.com/apache/incubator-seatunnel-web/pull/25 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar binar

[GitHub] [incubator-seatunnel] TaoZex commented on a diff in pull request #4153: [Improve] [bin] Remove redundant shell for install-plugin.sh

2023-02-20 Thread via GitHub
TaoZex commented on code in PR #4153: URL: https://github.com/apache/incubator-seatunnel/pull/4153#discussion_r947792 ## bin/install-plugin.sh: ## @@ -43,57 +43,16 @@ if [ ! -d ${SEATUNNEL_HOME}/connectors ]; echo "create connectors directory" fi -# create the fli

[GitHub] [incubator-seatunnel] liugddx commented on pull request #4159: [Hotfix][Zeta][Config] config advanced-network-configuration

2023-02-20 Thread via GitHub
liugddx commented on PR #4159: URL: https://github.com/apache/incubator-seatunnel/pull/4159#issuecomment-1436983491 > This pull request maybe cause this error: > > https://github.com/apache/incubator-seatunnel/actions/runs/4223196739/jobs/7332744419#step:5:44330 > > https://g

[GitHub] [incubator-seatunnel] TyrantLucifer closed issue #4163: [Feature][format] Add avro format for Seatunnel

2023-02-20 Thread via GitHub
TyrantLucifer closed issue #4163: [Feature][format] Add avro format for Seatunnel URL: https://github.com/apache/incubator-seatunnel/issues/4163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [incubator-seatunnel] TyrantLucifer commented on issue #4163: [Feature][format] Add avro format for Seatunnel

2023-02-20 Thread via GitHub
TyrantLucifer commented on issue #4163: URL: https://github.com/apache/incubator-seatunnel/issues/4163#issuecomment-1436971326 This requirement has been discussed in https://github.com/apache/incubator-seatunnel/issues/3120, please send an e-mail to d...@seatunnel.apache.org and discuss wi

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #4160: [Bug][Connector-V2] Field aliases are not supported in the query of jdbc source.

2023-02-20 Thread via GitHub
TyrantLucifer commented on PR #4160: URL: https://github.com/apache/incubator-seatunnel/pull/4160#issuecomment-1436958147 Could you please submit this pull request to dev branch? Becase the code could not be changed when release process has done. This bug will be fixed in 2.3.1-release.

[GitHub] [incubator-seatunnel] TyrantLucifer closed pull request #4160: [Bug][Connector-V2] Field aliases are not supported in the query of jdbc source.

2023-02-20 Thread via GitHub
TyrantLucifer closed pull request #4160: [Bug][Connector-V2] Field aliases are not supported in the query of jdbc source. URL: https://github.com/apache/incubator-seatunnel/pull/4160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[incubator-seatunnel-web] branch main updated: [Feat][UI] Complete style writing. (#24)

2023-02-20 Thread songjian
This is an automated email from the ASF dual-hosted git repository. songjian pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel-web.git The following commit(s) were added to refs/heads/main by this push: new a51089ed [Feat][UI] Complete styl

[GitHub] [incubator-seatunnel-web] songjianet merged pull request #24: [Feat][UI] Complete style writing.

2023-02-20 Thread via GitHub
songjianet merged PR #24: URL: https://github.com/apache/incubator-seatunnel-web/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [incubator-seatunnel-web] songjianet opened a new pull request, #24: [Feat][UI] Complete style writing.

2023-02-20 Thread via GitHub
songjianet opened a new pull request, #24: URL: https://github.com/apache/incubator-seatunnel-web/pull/24 ## Purpose of this pull request ![1676896683639](https://user-images.githubusercontent.com/19239641/220110265-9c06af7f-f8db-4a07-a730-dd5468179fe0.jpg) ![1676896683658](ht

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #4159: [Hotfix][Zeta][Config] config advanced-network-configuration

2023-02-20 Thread via GitHub
TyrantLucifer commented on PR #4159: URL: https://github.com/apache/incubator-seatunnel/pull/4159#issuecomment-1436945207 This pull request maybe cause this error: https://github.com/apache/incubator-seatunnel/actions/runs/4223196739/jobs/7332744419#step:5:44330 -- This is an auto

[GitHub] [incubator-seatunnel] rewerma commented on issue #4150: [OnlineMeeting&Feb.21]SeaTunnel community meeting Topic collect

2023-02-20 Thread via GitHub
rewerma commented on issue #4150: URL: https://github.com/apache/incubator-seatunnel/issues/4150#issuecomment-1436924220 > > > > Is there any benchmark data? Read, Transform and Write 2,000,000 rows benchmark data, Implements with: H2: ![30dd12d860fc9ce2db99a27e45e17746

[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #4155: [Feature][Connector-V2][Github] Adding Github Source Connector

2023-02-20 Thread via GitHub
TyrantLucifer commented on code in PR #4155: URL: https://github.com/apache/incubator-seatunnel/pull/4155#discussion_r870814 ## seatunnel-connectors-v2/connector-http/connector-http-github/src/main/java/org/apache/seatunnel/connectors/seatunnel/github/GithubPlugin.java: ##

[GitHub] [incubator-seatunnel] liugddx commented on pull request #4022: [Feature][API] improve save mode api

2023-02-20 Thread via GitHub
liugddx commented on PR #4022: URL: https://github.com/apache/incubator-seatunnel/pull/4022#issuecomment-1436859698 Can this PR continue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [incubator-seatunnel] rewerma commented on issue #4150: [OnlineMeeting&Feb.21]SeaTunnel community meeting Topic collect

2023-02-20 Thread via GitHub
rewerma commented on issue #4150: URL: https://github.com/apache/incubator-seatunnel/issues/4150#issuecomment-1436857532 > > > > How about add a Simple SQL transform plugin with internal mem SQL engine like H2DB, SQLite or Calcite. #4149 > > > > > > > > > H2 is not a good impleme

[GitHub] [incubator-seatunnel] liugddx commented on issue #4150: [OnlineMeeting&Feb.21]SeaTunnel community meeting Topic collect

2023-02-20 Thread via GitHub
liugddx commented on issue #4150: URL: https://github.com/apache/incubator-seatunnel/issues/4150#issuecomment-1436855725 > Is there any benchmark data? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [incubator-seatunnel] rewerma commented on issue #4150: [OnlineMeeting&Feb.21]SeaTunnel community meeting Topic collect

2023-02-20 Thread via GitHub
rewerma commented on issue #4150: URL: https://github.com/apache/incubator-seatunnel/issues/4150#issuecomment-1436851149 I implement the SQL engine by H2, Calcite and Internal implements. The Simple SQL physical query plan is simple, only three steps: PhysicalScanTable, PhysicalFilter an

[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #4155: [Feature][Connector-V2][Github] Adding Github Source Connector

2023-02-20 Thread via GitHub
liugddx commented on code in PR #4155: URL: https://github.com/apache/incubator-seatunnel/pull/4155#discussion_r845409 ## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-http-e2e/src/test/java/org/apache/seatunnel/e2e/connector/http/HttpGithubIT.java: ## @@ -0,0 +1,31 @@

[GitHub] [incubator-seatunnel] sunxiaojian commented on issue #4163: [Feature][format] Add avro format for Seatunnel

2023-02-20 Thread via GitHub
sunxiaojian commented on issue #4163: URL: https://github.com/apache/incubator-seatunnel/issues/4163#issuecomment-1436835379 You can assign it to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #4153: [Improve] [bin] Remove redundant shell for install-plugin.sh

2023-02-20 Thread via GitHub
liugddx commented on code in PR #4153: URL: https://github.com/apache/incubator-seatunnel/pull/4153#discussion_r831155 ## bin/install-plugin.sh: ## @@ -43,57 +43,16 @@ if [ ! -d ${SEATUNNEL_HOME}/connectors ]; echo "create connectors directory" fi -# create the fl

[GitHub] [incubator-seatunnel-web] dijiekstra commented on a diff in pull request #23: Added user status display and login judgment.

2023-02-20 Thread via GitHub
dijiekstra commented on code in PR #23: URL: https://github.com/apache/incubator-seatunnel-web/pull/23#discussion_r817546 ## seatunnel-server/seatunnel-app/src/main/java/org/apache/seatunnel/app/service/impl/UserServiceImpl.java: ## @@ -142,6 +145,10 @@ public UserSimpleInf

[GitHub] [incubator-seatunnel-web] dijiekstra merged pull request #21: [Fix][API] Fix that the response body does not return the token attribute after successful login

2023-02-20 Thread via GitHub
dijiekstra merged PR #21: URL: https://github.com/apache/incubator-seatunnel-web/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[incubator-seatunnel-web] branch main updated: [Fix][API] Fix that the response body does not return the token attribute after successful login (#21)

2023-02-20 Thread dijiekstra
This is an automated email from the ASF dual-hosted git repository. dijiekstra pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel-web.git The following commit(s) were added to refs/heads/main by this push: new 96ace88c [Fix][API] Fix that th

[incubator-seatunnel] branch cdc-multiple-table updated: [improve][api] Support for getting tables from the catalog (#4170)

2023-02-20 Thread zongwen
This is an automated email from the ASF dual-hosted git repository. zongwen pushed a commit to branch cdc-multiple-table in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/cdc-multiple-table by this push: new d144e176b

[GitHub] [incubator-seatunnel] ashulin merged pull request #4170: [improve][api] Support for getting tables from the catalog

2023-02-20 Thread via GitHub
ashulin merged PR #4170: URL: https://github.com/apache/incubator-seatunnel/pull/4170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[incubator-seatunnel] branch cdc-multiple-table updated: [improve][api] support for create sink (#4171)

2023-02-20 Thread zongwen
This is an automated email from the ASF dual-hosted git repository. zongwen pushed a commit to branch cdc-multiple-table in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/cdc-multiple-table by this push: new 1636afad0

[GitHub] [incubator-seatunnel] ashulin merged pull request #4171: [improve][api] support for create sink

2023-02-20 Thread via GitHub
ashulin merged PR #4171: URL: https://github.com/apache/incubator-seatunnel/pull/4171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [incubator-seatunnel] ashulin opened a new pull request, #4171: [improve][api] support for create sink

2023-02-20 Thread via GitHub
ashulin opened a new pull request, #4171: URL: https://github.com/apache/incubator-seatunnel/pull/4171 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar binary p

[GitHub] [incubator-seatunnel] ashulin opened a new pull request, #4170: [improve][api] Support for getting tables from the catalog

2023-02-20 Thread via GitHub
ashulin opened a new pull request, #4170: URL: https://github.com/apache/incubator-seatunnel/pull/4170 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar binary p

[GitHub] [incubator-seatunnel] ashulin merged pull request #4168: [improve][catalog][jdbc] Add MySQL catalog factory

2023-02-20 Thread via GitHub
ashulin merged PR #4168: URL: https://github.com/apache/incubator-seatunnel/pull/4168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[incubator-seatunnel] branch cdc-multiple-table updated: [improve][catalog][jdbc] Add MySQL catalog factory (#4168)

2023-02-20 Thread zongwen
This is an automated email from the ASF dual-hosted git repository. zongwen pushed a commit to branch cdc-multiple-table in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/cdc-multiple-table by this push: new 95e3cbf87

[incubator-seatunnel] branch cdc-multiple-table updated: [improve][factory] Support for creating multi-table sources (#4169)

2023-02-20 Thread zongwen
This is an automated email from the ASF dual-hosted git repository. zongwen pushed a commit to branch cdc-multiple-table in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/cdc-multiple-table by this push: new c892dea5c

[GitHub] [incubator-seatunnel] ashulin merged pull request #4169: [improve][factory] Support for creating multi-table sources

2023-02-20 Thread via GitHub
ashulin merged PR #4169: URL: https://github.com/apache/incubator-seatunnel/pull/4169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [incubator-seatunnel] ashulin merged pull request #4157: [improve][api] Refactoring schema parse

2023-02-20 Thread via GitHub
ashulin merged PR #4157: URL: https://github.com/apache/incubator-seatunnel/pull/4157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [incubator-seatunnel] liugddx commented on pull request #4159: [Hotfix][Zeta][Config] config advanced-network-configuration

2023-02-20 Thread via GitHub
liugddx commented on PR #4159: URL: https://github.com/apache/incubator-seatunnel/pull/4159#issuecomment-1436578148 > This pull request maybe cause #4154 I have communicated with him and the problem has been resolved. CC : @john8628 -- This is an automated message from the Apache

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #4159: [Hotfix][Zeta][Config] config advanced-network-configuration

2023-02-20 Thread via GitHub
TyrantLucifer commented on PR #4159: URL: https://github.com/apache/incubator-seatunnel/pull/4159#issuecomment-1436574414 link #4154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-seatunnel] liugddx closed issue #4154: [bug][zeta] seatunnel -cluster

2023-02-20 Thread via GitHub
liugddx closed issue #4154: [bug][zeta] seatunnel -cluster URL: https://github.com/apache/incubator-seatunnel/issues/4154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [incubator-seatunnel] liugddx commented on issue #4154: [bug][zeta] seatunnel -cluster

2023-02-20 Thread via GitHub
liugddx commented on issue #4154: URL: https://github.com/apache/incubator-seatunnel/issues/4154#issuecomment-1436544778 Ok, I will close this issue first, if there are still problems, you can reopen it. cc: @TyrantLucifer @EricJoy2048 @CalvinKirs @Hisoka-X -- This is an automated messa

[GitHub] [incubator-seatunnel] john8628 commented on issue #4154: [bug][zeta] seatunnel -cluster

2023-02-20 Thread via GitHub
john8628 commented on issue #4154: URL: https://github.com/apache/incubator-seatunnel/issues/4154#issuecomment-1436532724 change the member-server-socket-endpoint-config: port can solve this problem -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-seatunnel] ashulin opened a new pull request, #4169: [improve][factory] Support for creating multi-table sources

2023-02-20 Thread via GitHub
ashulin opened a new pull request, #4169: URL: https://github.com/apache/incubator-seatunnel/pull/4169 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar binary p

[GitHub] [incubator-seatunnel] ashulin opened a new pull request, #4168: [improve][catalog][jdbc] Add MySQL catalog factory

2023-02-20 Thread via GitHub
ashulin opened a new pull request, #4168: URL: https://github.com/apache/incubator-seatunnel/pull/4168 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar binary p

[GitHub] [incubator-seatunnel] ashulin commented on pull request #4157: [improve][api] Refactoring schema parse

2023-02-20 Thread via GitHub
ashulin commented on PR #4157: URL: https://github.com/apache/incubator-seatunnel/pull/4157#issuecomment-1436519788 @hailin0 @TyrantLucifer PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to