[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module

2023-01-16 Thread GitBox
CalvinKirs commented on code in PR #3947: URL: https://github.com/apache/incubator-seatunnel/pull/3947#discussion_r1071863246 ## tools/dependencies/known-dependencies.txt: ## @@ -50,6 +50,7 @@ protostuff-runtime-1.8.0.jar scala-library-2.11.12.jar seatunnel-config-base-2.1.1.

[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module

2023-01-16 Thread GitBox
TyrantLucifer commented on code in PR #3947: URL: https://github.com/apache/incubator-seatunnel/pull/3947#discussion_r1071861889 ## tools/dependencies/known-dependencies.txt: ## @@ -50,6 +50,7 @@ protostuff-runtime-1.8.0.jar scala-library-2.11.12.jar seatunnel-config-base-2.1

[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module

2023-01-16 Thread GitBox
TyrantLucifer commented on code in PR #3947: URL: https://github.com/apache/incubator-seatunnel/pull/3947#discussion_r1071861889 ## tools/dependencies/known-dependencies.txt: ## @@ -50,6 +50,7 @@ protostuff-runtime-1.8.0.jar scala-library-2.11.12.jar seatunnel-config-base-2.1

[GitHub] [incubator-seatunnel] zy-kkk commented on pull request #3958: [Feature][Connector-V2][SelectDB Cloud] Support SelectDB Cloud Sink Connector

2023-01-16 Thread GitBox
zy-kkk commented on PR #3958: URL: https://github.com/apache/incubator-seatunnel/pull/3958#issuecomment-1384962202 > Please add e2e testcase module > > references https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-doris-e2e htt

[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module

2023-01-16 Thread GitBox
CalvinKirs commented on code in PR #3947: URL: https://github.com/apache/incubator-seatunnel/pull/3947#discussion_r1071860519 ## tools/dependencies/known-dependencies.txt: ## @@ -50,6 +50,7 @@ protostuff-runtime-1.8.0.jar scala-library-2.11.12.jar seatunnel-config-base-2.1.1.

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module

2023-01-16 Thread GitBox
CalvinKirs commented on PR #3947: URL: https://github.com/apache/incubator-seatunnel/pull/3947#issuecomment-1384957045 > should we put all shade jars in this? github.com/apache/incubator-seatunnel-shade @EricJoy2048↳ waiting for the first release. -- This is an automated message f

[GitHub] [incubator-seatunnel] zy-kkk commented on a diff in pull request #3958: [Feature][Connector-V2][SelectDB Cloud] Support SelectDB Cloud Sink Connector

2023-01-16 Thread GitBox
zy-kkk commented on code in PR #3958: URL: https://github.com/apache/incubator-seatunnel/pull/3958#discussion_r1071857763 ## seatunnel-connectors-v2/connector-selectdb-cloud/src/main/java/org/apache/seatunnel/connector/selectdb/sink/writer/SelectDBCopyInto.java: ## @@ -0,0 +1,2

[GitHub] [incubator-seatunnel] zy-kkk commented on a diff in pull request #3958: [Feature][Connector-V2][SelectDB Cloud] Support SelectDB Cloud Sink Connector

2023-01-16 Thread GitBox
zy-kkk commented on code in PR #3958: URL: https://github.com/apache/incubator-seatunnel/pull/3958#discussion_r1071856656 ## seatunnel-connectors-v2/connector-selectdb-cloud/src/main/java/org/apache/seatunnel/connector/selectdb/sink/committer/SelectDBCommitter.java: ## @@ -0,0

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #3894: [Bug] [Maxcompute] Failed to parse some maxcompute type

2023-01-16 Thread GitBox
CalvinKirs commented on PR #3894: URL: https://github.com/apache/incubator-seatunnel/pull/3894#issuecomment-1384955233 > > Can you help to add MaxCompute E2E, if so will be very helpful.↳ > > @Hisoka-X I'm happy to complete it, but maxcompute is a commercial product of Alibaba Cloud.

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module

2023-01-16 Thread GitBox
TyrantLucifer commented on PR #3947: URL: https://github.com/apache/incubator-seatunnel/pull/3947#issuecomment-1384948836 > should we put all shade jars in this? github.com/apache/incubator-seatunnel-shade @EricJoy2048 Yup, all shade dependencies shoule be moved to this repository. B

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module

2023-01-16 Thread GitBox
CalvinKirs commented on PR #3947: URL: https://github.com/apache/incubator-seatunnel/pull/3947#issuecomment-1384945250 should we put all shade jars in this? github.com/apache/incubator-seatunnel-shade @EricJoy2048 -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3896: [Improve][SourceConnector] Unified schema parameter, update IoTDB sou…

2023-01-16 Thread GitBox
TyrantLucifer commented on PR #3896: URL: https://github.com/apache/incubator-seatunnel/pull/3896#issuecomment-1384944790 > > LGTM, thank you for your contirbution. Looking forward your next pull request! BTW, before this pr be merged CI should be passed. Let's waiting CI. cc @hailin0 @His

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #3896: [Improve][SourceConnector] Unified schema parameter, update IoTDB sou…

2023-01-16 Thread GitBox
CalvinKirs commented on PR #3896: URL: https://github.com/apache/incubator-seatunnel/pull/3896#issuecomment-1384942214 > LGTM, thank you for your contirbution. Looking forward your next pull request! BTW, before this pr be merged CI should be passed. Let's waiting CI. cc @hailin0 @Hisoka-X

[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2865: [Imporve][Connector-V2] Imporve iceberg source connector

2023-01-16 Thread GitBox
CalvinKirs commented on code in PR #2865: URL: https://github.com/apache/incubator-seatunnel/pull/2865#discussion_r1071821130 ## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-iceberg-hadoop3-e2e/src/test/java/org/apache/seatunnel/e2e/connector/iceberg/hadoop3/IcebergSourceIT.java:

[GitHub] [incubator-seatunnel] sunnyzhu92 commented on a diff in pull request #3896: [Improve][SourceConnector] Unified schema parameter, update IoTDB sou…

2023-01-16 Thread GitBox
sunnyzhu92 commented on code in PR #3896: URL: https://github.com/apache/incubator-seatunnel/pull/3896#discussion_r1071816091 ## seatunnel-connectors-v2/connector-iotdb/src/main/java/org/apache/seatunnel/connectors/seatunnel/iotdb/source/IoTDBSource.java: ## @@ -65,21 +65,29 @@

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2739: druid connector support auth and keyword column(eg:interval)

2023-01-16 Thread GitBox
CalvinKirs commented on PR #2739: URL: https://github.com/apache/incubator-seatunnel/pull/2739#issuecomment-1384921093 hi, thanks for your contribution, dev branch will no longer maintain the V1 version of the connector, so I will close this PR, If you are interested in this, you can con

[GitHub] [incubator-seatunnel] CalvinKirs closed pull request #2739: druid connector support auth and keyword column(eg:interval)

2023-01-16 Thread GitBox
CalvinKirs closed pull request #2739: druid connector support auth and keyword column(eg:interval) URL: https://github.com/apache/incubator-seatunnel/pull/2739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-seatunnel] branch dev updated: [Improve][SourceConnector] Unifie InfluxDB source fields to schema (#3897)

2023-01-16 Thread gaojun2048
This is an automated email from the ASF dual-hosted git repository. gaojun2048 pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 85a984a64 [Improve][SourceConnector]

[GitHub] [incubator-seatunnel] EricJoy2048 closed issue #3821: [Improve][SourceConnector] Unified schema parameter, update InfluxDB Source fields to schema

2023-01-16 Thread GitBox
EricJoy2048 closed issue #3821: [Improve][SourceConnector] Unified schema parameter, update InfluxDB Source fields to schema URL: https://github.com/apache/incubator-seatunnel/issues/3821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-seatunnel] EricJoy2048 merged pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema

2023-01-16 Thread GitBox
EricJoy2048 merged PR #3897: URL: https://github.com/apache/incubator-seatunnel/pull/3897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-seatunnel] dependabot[bot] commented on pull request #2732: Bump commons-compress from 1.20 to 1.21

2023-01-16 Thread GitBox
dependabot[bot] commented on PR #2732: URL: https://github.com/apache/incubator-seatunnel/pull/2732#issuecomment-1384919757 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [incubator-seatunnel] CalvinKirs closed pull request #2732: Bump commons-compress from 1.20 to 1.21

2023-01-16 Thread GitBox
CalvinKirs closed pull request #2732: Bump commons-compress from 1.20 to 1.21 URL: https://github.com/apache/incubator-seatunnel/pull/2732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-seatunnel] CalvinKirs closed pull request #2906: [Improve][flink][Connector-V1] Improve druid and doris connector

2023-01-16 Thread GitBox
CalvinKirs closed pull request #2906: [Improve][flink][Connector-V1] Improve druid and doris connector URL: https://github.com/apache/incubator-seatunnel/pull/2906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2906: [Improve][flink][Connector-V1] Improve druid and doris connector

2023-01-16 Thread GitBox
CalvinKirs commented on PR #2906: URL: https://github.com/apache/incubator-seatunnel/pull/2906#issuecomment-1384919360 hi, thanks for your contribution, dev branch will no longer maintain the V1 version of the connector, so I will close this PR, If you are interested in this, you can con

[GitHub] [incubator-seatunnel] CalvinKirs closed pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

2023-01-16 Thread GitBox
CalvinKirs closed pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded URL: https://github.com/apache/incubator-seatunnel/pull/2705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2705: [Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

2023-01-16 Thread GitBox
CalvinKirs commented on PR #2705: URL: https://github.com/apache/incubator-seatunnel/pull/2705#issuecomment-1384918873 hi, thanks for your contribution, dev branch will no longer maintain the V1 version of the connector, so I will close this PR, If you are interested in this, you can con

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3963: [Feature][Core][Flink] Upgrade flink version to 1.14.6

2023-01-16 Thread GitBox
TyrantLucifer commented on PR #3963: URL: https://github.com/apache/incubator-seatunnel/pull/3963#issuecomment-1384902980 > add to release-note. Done, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [incubator-seatunnel] lightzhao commented on pull request #3904: [Bug][seatunnel-flink-starter]Fix NPE when starting from checkpoint.

2023-01-16 Thread GitBox
lightzhao commented on PR #3904: URL: https://github.com/apache/incubator-seatunnel/pull/3904#issuecomment-1384897201 @EricJoy2048 @TyrantLucifer @Hisoka-X @ashulin PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-seatunnel] lightzhao closed pull request #3906: [Improve][connector-v2][HdfsFileSink]Delete temporary files not caused by checkpoint.

2023-01-16 Thread GitBox
lightzhao closed pull request #3906: [Improve][connector-v2][HdfsFileSink]Delete temporary files not caused by checkpoint. URL: https://github.com/apache/incubator-seatunnel/pull/3906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-seatunnel] liugddx commented on pull request #3963: [Feature][Core][Flink] Upgrade flink version to 1.14.6

2023-01-16 Thread GitBox
liugddx commented on PR #3963: URL: https://github.com/apache/incubator-seatunnel/pull/3963#issuecomment-1384890613 add to release-note. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [incubator-seatunnel] ChangjunZhang closed pull request #3943: [Improve][Connector-V2][Console] Improve console connector sink output format #3737

2023-01-16 Thread GitBox
ChangjunZhang closed pull request #3943: [Improve][Connector-V2][Console] Improve console connector sink output format #3737 URL: https://github.com/apache/incubator-seatunnel/pull/3943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #3946: [Feature][Zeta] Add Zeta Client ShutdownHook To Cancel Job

2023-01-16 Thread GitBox
liugddx commented on code in PR #3946: URL: https://github.com/apache/incubator-seatunnel/pull/3946#discussion_r1071780439 ## seatunnel-core/seatunnel-starter/src/main/java/org/apache/seatunnel/core/starter/seatunnel/command/ClientExecuteCommand.java: ## @@ -112,14 +116,24 @@ p

[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #3896: [Improve][SourceConnector] Unified schema parameter, update IoTDB sou…

2023-01-16 Thread GitBox
TyrantLucifer commented on code in PR #3896: URL: https://github.com/apache/incubator-seatunnel/pull/3896#discussion_r1071750702 ## seatunnel-connectors-v2/connector-iotdb/src/main/java/org/apache/seatunnel/connectors/seatunnel/iotdb/source/IoTDBSource.java: ## @@ -65,21 +65,29

[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #3896: [Improve][SourceConnector] Unified schema parameter, update IoTDB sou…

2023-01-16 Thread GitBox
TyrantLucifer commented on code in PR #3896: URL: https://github.com/apache/incubator-seatunnel/pull/3896#discussion_r1071750702 ## seatunnel-connectors-v2/connector-iotdb/src/main/java/org/apache/seatunnel/connectors/seatunnel/iotdb/source/IoTDBSource.java: ## @@ -65,21 +65,29

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema

2023-01-16 Thread GitBox
TyrantLucifer commented on PR #3897: URL: https://github.com/apache/incubator-seatunnel/pull/3897#issuecomment-1384881231 Let's waiting CI process. Thanks, if CI passed this pull request can be merged. -- This is an automated message from the Apache Git Service. To respond to the message

[incubator-seatunnel] branch dev updated: [Improve][Connector-V2][Hive] Improve config check logic (#3886)

2023-01-16 Thread tyrantlucifer
This is an automated email from the ASF dual-hosted git repository. tyrantlucifer pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new b4348f6f4 [Improve][Connector-V2][

[GitHub] [incubator-seatunnel] TyrantLucifer merged pull request #3886: [Improve][HiveSink]Fix Partition loading failed.

2023-01-16 Thread GitBox
TyrantLucifer merged PR #3886: URL: https://github.com/apache/incubator-seatunnel/pull/3886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #3946: [Feature][Zeta] Add Zeta Client ShutdownHook To Cancel Job

2023-01-16 Thread GitBox
Hisoka-X commented on code in PR #3946: URL: https://github.com/apache/incubator-seatunnel/pull/3946#discussion_r1071771488 ## seatunnel-core/seatunnel-starter/src/main/java/org/apache/seatunnel/core/starter/seatunnel/command/ClientExecuteCommand.java: ## @@ -112,14 +116,24 @@

[incubator-seatunnel] branch dev updated (a9dc531bf -> e23da00e5)

2023-01-16 Thread ic4y
This is an automated email from the ASF dual-hosted git repository. ic4y pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git from a9dc531bf [Improve] [E2E] Rename test case name and increase timeout. (#3935) add e23da00e5 [BugFix] [Ze

[GitHub] [incubator-seatunnel] ic4y closed issue #3914: [Bug] [Zeta] A checkpoint exception may be thrown when the active cancel task terminates with an exception

2023-01-16 Thread GitBox
ic4y closed issue #3914: [Bug] [Zeta] A checkpoint exception may be thrown when the active cancel task terminates with an exception URL: https://github.com/apache/incubator-seatunnel/issues/3914 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-seatunnel] ic4y merged pull request #3915: [BugFix] [Zeta] A checkpoint exception may be thrown when the active cancel task terminates with an exception

2023-01-16 Thread GitBox
ic4y merged PR #3915: URL: https://github.com/apache/incubator-seatunnel/pull/3915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@s

[GitHub] [incubator-seatunnel] liugddx commented on pull request #3946: [Feature][Zeta] Add Zeta Client ShutdownHook To Cancel Job

2023-01-16 Thread GitBox
liugddx commented on PR #3946: URL: https://github.com/apache/incubator-seatunnel/pull/3946#issuecomment-1384875634 @EricJoy2048 @Hisoka-X PTAL . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[incubator-seatunnel] branch dev updated (f4e81a3bb -> a9dc531bf)

2023-01-16 Thread liugddx
This is an automated email from the ASF dual-hosted git repository. liugddx pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git from f4e81a3bb [Improve][E2E] Add a 'nonNull' check to avoid npe when executing 'tearDown'. (#3967) add a9

[GitHub] [incubator-seatunnel] liugddx closed issue #3934: [Improve] [E2E] Improve e2e case

2023-01-16 Thread GitBox
liugddx closed issue #3934: [Improve] [E2E] Improve e2e case URL: https://github.com/apache/incubator-seatunnel/issues/3934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [incubator-seatunnel] liugddx merged pull request #3935: [Improve] [E2E] Rename test case name and increase timeout.

2023-01-16 Thread GitBox
liugddx merged PR #3935: URL: https://github.com/apache/incubator-seatunnel/pull/3935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema

2023-01-16 Thread GitBox
liugddx commented on code in PR #3897: URL: https://github.com/apache/incubator-seatunnel/pull/3897#discussion_r1071767538 ## docs/en/connector-v2/source/InfluxDB.md: ## @@ -51,19 +51,20 @@ The query sql used to search data select name,age from test ``` -### fields [string]

[GitHub] [incubator-seatunnel] wfrong commented on a diff in pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema

2023-01-16 Thread GitBox
wfrong commented on code in PR #3897: URL: https://github.com/apache/incubator-seatunnel/pull/3897#discussion_r1071766440 ## docs/en/connector-v2/source/InfluxDB.md: ## @@ -51,19 +51,20 @@ The query sql used to search data select name,age from test ``` -### fields [string]

[GitHub] [incubator-seatunnel] liugddx commented on pull request #3847: [Improve][Seatunnel-Engine]change queue to disruptor

2023-01-16 Thread GitBox
liugddx commented on PR #3847: URL: https://github.com/apache/incubator-seatunnel/pull/3847#issuecomment-1384863970 @Hisoka-X @EricJoy2048 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[incubator-seatunnel] branch dev updated: [Improve][E2E] Add a 'nonNull' check to avoid npe when executing 'tearDown'. (#3967)

2023-01-16 Thread liugddx
This is an automated email from the ASF dual-hosted git repository. liugddx pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new f4e81a3bb [Improve][E2E] Add a 'nonNull'

[GitHub] [incubator-seatunnel] liugddx merged pull request #3967: [Improve][E2E] Add a 'nonNull' check to avoid npe when executing 'tearDown'.

2023-01-16 Thread GitBox
liugddx merged PR #3967: URL: https://github.com/apache/incubator-seatunnel/pull/3967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [incubator-seatunnel] TyrantLucifer closed pull request #3468: [WIP][Feature][Flink] Upgrade flink to 1.14.6

2023-01-16 Thread GitBox
TyrantLucifer closed pull request #3468: [WIP][Feature][Flink] Upgrade flink to 1.14.6 URL: https://github.com/apache/incubator-seatunnel/pull/3468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3468: [WIP][Feature][Flink] Upgrade flink to 1.14.6

2023-01-16 Thread GitBox
TyrantLucifer commented on PR #3468: URL: https://github.com/apache/incubator-seatunnel/pull/3468#issuecomment-1384855156 Because of #3963, this pull request will be closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-seatunnel] hailin0 commented on pull request #3958: [Feature][Connector-V2][SelectDB Cloud] Support SelectDB Cloud Sink Connector

2023-01-16 Thread GitBox
hailin0 commented on PR #3958: URL: https://github.com/apache/incubator-seatunnel/pull/3958#issuecomment-1384854299 Please add e2e testcase references https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-doris-e2e https://gi

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module

2023-01-16 Thread GitBox
TyrantLucifer commented on PR #3947: URL: https://github.com/apache/incubator-seatunnel/pull/3947#issuecomment-1384853761 @EricJoy2048 @ashulin PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #3896: [Improve][SourceConnector] Unified schema parameter, update IoTDB sou…

2023-01-16 Thread GitBox
TyrantLucifer commented on code in PR #3896: URL: https://github.com/apache/incubator-seatunnel/pull/3896#discussion_r1071750702 ## seatunnel-connectors-v2/connector-iotdb/src/main/java/org/apache/seatunnel/connectors/seatunnel/iotdb/source/IoTDBSource.java: ## @@ -65,21 +65,29

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3886: [Improve][HiveSink]Fix Partition loading failed.

2023-01-16 Thread GitBox
TyrantLucifer commented on PR #3886: URL: https://github.com/apache/incubator-seatunnel/pull/3886#issuecomment-1384844615 cc @Hisoka-X -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [incubator-seatunnel] lightzhao commented on pull request #3886: [Improve][HiveSink]Fix Partition loading failed.

2023-01-16 Thread GitBox
lightzhao commented on PR #3886: URL: https://github.com/apache/incubator-seatunnel/pull/3886#issuecomment-1384815100 > > > If does not have a partition name can't be loaded, why we should allow it? Maybe check `partition_name_expression` before execute job could be better way. > >

[GitHub] [incubator-seatunnel] FlechazoW commented on pull request #3967: [Improve][E2E] Add a 'nonNull' check to avoid npe when executing 'tearDown'.

2023-01-16 Thread GitBox
FlechazoW commented on PR #3967: URL: https://github.com/apache/incubator-seatunnel/pull/3967#issuecomment-1384801802 > Hi, please fix code style, thanks. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3967: [Improve][E2E] Add a 'nonNull' check to avoid npe when executing 'tearDown'.

2023-01-16 Thread GitBox
Hisoka-X commented on PR #3967: URL: https://github.com/apache/incubator-seatunnel/pull/3967#issuecomment-1384798557 Hi, please fix code style, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-seatunnel] FlechazoW opened a new pull request, #3967: [Improve][E2E] Add a 'nonNull' check to avoid npe when executing 'tearDown'.

2023-01-16 Thread GitBox
FlechazoW opened a new pull request, #3967: URL: https://github.com/apache/incubator-seatunnel/pull/3967 ## Purpose of this pull request Add a 'nonNull' check to avoid npe when executing 'tearDown'. https://user-images.githubusercontent.com/35768015/2

[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3945: [Bug][Connector-v2][HdfsSink]Fix data loss caused by commit failure.

2023-01-16 Thread GitBox
Hisoka-X commented on PR #3945: URL: https://github.com/apache/incubator-seatunnel/pull/3945#issuecomment-1384789857 Hi, this is a problem we should faced, in two phase commit, we think the second phase always should success, if we abort it, the two phase commit can't make sure exactly-onc

[GitHub] [incubator-seatunnel] TyrantLucifer commented on issue #3942: [OnlineMeeting&Jan.17]SeaTunnel community meeting Topic collect

2023-01-16 Thread GitBox
TyrantLucifer commented on issue #3942: URL: https://github.com/apache/incubator-seatunnel/issues/3942#issuecomment-1384789250 #3964 Upgrade flink version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-seatunnel] branch dev updated (8e2e796cb -> 344726642)

2023-01-16 Thread tyrantlucifer
This is an automated email from the ASF dual-hosted git repository. tyrantlucifer pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git from 8e2e796cb [hotfix][api] Temporary cancel validate duplicate logic (#3962) add 344726642 [Hotfix

[GitHub] [incubator-seatunnel] TyrantLucifer merged pull request #3836: [Bug][KafkaSource]KafkaConsumer is not close.

2023-01-16 Thread GitBox
TyrantLucifer merged PR #3836: URL: https://github.com/apache/incubator-seatunnel/pull/3836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3886: [Improve][HiveSink]Fix Partition loading failed.

2023-01-16 Thread GitBox
Hisoka-X commented on PR #3886: URL: https://github.com/apache/incubator-seatunnel/pull/3886#issuecomment-1384785894 > > If does not have a partition name can't be loaded, why we should allow it? Maybe check `partition_name_expression` before execute job could be better way. > > ok,

[GitHub] [incubator-seatunnel] liugddx commented on issue #3964: [Umbrella][Feature][Core] Support flink 1.15.x and 1.16.x

2023-01-16 Thread GitBox
liugddx commented on issue #3964: URL: https://github.com/apache/incubator-seatunnel/issues/3964#issuecomment-1384783973 #3263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [incubator-seatunnel] lightzhao commented on pull request #3886: [Improve][HiveSink]Fix Partition loading failed.

2023-01-16 Thread GitBox
lightzhao commented on PR #3886: URL: https://github.com/apache/incubator-seatunnel/pull/3886#issuecomment-1384781186 > If does not have a partition name can't be loaded, why we should allow it? Maybe check `partition_name_expression` before execute job could be better way. ok, If it

[GitHub] [incubator-seatunnel] TyrantLucifer opened a new issue, #3964: [Umbrella][Feature][Core] Support flink 1.15.x and 1.16.x

2023-01-16 Thread GitBox
TyrantLucifer opened a new issue, #3964: URL: https://github.com/apache/incubator-seatunnel/issues/3964 ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) ### Search before asking - [X] I h

[GitHub] [incubator-seatunnel] liugddx commented on pull request #3963: [Feature][Core][Flink] Upgrade flink version to 1.14.6

2023-01-16 Thread GitBox
liugddx commented on PR #3963: URL: https://github.com/apache/incubator-seatunnel/pull/3963#issuecomment-1384780714 > > This approach may not be appropriate. If subsequent flink changes the api, the coupling may be relatively large. > > For flink 1.15 and 1.16 I will develop new star

[GitHub] [incubator-seatunnel] lightzhao commented on pull request #3836: [Bug][KafkaSource]KafkaConsumer is not close.

2023-01-16 Thread GitBox
lightzhao commented on PR #3836: URL: https://github.com/apache/incubator-seatunnel/pull/3836#issuecomment-1384780021 @Hisoka-X @TyrantLucifer PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3963: [Feature][Core][Flink] Upgrade flink version to 1.14.6

2023-01-16 Thread GitBox
TyrantLucifer commented on PR #3963: URL: https://github.com/apache/incubator-seatunnel/pull/3963#issuecomment-1384778113 > This approach may not be appropriate. If subsequent flink changes the api, the coupling may be relatively large. > > For flink 1.15 and 1.16 I will deve

[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema

2023-01-16 Thread GitBox
liugddx commented on code in PR #3897: URL: https://github.com/apache/incubator-seatunnel/pull/3897#discussion_r1071696563 ## docs/en/connector-v2/source/InfluxDB.md: ## @@ -51,19 +51,20 @@ The query sql used to search data select name,age from test ``` -### fields [string]

[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema

2023-01-16 Thread GitBox
liugddx commented on code in PR #3897: URL: https://github.com/apache/incubator-seatunnel/pull/3897#discussion_r1071696113 ## docs/en/connector-v2/source/InfluxDB.md: ## @@ -51,19 +51,20 @@ The query sql used to search data select name,age from test ``` -### fields [string]

[GitHub] [incubator-seatunnel] wfrong commented on a diff in pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema

2023-01-16 Thread GitBox
wfrong commented on code in PR #3897: URL: https://github.com/apache/incubator-seatunnel/pull/3897#discussion_r1071695478 ## docs/en/connector-v2/source/InfluxDB.md: ## @@ -51,19 +51,20 @@ The query sql used to search data select name,age from test ``` -### fields [string]

[GitHub] [incubator-seatunnel] liugddx commented on pull request #3963: [Feature][Core][Flink] Upgrade flink version to 1.14.6

2023-01-16 Thread GitBox
liugddx commented on PR #3963: URL: https://github.com/apache/incubator-seatunnel/pull/3963#issuecomment-1384773993 This approach may not be appropriate. If subsequent flink changes the api, the coupling may be relatively large. -- This is an automated message from the Apache Git Ser

[GitHub] [incubator-seatunnel] TyrantLucifer opened a new pull request, #3963: [Feature][Core][Flink] Upgrade flink version to 1.14.6

2023-01-16 Thread GitBox
TyrantLucifer opened a new pull request, #3963: URL: https://github.com/apache/incubator-seatunnel/pull/3963 ## Purpose of this pull request close #3263 ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [

[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #3946: [Feature][Zeta] Add Zeta Client ShutdownHook To Cancel Job

2023-01-16 Thread GitBox
Hisoka-X commented on code in PR #3946: URL: https://github.com/apache/incubator-seatunnel/pull/3946#discussion_r1071677578 ## seatunnel-core/seatunnel-starter/src/main/java/org/apache/seatunnel/core/starter/seatunnel/command/ClientExecuteCommand.java: ## @@ -112,14 +114,18 @@

[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module

2023-01-16 Thread GitBox
TyrantLucifer commented on code in PR #3947: URL: https://github.com/apache/incubator-seatunnel/pull/3947#discussion_r1071676286 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/util/OptionRule.java: ## @@ -195,8 +195,9 @@ public Builder conditional(@NonNu

[incubator-seatunnel] branch dev updated (7a9cd574f -> 8e2e796cb)

2023-01-16 Thread zongwen
This is an automated email from the ASF dual-hosted git repository. zongwen pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git from 7a9cd574f add imap factory (#3792) add 8e2e796cb [hotfix][api] Temporary cancel validate duplicate log

[GitHub] [incubator-seatunnel] ashulin merged pull request #3962: [Hotfix][Core][Option] Temporary cancel validate duplicate logic

2023-01-16 Thread GitBox
ashulin merged PR #3962: URL: https://github.com/apache/incubator-seatunnel/pull/3962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [incubator-seatunnel] EricJoy2048 closed pull request #3946: [Feature][Zeta] Add Zeta Client ShutdownHook To Cancel Job

2023-01-16 Thread GitBox
EricJoy2048 closed pull request #3946: [Feature][Zeta] Add Zeta Client ShutdownHook To Cancel Job URL: https://github.com/apache/incubator-seatunnel/pull/3946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3894: [Bug] [Maxcompute] Failed to parse some maxcompute type

2023-01-16 Thread GitBox
Hisoka-X commented on PR #3894: URL: https://github.com/apache/incubator-seatunnel/pull/3894#issuecomment-1384744874 > > Can you help to add MaxCompute E2E, if so will be very helpful. > > @Hisoka-X I'm happy to complete it, but maxcompute is a commercial product of Alibaba Cloud. I

[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #3947: [Feature][shade][Jackson] Add seatunnel-jackson module

2023-01-16 Thread GitBox
ashulin commented on code in PR #3947: URL: https://github.com/apache/incubator-seatunnel/pull/3947#discussion_r1071674542 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/configuration/util/OptionRule.java: ## @@ -195,8 +195,9 @@ public Builder conditional(@NonNull Opt

[GitHub] [incubator-seatunnel] hailin0 closed pull request #3938: [Improve][PluginDiscovery] Move code into seatunnel-core-starter module

2023-01-16 Thread GitBox
hailin0 closed pull request #3938: [Improve][PluginDiscovery] Move code into seatunnel-core-starter module URL: https://github.com/apache/incubator-seatunnel/pull/3938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [incubator-seatunnel] stdnt-xiao commented on pull request #3894: [Bug] [Maxcompute] Failed to parse some maxcompute type

2023-01-16 Thread GitBox
stdnt-xiao commented on PR #3894: URL: https://github.com/apache/incubator-seatunnel/pull/3894#issuecomment-1384696810 > Can you help to add MaxCompute E2E, if so will be very helpful. > > 你能帮助添加最大计算 E2E,如果这样将非常有帮助。 > Can you help to add MaxCompute E2E, if so will be ve

[GitHub] [incubator-seatunnel] github-actions[bot] commented on issue #3729: [Feature][SeaTunnel-engine][checkpoint-storage] add oss support for checkpoint storage

2023-01-16 Thread GitBox
github-actions[bot] commented on issue #3729: URL: https://github.com/apache/incubator-seatunnel/issues/3729#issuecomment-1384694253 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity

[GitHub] [incubator-seatunnel] github-actions[bot] commented on issue #2912: [Feature][Discuss] Uniform parameters are available for multiple engines

2023-01-16 Thread GitBox
github-actions[bot] commented on issue #2912: URL: https://github.com/apache/incubator-seatunnel/issues/2912#issuecomment-1384694285 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity

[GitHub] [incubator-seatunnel] github-actions[bot] commented on issue #3737: [Improve][Connector-V2][Console] Improve console connector sink output format

2023-01-16 Thread GitBox
github-actions[bot] commented on issue #3737: URL: https://github.com/apache/incubator-seatunnel/issues/3737#issuecomment-1384694241 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity

[GitHub] [incubator-seatunnel] github-actions[bot] commented on issue #3747: [Bug] [Transform-UDF] Seatunnel 2.3.0-beta version, does v2 not support udf?

2023-01-16 Thread GitBox
github-actions[bot] commented on issue #3747: URL: https://github.com/apache/incubator-seatunnel/issues/3747#issuecomment-1384694213 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3962: [Hotfix][Core][Option] Temporary cancel validate duplicate logic

2023-01-16 Thread GitBox
TyrantLucifer commented on PR #3962: URL: https://github.com/apache/incubator-seatunnel/pull/3962#issuecomment-1384238664 @EricJoy2048 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [incubator-seatunnel] TyrantLucifer opened a new pull request, #3962: [Hotfix][Core][Option] Temporary cancel validate duplicate logic

2023-01-16 Thread GitBox
TyrantLucifer opened a new pull request, #3962: URL: https://github.com/apache/incubator-seatunnel/pull/3962 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar bi

[incubator-seatunnel] branch dev updated: add imap factory (#3792)

2023-01-16 Thread liugddx
This is an automated email from the ASF dual-hosted git repository. liugddx pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 7a9cd574f add imap factory (#3792) 7a9cd

[GitHub] [incubator-seatunnel] liugddx merged pull request #3792: [Improve][ST-Engine] [Imap-storage]improve: add imap factory

2023-01-16 Thread GitBox
liugddx merged PR #3792: URL: https://github.com/apache/incubator-seatunnel/pull/3792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [incubator-seatunnel] liugddx commented on pull request #3946: [Feature][Zeta] Add Zeta Client ShutdownHook To Cancel Job

2023-01-16 Thread GitBox
liugddx commented on PR #3946: URL: https://github.com/apache/incubator-seatunnel/pull/3946#issuecomment-1384162958 > Please add change log to `release note` Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #3896: [Improve][SourceConnector] Unified schema parameter, update IoTDB sou…

2023-01-16 Thread GitBox
TyrantLucifer commented on code in PR #3896: URL: https://github.com/apache/incubator-seatunnel/pull/3896#discussion_r1071303288 ## seatunnel-connectors-v2/connector-iotdb/src/main/java/org/apache/seatunnel/connectors/seatunnel/iotdb/source/IoTDBSource.java: ## @@ -77,8 +77,13

[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #3896: [Improve][SourceConnector] Unified schema parameter, update IoTDB sou…

2023-01-16 Thread GitBox
TyrantLucifer commented on code in PR #3896: URL: https://github.com/apache/incubator-seatunnel/pull/3896#discussion_r1071303288 ## seatunnel-connectors-v2/connector-iotdb/src/main/java/org/apache/seatunnel/connectors/seatunnel/iotdb/source/IoTDBSource.java: ## @@ -77,8 +77,13

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3897: [Improve][SourceConnector] Unifie InfluxDB source fields to schema

2023-01-16 Thread GitBox
TyrantLucifer commented on PR #3897: URL: https://github.com/apache/incubator-seatunnel/pull/3897#issuecomment-1384137584 #3896 is duplicate with this. In chronological order #3896 is valid, could you please try another task? @wfrong -- This is an automated message from the Apache Git S

[incubator-seatunnel] branch dev updated: [Hotfix][Docs] Fix dead link (#3961)

2023-01-16 Thread gaojun2048
This is an automated email from the ASF dual-hosted git repository. gaojun2048 pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 10e7b452a [Hotfix][Docs] Fix dead lin

[GitHub] [incubator-seatunnel] EricJoy2048 merged pull request #3961: [Hotfix][Docs] Fix dead link

2023-01-16 Thread GitBox
EricJoy2048 merged PR #3961: URL: https://github.com/apache/incubator-seatunnel/pull/3961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-seatunnel] TyrantLucifer opened a new pull request, #3961: [Hotfix][Docs] Fix dead link

2023-01-16 Thread GitBox
TyrantLucifer opened a new pull request, #3961: URL: https://github.com/apache/incubator-seatunnel/pull/3961 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new Jar bi

  1   2   >