TyrantLucifer commented on PR #3609:
URL:
https://github.com/apache/incubator-seatunnel/pull/3609#issuecomment-1331748556
Good job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
zhangyongtian closed pull request #3608: [Improve] [core] A little bit of
daydream. The method of overriding t…
URL: https://github.com/apache/incubator-seatunnel/pull/3608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
TyrantLucifer commented on code in PR #3510:
URL:
https://github.com/apache/incubator-seatunnel/pull/3510#discussion_r1035614518
##
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSourceReader.java:
TyrantLucifer commented on issue #3607:
URL:
https://github.com/apache/incubator-seatunnel/issues/3607#issuecomment-1331728571
@MonsterChenzhuo Please comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ic4y commented on code in PR #3598:
URL:
https://github.com/apache/incubator-seatunnel/pull/3598#discussion_r1035583149
##
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/JdbcInputFormat.java:
##
@@ -95,9 +98,9 @@ pub
Solomon-aka-beatsAll opened a new pull request, #3609:
URL: https://github.com/apache/incubator-seatunnel/pull/3609
## Purpose of this pull request
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for
reason:
* [ ] If any new
liugddx commented on issue #2861:
URL:
https://github.com/apache/incubator-seatunnel/issues/2861#issuecomment-1331703746
Yeah, but not all primary keys are numeric and that's something to think
about
Best Regards
liugddx
***@***.***
zhangyongtian opened a new pull request, #3608:
URL: https://github.com/apache/incubator-seatunnel/pull/3608
…he parent class does not write @ Override
## Purpose of this pull request
A little bit of daydream. The method of overriding the parent class does not
write @ Overr
ic4y commented on issue #2861:
URL:
https://github.com/apache/incubator-seatunnel/issues/2861#issuecomment-1331698947
> > > > >
https://shardingsphere.apache.org/document/current/en/dev-manual/sharding/
> > > >
> > > >
> > > > Regarding the jdbc data source, most of the primary k
liugddx commented on PR #3510:
URL:
https://github.com/apache/incubator-seatunnel/pull/3510#issuecomment-1331694635
> > Please pending this pull request. Waiting for #3573 finished and decied
this pull request is or not merged. cc @Hisoka-X @EricJoy2048 @liugddx
>
> Hi, we have commu
liugddx commented on PR #3510:
URL:
https://github.com/apache/incubator-seatunnel/pull/3510#issuecomment-1331694441
> Please pending this pull request. Waiting for #3573 finished and decied
this pull request is or not merged. cc @Hisoka-X @EricJoy2048 @liugddx
Hi, we have communicate
TyrantLucifer commented on PR #3510:
URL:
https://github.com/apache/incubator-seatunnel/pull/3510#issuecomment-1331689771
Please pending this pull request. Waiting for #3573 finished and decied this
pull request is or not merged. cc @Hisoka-X @EricJoy2048 @liugddx
--
This is an automate
TaoZex commented on PR #3586:
URL:
https://github.com/apache/incubator-seatunnel/pull/3586#issuecomment-1331686126
> MySql's IT has been overridden. There is no need to do any IT for any
other MySQL protocol, it doesn't make any sense to us.
Thanks for your suggestion.
--
This is
Hisoka-X commented on issue #2861:
URL:
https://github.com/apache/incubator-seatunnel/issues/2861#issuecomment-1331680534
> > > >
https://shardingsphere.apache.org/document/current/en/dev-manual/sharding/
> > >
> > >
> > > Regarding the jdbc data source, most of the primary keys
CalvinKirs commented on PR #3586:
URL:
https://github.com/apache/incubator-seatunnel/pull/3586#issuecomment-1331679290
MySql's IT has been overridden. There is no need to do any IT for any other
MySQL protocol, it doesn't make any sense to us.
--
This is an automated message from the
Carl-Zhou-CN commented on code in PR #3598:
URL:
https://github.com/apache/incubator-seatunnel/pull/3598#discussion_r1035548475
##
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSinkWriter.java:
##
@@ -85,7 +88,7 @@
MonsterChenzhuo commented on issue #3601:
URL:
https://github.com/apache/incubator-seatunnel/issues/3601#issuecomment-1331669635
Please assgin to me this issue：
[Improve][Connector-V2][MongoDB] Refactor MongoDB connector e2e test cases
[Improve][Connector-V2][Fake] Refactor Fake connec
Carl-Zhou-CN commented on code in PR #3598:
URL:
https://github.com/apache/incubator-seatunnel/pull/3598#discussion_r1035547979
##
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/xa/XaFacadeImplAutoLoad.java:
##
@@ -8
Carl-Zhou-CN commented on code in PR #3598:
URL:
https://github.com/apache/incubator-seatunnel/pull/3598#discussion_r1035547858
##
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcExactlyOnceSinkWriter.java:
##
@@ -171
Carl-Zhou-CN commented on code in PR #3598:
URL:
https://github.com/apache/incubator-seatunnel/pull/3598#discussion_r1035547735
##
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/JdbcInputFormat.java:
##
@@ -95,9 +98,
Carl-Zhou-CN commented on issue #3606:
URL:
https://github.com/apache/incubator-seatunnel/issues/3606#issuecomment-133167
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
liugddx commented on issue #2861:
URL:
https://github.com/apache/incubator-seatunnel/issues/2861#issuecomment-1331666434
> > >
https://shardingsphere.apache.org/document/current/en/dev-manual/sharding/
> >
> >
> > Regarding the jdbc data source, most of the primary keys may be da
TyrantLucifer commented on issue #3606:
URL:
https://github.com/apache/incubator-seatunnel/issues/3606#issuecomment-1331644964
@Carl-Zhou-CN Please comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Carl-Zhou-CN commented on issue #3601:
URL:
https://github.com/apache/incubator-seatunnel/issues/3601#issuecomment-1331643500
I want to try ElasticSearch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
TaoZex closed issue #3604: [Improve][Connector-V2][DataHub] Refactor DataHub
connector e2e test cases
URL: https://github.com/apache/incubator-seatunnel/issues/3604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
TaoZex commented on issue #3605:
URL:
https://github.com/apache/incubator-seatunnel/issues/3605#issuecomment-1331639703
Please assign to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
TyrantLucifer commented on issue #3605:
URL:
https://github.com/apache/incubator-seatunnel/issues/3605#issuecomment-1331639389
@TaoZex Please comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
TaoZex opened a new issue, #3604:
URL: https://github.com/apache/incubator-seatunnel/issues/3604
### Search before asking
- [X] I had searched in the
[feature](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22)
and found no similar feature requir
TaoZex commented on issue #3601:
URL:
https://github.com/apache/incubator-seatunnel/issues/3601#issuecomment-1331638833
Please assgin to me this issue： [Improve][Connector-V2][DataHub] Refactor
DataHub connector e2e test cases
--
This is an automated message from the Apache Git Service.
ic4y commented on code in PR #3598:
URL:
https://github.com/apache/incubator-seatunnel/pull/3598#discussion_r1035510867
##
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/xa/XaFacadeImplAutoLoad.java:
##
@@ -89,18 +92
TyrantLucifer opened a new pull request, #3603:
URL: https://github.com/apache/incubator-seatunnel/pull/3603
## Purpose of this pull request
close #3602
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for
reason:
* [
ic4y commented on code in PR #3598:
URL:
https://github.com/apache/incubator-seatunnel/pull/3598#discussion_r1035503196
##
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/JdbcInputFormat.java:
##
@@ -95,9 +98,9 @@ pub
TyrantLucifer opened a new issue, #3601:
URL: https://github.com/apache/incubator-seatunnel/issues/3601
### Search before asking
- [X] I had searched in the
[feature](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22)
and found no similar feature
ic4y commented on code in PR #3598:
URL:
https://github.com/apache/incubator-seatunnel/pull/3598#discussion_r1035500068
##
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcSinkWriter.java:
##
@@ -85,7 +88,7 @@ public O
TyrantLucifer commented on code in PR #3590:
URL:
https://github.com/apache/incubator-seatunnel/pull/3590#discussion_r1035496024
##
seatunnel-connectors-v2/connector-pulsar/src/main/java/org/apache/seatunnel/connectors/seatunnel/pulsar/exception/PulsarConnectorErrorCode.java:
#
TyrantLucifer commented on issue #3599:
URL:
https://github.com/apache/incubator-seatunnel/issues/3599#issuecomment-1331600912
> > IMO, we didn't need this interface, metadata is a part of data, we
should process it in connectors. The core point of this feature is that how to
define the sc
TyrantLucifer commented on code in PR #3593:
URL:
https://github.com/apache/incubator-seatunnel/pull/3593#discussion_r1035491818
##
seatunnel-connectors-v2/connector-starrocks/src/main/java/org/apache/seatunnel/connectors/seatunnel/starrocks/exception/StarRocksConnectorErrorCode.java:
TyrantLucifer commented on PR #3598:
URL:
https://github.com/apache/incubator-seatunnel/pull/3598#issuecomment-1331596325
@ic4y PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
TyrantLucifer commented on code in PR #3598:
URL:
https://github.com/apache/incubator-seatunnel/pull/3598#discussion_r1035490308
##
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/exception/JdbcConnectorErrorCode.java:
##
@@ -
TyrantLucifer commented on issue #3530:
URL:
https://github.com/apache/incubator-seatunnel/issues/3530#issuecomment-1331594155
closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
TyrantLucifer closed issue #3530: [Improve][Connector-V2][Http] Unified
exception for http source & sink connector
URL: https://github.com/apache/incubator-seatunnel/issues/3530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
TyrantLucifer closed issue #3548: [Improve][Connector-V2][Klaviyo] Unified
exception for Klaviyo connector
URL: https://github.com/apache/incubator-seatunnel/issues/3548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
TyrantLucifer commented on issue #3548:
URL:
https://github.com/apache/incubator-seatunnel/issues/3548#issuecomment-1331593823
closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
Carl-Zhou-CN commented on issue #3599:
URL:
https://github.com/apache/incubator-seatunnel/issues/3599#issuecomment-1331588349
> IMO, we didn't need this interface, metadata is a part of data, we should
process it in connectors. The core point of this feature is that how to define
the schem
Carl-Zhou-CN commented on issue #3599:
URL:
https://github.com/apache/incubator-seatunnel/issues/3599#issuecomment-1331588119
> IMO, we didn't need this interface, metadata is a part of data, we should
process it in connectors. The core point of this feature is that how to define
the schem
Hisoka-X commented on issue #3599:
URL:
https://github.com/apache/incubator-seatunnel/issues/3599#issuecomment-1331585290
> IMO, we didn't need this interface, metadata is a part of data, we should
process it in connectors. The core point of this feature is that how to define
the schema of
This is an automated email from the ASF dual-hosted git repository.
tyrantlucifer pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new 56f3cdb27 [Improve][e2e][JDBC] Add
TyrantLucifer merged PR #3596:
URL: https://github.com/apache/incubator-seatunnel/pull/3596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
This is an automated email from the ASF dual-hosted git repository.
gaojun2048 pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new d798cd867 [Improve][Connector-V2][Htt
EricJoy2048 merged PR #3594:
URL: https://github.com/apache/incubator-seatunnel/pull/3594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
TyrantLucifer commented on issue #3599:
URL:
https://github.com/apache/incubator-seatunnel/issues/3599#issuecomment-1331582325
IMO, we didn't need this interface, metadata is a part of data, we should
process it in connectors. The core point of this feature is that how to define
the schema
Hisoka-X commented on issue #3599:
URL:
https://github.com/apache/incubator-seatunnel/issues/3599#issuecomment-1331579124
> Can we define relevant interfaces for metadata in the schema and implement
each connector accordingly
Yes, we can. I think the main thing is parse schema meta c
Hisoka-X closed issue #2583: [Bug] [kafka-source] Multiple KafkaSource failed
with Only one StreamingContext may be started in this JVM.
URL: https://github.com/apache/incubator-seatunnel/issues/2583
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
Hisoka-X closed issue #2592: [Feature][Metrics] Seatunnel-Metrics
URL: https://github.com/apache/incubator-seatunnel/issues/2592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Hisoka-X commented on issue #2861:
URL:
https://github.com/apache/incubator-seatunnel/issues/2861#issuecomment-1331576060
> >
https://shardingsphere.apache.org/document/current/en/dev-manual/sharding/
>
> Regarding the jdbc data source, most of the primary keys may be data such
as u
Carl-Zhou-CN commented on issue #3599:
URL:
https://github.com/apache/incubator-seatunnel/issues/3599#issuecomment-1331568137
--
This is an automated message from the Apach
Hisoka-X commented on issue #3487:
URL:
https://github.com/apache/incubator-seatunnel/issues/3487#issuecomment-1331561501
I think method 1 can only support replace parameter in env. But not use
`-i`, use `-p` or other. Method 2 is good for replace the placeholder.
--
This is an automated
github-actions[bot] commented on issue #2583:
URL:
https://github.com/apache/incubator-seatunnel/issues/2583#issuecomment-1331490913
This issue has been automatically marked as stale because it has not had
recent activity for 30 days. It will be closed in next 7 days if no further
activity
github-actions[bot] commented on issue #2592:
URL:
https://github.com/apache/incubator-seatunnel/issues/2592#issuecomment-1331490883
This issue has been automatically marked as stale because it has not had
recent activity for 30 days. It will be closed in next 7 days if no further
activity
github-actions[bot] commented on issue #2617:
URL:
https://github.com/apache/incubator-seatunnel/issues/2617#issuecomment-1331490864
This issue has been automatically marked as stale because it has not had
recent activity for 30 days. It will be closed in next 7 days if no further
activity
liugddx opened a new pull request, #3600:
URL: https://github.com/apache/incubator-seatunnel/pull/3600
close #2861
## Purpose of this pull request
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for
reason:
* [ ] If any n
liugddx commented on issue #2861:
URL:
https://github.com/apache/incubator-seatunnel/issues/2861#issuecomment-1330717892
> >
https://shardingsphere.apache.org/document/current/en/dev-manual/sharding/
>
> Regarding the jdbc data source, most of the primary keys may be data such
as uu
liugddx commented on issue #2861:
URL:
https://github.com/apache/incubator-seatunnel/issues/2861#issuecomment-1330716955
> https://shardingsphere.apache.org/document/current/en/dev-manual/sharding/
Regarding the jdbc data source, most of the primary keys may be data such as
uuid. We
liugddx commented on issue #2861:
URL:
https://github.com/apache/incubator-seatunnel/issues/2861#issuecomment-1330713458
https://shardingsphere.apache.org/document/current/en/dev-manual/sharding/
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
john8628 commented on PR #3593:
URL:
https://github.com/apache/incubator-seatunnel/pull/3593#issuecomment-1330692676
>
>
https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/setup.md#install-jetbrains-idea-checkstyle-idea-plugin
>
> Please chang
TaoZex commented on PR #3593:
URL:
https://github.com/apache/incubator-seatunnel/pull/3593#issuecomment-1330676269
https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/setup.md#install-jetbrains-idea-checkstyle-idea-plugin
Please change your code style through
john8628 commented on code in PR #3590:
URL:
https://github.com/apache/incubator-seatunnel/pull/3590#discussion_r1034732964
##
seatunnel-connectors-v2/connector-pulsar/src/main/java/org/apache/seatunnel/connectors/seatunnel/pulsar/source/enumerator/PulsarSplitEnumerator.java:
#
liugddx commented on issue #3487:
URL:
https://github.com/apache/incubator-seatunnel/issues/3487#issuecomment-1330618731
> > Do we now use command line parameters to directly replace the parameters
in config or use placeholder replacement in config?
> >
> > 1. direct replacement
>
liugddx commented on issue #3487:
URL:
https://github.com/apache/incubator-seatunnel/issues/3487#issuecomment-1330617652
> Do we now use command line parameters to directly replace the parameters
in config or use placeholder replacement in config?
>
> 1. direct replacement
>st
liugddx commented on issue #3487:
URL:
https://github.com/apache/incubator-seatunnel/issues/3487#issuecomment-1330610869
Do we now use command line parameters to directly replace the parameters in
config or use placeholder replacement in config?
1. direct replacement
start-seatunn
This is an automated email from the ASF dual-hosted git repository.
ic4y pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git
The following commit(s) were added to refs/heads/dev by this push:
new e77fdbbef [Improve][Connectors-V2][jdbc] Ad
ic4y merged PR #3589:
URL: https://github.com/apache/incubator-seatunnel/pull/3589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@s
liugddx commented on PR #3510:
URL:
https://github.com/apache/incubator-seatunnel/pull/3510#issuecomment-1330556245
@EricJoy2048 @Hisoka-X PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
This is an automated email from the ASF dual-hosted git repository.
fanjia pushed a change to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git
from 3d46b7961 [Feature][Connector-V2][Doris]Add Doris Source & Sink
connector (#3586)
add 226dc6a11 [Hotfi
Hisoka-X merged PR #3592:
URL: https://github.com/apache/incubator-seatunnel/pull/3592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
Carl-Zhou-CN commented on issue #3599:
URL:
https://github.com/apache/incubator-seatunnel/issues/3599#issuecomment-1330359591
> schema = { fields { name = "string" age = "int" } meta.fields { topicAlias
= topic partitionAlias = partition } }
@Hisoka-X @TyrantLucifer @ashulin @hailin
Carl-Zhou-CN commented on issue #3599:
URL:
https://github.com/apache/incubator-seatunnel/issues/3599#issuecomment-1330307792
schema = {
fields {
name = "string"
age = "int"
}
meta.fields {
topicAlias = topic
partitionAlias
Carl-Zhou-CN commented on issue #3599:
URL:
https://github.com/apache/incubator-seatunnel/issues/3599#issuecomment-1330302397
link #2960 #3570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Carl-Zhou-CN opened a new issue, #3599:
URL: https://github.com/apache/incubator-seatunnel/issues/3599
### Search before asking
- [X] I had searched in the
[feature](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22)
and found no similar feature
Carl-Zhou-CN commented on PR #3598:
URL:
https://github.com/apache/incubator-seatunnel/pull/3598#issuecomment-1330258889
@TyrantLucifer @EricJoy2048 @Hisoka-X PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Carl-Zhou-CN opened a new pull request, #3598:
URL: https://github.com/apache/incubator-seatunnel/pull/3598
…k connector
## Purpose of this pull request
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for
reason:
* [
TaoZex commented on PR #3411:
URL:
https://github.com/apache/incubator-seatunnel/pull/3411#issuecomment-1330240951
Please unify GoogleSheets exception.
You can refer this pr :
https://github.com/apache/incubator-seatunnel/issues/3523 .
--
This is an automated message from the Apache G
BenjaminWenqiYu opened a new issue, #3597:
URL: https://github.com/apache/incubator-seatunnel/issues/3597
### Search before asking
- [X] I had searched in the
[issues](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22bug%22)
and found no similar issues.
TaoZex opened a new pull request, #3596:
URL: https://github.com/apache/incubator-seatunnel/pull/3596
## Purpose of this pull request
In order to prevent port conflict. Add localPort for AbstractJdbcIT.
