[GitHub] [incubator-seatunnel] EricJoy2048 commented on issue #3018: [Umbrella][Connector-V2] SeaTunnel Connector V2 Tracking Table

2022-11-25 Thread GitBox
EricJoy2048 commented on issue #3018: URL: https://github.com/apache/incubator-seatunnel/issues/3018#issuecomment-1328000555 > Rds is done,rds is fully compatible with mysql,I have submitted the Rds doc Can you link the `Rds` document? I can not found it from `docs/en/connector-v2`.

[incubator-seatunnel] branch dev updated: [Feature][API] add common options (#3353)

2022-11-25 Thread ic4y
This is an automated email from the ASF dual-hosted git repository. ic4y pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 79c3de43e [Feature][API] add common options

[GitHub] [incubator-seatunnel] ic4y merged pull request #3353: [Feature][API] add common options

2022-11-25 Thread GitBox
ic4y merged PR #3353: URL: https://github.com/apache/incubator-seatunnel/pull/3353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@s

[GitHub] [incubator-seatunnel] Solomon-aka-beatsAll opened a new pull request, #3579: Delete the Mapper may not be used.

2022-11-25 Thread GitBox
Solomon-aka-beatsAll opened a new pull request, #3579: URL: https://github.com/apache/incubator-seatunnel/pull/3579 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any new

[GitHub] [incubator-seatunnel] s7monk commented on issue #3018: [Umbrella][Connector-V2] SeaTunnel Connector V2 Tracking Table

2022-11-25 Thread GitBox
s7monk commented on issue #3018: URL: https://github.com/apache/incubator-seatunnel/issues/3018#issuecomment-1327987562 Rds is done,rds is fully compatible with mysql,I have submitted the Rds doc -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-seatunnel] s7monk opened a new pull request, #3578: [Feature][Connector-V2][Iceberg] Add Rds doc

2022-11-25 Thread GitBox
s7monk opened a new pull request, #3578: URL: https://github.com/apache/incubator-seatunnel/pull/3578 @https://github.com/apache/incubator-seatunnel/issues/2829 ## Purpose of this pull request Add Rds doc ## Check list * [X] Code changed are covered with tests,

[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #3557: [Improve][Connector-V2][Iotdb] Unified exception for iotdb source & sink connector

2022-11-25 Thread GitBox
wuchunfu commented on PR #3557: URL: https://github.com/apache/incubator-seatunnel/pull/3557#issuecomment-1327979612 @TyrantLucifer @CalvinKirs @Hisoka-X PTAL, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #3574: [Improve][Connector-V2][Kafka]Unified exception for Kafka source and sink connector

2022-11-25 Thread GitBox
TyrantLucifer commented on code in PR #3574: URL: https://github.com/apache/incubator-seatunnel/pull/3574#discussion_r1032737397 ## seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriter.java: ## @@ -124,7 +127

[GitHub] [incubator-seatunnel] wuchunfu merged pull request #3577: [Improve] [Connector-V2] Bad smell ToArrayCallWithZeroLengthArrayArgument

2022-11-25 Thread GitBox
wuchunfu merged PR #3577: URL: https://github.com/apache/incubator-seatunnel/pull/3577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[incubator-seatunnel] branch dev updated: [Improve] [Connector-V2] Bad smell ToArrayCallWithZeroLengthArrayArgument: (#3577)

2022-11-25 Thread wuchunfu
This is an automated email from the ASF dual-hosted git repository. wuchunfu pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new cc448d98c [Improve] [Connector-V2] Bad

[incubator-seatunnel] branch dev updated: [Improve][Connector-V2][Kudu] Unified exception for kudu source & sink connector (#3564)

2022-11-25 Thread fanjia
This is an automated email from the ASF dual-hosted git repository. fanjia pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 273418ddc [Improve][Connector-V2][Kudu] U

[GitHub] [incubator-seatunnel] Hisoka-X closed issue #3554: [Improve][Connector-V2][Kudu] Unified exception for Kudu source & sink connector

2022-11-25 Thread GitBox
Hisoka-X closed issue #3554: [Improve][Connector-V2][Kudu] Unified exception for Kudu source & sink connector URL: https://github.com/apache/incubator-seatunnel/issues/3554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #3564: [Improve][Connector-V2][Kudu] Unified exception for kudu source & sink connector

2022-11-25 Thread GitBox
Hisoka-X merged PR #3564: URL: https://github.com/apache/incubator-seatunnel/pull/3564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [incubator-seatunnel] lianghuan-xatu commented on pull request #3564: [Improve][Connector-V2][Kudu] Unified exception for kudu source & sink connector

2022-11-25 Thread GitBox
lianghuan-xatu commented on PR #3564: URL: https://github.com/apache/incubator-seatunnel/pull/3564#issuecomment-1327973027 @EricJoy2048 PTAL. Thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-seatunnel] EricJoy2048 commented on issue #3360: [Feature][Web Server] Add SeaTunnel Job Executor

2022-11-25 Thread GitBox
EricJoy2048 commented on issue #3360: URL: https://github.com/apache/incubator-seatunnel/issues/3360#issuecomment-1327956647 > Does job information including jvm resource parameters like -Xms -Xmx?If Job Information includes these paras ,Whether scripts in #3155 #3307 should accept these p

[GitHub] [incubator-seatunnel] EricJoy2048 commented on issue #3360: [Feature][Web Server] Add SeaTunnel Job Executor

2022-11-25 Thread GitBox
EricJoy2048 commented on issue #3360: URL: https://github.com/apache/incubator-seatunnel/issues/3360#issuecomment-1327956163 https://user-images.githubusercontent.com/32193458/204067742-d56ce47e-8edd-4124-8109-57b4d36f7b67.png";> @TyrantLucifer Here are some interaction processes bet

[GitHub] [incubator-seatunnel] github-actions[bot] commented on issue #2678: [Feature][API] SeaTunnel Transform API

2022-11-25 Thread GitBox
github-actions[bot] commented on issue #2678: URL: https://github.com/apache/incubator-seatunnel/issues/2678#issuecomment-1327939292 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity

[GitHub] [incubator-seatunnel] MartinWitt opened a new pull request, #3577: refactor: refactor bad smell ToArrayCallWithZeroLengthArrayArgument

2022-11-25 Thread GitBox
MartinWitt opened a new pull request, #3577: URL: https://github.com/apache/incubator-seatunnel/pull/3577 # Repairing Code Style Issues ## ToArrayCallWithZeroLengthArrayArgument The performance of the empty array version is the same, and sometimes even better, compared to the pr

[GitHub] [incubator-seatunnel] TyrantLucifer commented on issue #3573: [Improve][HTTP Connector] Add specified field function for all HTTP connector

2022-11-25 Thread GitBox
TyrantLucifer commented on issue #3573: URL: https://github.com/apache/incubator-seatunnel/issues/3573#issuecomment-1327600094 I have some questions: 1. As you shown, add a new parameter to tell connector get a part of upstream data. But this requirement only works on json format, fo

[GitHub] [incubator-seatunnel] lianghuan-xatu commented on a diff in pull request #3564: [Improve][Connector-V2][Kudu] Unified exception for kudu source & sink connector

2022-11-25 Thread GitBox
lianghuan-xatu commented on code in PR #3564: URL: https://github.com/apache/incubator-seatunnel/pull/3564#discussion_r1032524403 ## seatunnel-connectors-v2/connector-kudu/src/main/java/org/apache/seatunnel/connectors/seatunnel/kudu/source/KuduSource.java: ## @@ -158,7 +161,8 @

[GitHub] [incubator-seatunnel] lianghuan-xatu commented on a diff in pull request #3564: [Improve][Connector-V2][Kudu] Unified exception for kudu source & sink connector

2022-11-25 Thread GitBox
lianghuan-xatu commented on code in PR #3564: URL: https://github.com/apache/incubator-seatunnel/pull/3564#discussion_r1032524075 ## seatunnel-connectors-v2/connector-kudu/src/main/java/org/apache/seatunnel/connectors/seatunnel/kudu/source/KuduSource.java: ## @@ -175,7 +179,8 @

[incubator-seatunnel] branch dev updated: [Improve][Connector-V2] Update v2 config template (#3472)

2022-11-25 Thread tyrantlucifer
This is an automated email from the ASF dual-hosted git repository. tyrantlucifer pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new e486d5ca5 [Improve][Connector-V2]

[GitHub] [incubator-seatunnel] TyrantLucifer merged pull request #3472: [Improve][Connector-V2]modify config template

2022-11-25 Thread GitBox
TyrantLucifer merged PR #3472: URL: https://github.com/apache/incubator-seatunnel/pull/3472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [incubator-seatunnel] liugddx opened a new pull request, #3576: [Feature][Core] Supprot add thirdparty jar in env

2022-11-25 Thread GitBox
liugddx opened a new pull request, #3576: URL: https://github.com/apache/incubator-seatunnel/pull/3576 close #3575 ## Purpose of this pull request ## Check list * [ ] Code changed are covered with tests, or it does not need tests for reason: * [ ] If any n

[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #3570: [Improve][Connector-V2-kafka] Support read message metadata(key、timestamp、headers)

2022-11-25 Thread GitBox
Hisoka-X commented on code in PR #3570: URL: https://github.com/apache/incubator-seatunnel/pull/3570#discussion_r1032495755 ## docs/en/connector-v2/source/kafka.md: ## @@ -71,6 +71,21 @@ Source plugin common parameters, please refer to [Source Common Options](common- The st

[GitHub] [incubator-seatunnel] TaoZex commented on a diff in pull request #3570: [Improve][Connector-V2-kafka] Support read message metadata(key、timestamp、headers)

2022-11-25 Thread GitBox
TaoZex commented on code in PR #3570: URL: https://github.com/apache/incubator-seatunnel/pull/3570#discussion_r1032489660 ## docs/en/connector-v2/source/kafka.md: ## @@ -71,6 +71,21 @@ Source plugin common parameters, please refer to [Source Common Options](common- The stru

[GitHub] [incubator-seatunnel] Hisoka-X closed issue #3535: [Improve][Connector-V2][Influxdb] Unified exception for influxdb source & sink connector

2022-11-25 Thread GitBox
Hisoka-X closed issue #3535: [Improve][Connector-V2][Influxdb] Unified exception for influxdb source & sink connector URL: https://github.com/apache/incubator-seatunnel/issues/3535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-seatunnel] Hisoka-X merged pull request #3558: [Improve][Connector-V2][Influxdb] Unified exception for influxdb source & sink connector

2022-11-25 Thread GitBox
Hisoka-X merged PR #3558: URL: https://github.com/apache/incubator-seatunnel/pull/3558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[incubator-seatunnel] branch dev updated: [Improve][Connector-V2][Influxdb] Unified exception for influxdb source & sink connector (#3558)

2022-11-25 Thread fanjia
This is an automated email from the ASF dual-hosted git repository. fanjia pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git The following commit(s) were added to refs/heads/dev by this push: new 4686f35d6 [Improve][Connector-V2][Influxd

[GitHub] [incubator-seatunnel] TaoZex commented on pull request #3574: [Improve][Connector-V2][Kafka]Unified exception for Kafka source and sink connector

2022-11-25 Thread GitBox
TaoZex commented on PR #3574: URL: https://github.com/apache/incubator-seatunnel/pull/3574#issuecomment-1327495052 > LGTM Thanks for your review.Have a great weekend! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #3353: [Feature][API] add common options

2022-11-25 Thread GitBox
ashulin commented on code in PR #3353: URL: https://github.com/apache/incubator-seatunnel/pull/3353#discussion_r1032252746 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/factory/FactoryUtil.java: ## @@ -155,4 +159,36 @@ private static List discoverFactories(Class

[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3353: [Feature][API] add common options

2022-11-25 Thread GitBox
EricJoy2048 commented on code in PR #3353: URL: https://github.com/apache/incubator-seatunnel/pull/3353#discussion_r1032225902 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/factory/TableSinkFactory.java: ## @@ -32,11 +33,28 @@ /** * We will never us

[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #3353: [Feature][API] add common options

2022-11-25 Thread GitBox
CalvinKirs commented on code in PR #3353: URL: https://github.com/apache/incubator-seatunnel/pull/3353#discussion_r1032190343 ## seatunnel-api/src/main/java/org/apache/seatunnel/api/table/factory/TableSourceFactory.java: ## @@ -36,4 +37,21 @@ public interface TableSourceFactory

[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3353: [Feature][API] add common options

2022-11-25 Thread GitBox
EricJoy2048 commented on code in PR #3353: URL: https://github.com/apache/incubator-seatunnel/pull/3353#discussion_r1032118183 ## seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServerStarter.java: ## @@ -39,6 +40,13 @@ public