Re: [PR] Refactored duplicate code in TopicPublishInfo [rocketmq]

2025-03-21 Thread via GitHub
DivyanshIITB commented on PR #9257: URL: https://github.com/apache/rocketmq/pull/9257#issuecomment-2744949363 @RongtongJin I have resolved and replied to your review. Let me know if any further changes are required ! -- This is an automated message from the Apache Git Service. To r

Re: [PR] Fix: Added missing NameServer parameter for RocketMQ Dashboard deployment [rocketmq-site]

2025-03-21 Thread via GitHub
DivyanshIITB commented on PR #720: URL: https://github.com/apache/rocketmq-site/pull/720#issuecomment-2744951543 @RongtongJin Gentle Reminder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] Optimize processResponseCommand in NettyRemotingAbstract by Removing Redundant Operations [rocketmq]

2025-03-21 Thread via GitHub
DivyanshIITB opened a new pull request, #9268: URL: https://github.com/apache/rocketmq/pull/9268 Key Changes: - Removed duplicate operation: responseFuture.setResponseCommand(cmd); was being called outside and inside the if condition. It is now moved inside the conditional block

[PR] Upgrade the version in quickstart to the latest [rocketmq-site]

2025-03-21 Thread via GitHub
yx9o opened a new pull request, #721: URL: https://github.com/apache/rocketmq-site/pull/721 Upgrade quickstart version 5.3.1 to 5.3.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Optimize processResponseCommand in NettyRemotingAbstract by Removing Redundant Operations [rocketmq]

2025-03-21 Thread via GitHub
codecov-commenter commented on PR #9268: URL: https://github.com/apache/rocketmq/pull/9268#issuecomment-2745083434 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9268?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

Re: [PR] fix(Dockerfile): Unable to build docker image [rocketmq-dashboard]

2025-03-21 Thread via GitHub
cndoit18 closed pull request #134: fix(Dockerfile): Unable to build docker image URL: https://github.com/apache/rocketmq-dashboard/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Refactored duplicate code in TopicPublishInfo [rocketmq]

2025-03-21 Thread via GitHub
DivyanshIITB commented on PR #9257: URL: https://github.com/apache/rocketmq/pull/9257#issuecomment-2742785857 Just a gentle reminder @RongtongJin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2025-03-21 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user DivyanshIITB (triggered by DivyanshIITB). Head commit for run: bac12272f93f538bf34c326826650d11c4467901 / Divyansh Refactored processResponseCommand to remove redundant operations Repo

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2025-03-21 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user DivyanshIITB (triggered by github-actions[bot]). Head commit for run: bac12272f93f538bf34c326826650d11c4467901 / Divyansh Refactored processResponseCommand to remove redundant operation