Re: [I] [Bug] No topic route info in name server for the topic [rocketmq]

2024-08-01 Thread via GitHub
leizhiyuan commented on issue #8455: URL: https://github.com/apache/rocketmq/issues/8455#issuecomment-2262218962 %RETRY%YourConsumerGroup. 手动吧重试topic也创建一下。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

(rocketmq) branch develop updated: nly initialize all the variables once to speed up test ConsumeMessageConcurrentlyServiceTest (#8436)

2024-08-01 Thread jinrongtong
This is an automated email from the ASF dual-hosted git repository. jinrongtong pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq.git The following commit(s) were added to refs/heads/develop by this push: new 2ed4ba23e0 nly initialize all the varia

Re: [PR] only initialize all the variables once to speed up test ConsumeMessageConcurrentlyServiceTest [rocketmq]

2024-08-01 Thread via GitHub
RongtongJin merged PR #8436: URL: https://github.com/apache/rocketmq/pull/8436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocke

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-08-01 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 2ed4ba23e0448d5a7a4f68c29d0f9bb7a6d30ee3 / TestBoost <153348110+testbo...@users.noreply.github.com> nly initialize all the v

[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2024-08-01 Thread GitBox
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 2ed4ba23e0448d5a7a4f68c29d0f9bb7a6d30ee3 / TestBoost <153348110+testbo...@users.noreply.github.com> nly initialize all the variables once to speed

Re: [PR] [ISSUE #8468]: Add a message gray solution , compatible with POP consumption mode and Push consumption mode [rocketmq]

2024-08-01 Thread via GitHub
Qoozm commented on PR #8469: URL: https://github.com/apache/rocketmq/pull/8469#issuecomment-2262325920 > @syhleo Hello, I have a question. If the producer is configured with grayscale, but the consumer is not configured with grayscale, then the data in the grayscale queue will also be consu

Re: [PR] Fix: instance was created prematurely [rocketmq]

2024-08-01 Thread via GitHub
oopooa commented on PR #8457: URL: https://github.com/apache/rocketmq/pull/8457#issuecomment-2262338421 Hi @RongtongJin I noticed that this PR has been open for a while and wanted to check if there's anything more I can do to help get it merged. Please let me know if there are any ch

Re: [PR] [ISSUE #8468]: Add a message gray solution , compatible with POP consumption mode and Push consumption mode [rocketmq]

2024-08-01 Thread via GitHub
syhleo commented on PR #8469: URL: https://github.com/apache/rocketmq/pull/8469#issuecomment-2262576138 > @syhleo Hello, I have a question. If the producer is configured with grayscale, but the consumer is not configured with grayscale, then the data in the grayscale queue will also be cons

Re: [I] [Enhancement] Add message gray strategy solution, compatible with POP consumption mode and Push consumption mode [rocketmq]

2024-08-01 Thread via GitHub
syhleo commented on issue #8468: URL: https://github.com/apache/rocketmq/issues/8468#issuecomment-2262580555 the related documentation:[语雀](https://www.yuque.com/u2210974/zrf1wg/bgqmutg83wyeyzfq) -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] [ISSUE #8380]fix wrong election in controllerMode [rocketmq]

2024-08-01 Thread via GitHub
TheR1sing3un commented on PR #8383: URL: https://github.com/apache/rocketmq/pull/8383#issuecomment-2262622348 Thanks for your contributions! By the way, how about adding unit tests to cover this code path? -- This is an automated message from the Apache Git Service. To respond to the m

Re: [I] Expected the service ProducerImpl-0 [FAILED] to be RUNNING, but the service has FAILED [rocketmq]

2024-08-01 Thread via GitHub
MmringZee commented on issue #6015: URL: https://github.com/apache/rocketmq/issues/6015#issuecomment-2262898005 > 我的代码经过验证发现与 enableSsl=false 无关,主要是 endpoint 指定了错误的地址 nameserver(localhost:9876), 把 endpoint 指定为 proxy 地址端口,以上两个报错都解决了 另外,rocketmq 5.x 需要使用 proxy 的的方式启动, 希望文档能更细化完善 官方文档里的

Re: [PR] [ISSUE #8468]: Add a message gray solution , compatible with POP consumption mode and Push consumption mode [rocketmq]

2024-08-01 Thread via GitHub
yx9o commented on PR #8469: URL: https://github.com/apache/rocketmq/pull/8469#issuecomment-2262918716 If the grayscale message and normal message data formats are inconsistent, and grayscale is enabled for production but not for consumption, will the grayscale data consumed normally fail to

Re: [I] [Bug]dispatch message to consume queue error [rocketmq]

2024-08-01 Thread via GitHub
gaojunyu5268 commented on issue #8394: URL: https://github.com/apache/rocketmq/issues/8394#issuecomment-2262944669 if the config attribute "transientStorePoolEnable=false",the problem is OK! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GH] (rocketmq-clients): Workflow run "Build" failed!

2024-08-01 Thread GitBox
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user tsunghanjacktsai (triggered by tsunghanjacktsai). Head commit for run: aa690b07ea53b0bdd20f70792bf7df189f5a80f5 / tsaitsung-han.tht Add unit test for csharp sdk and fix some corresponding errors Repo

[GH] (rocketmq-clients): Workflow run "Build" failed!

2024-08-01 Thread GitBox
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user tsunghanjacktsai (triggered by tsunghanjacktsai). Head commit for run: 7791ef7c9d0c7688f6dffc0b6c9e4725d275c00c / tsaitsung-han.tht Add integration test for csharp sdk Report URL: https://github.com/

Re: [PR] [ISSUE #8468]: Add a message gray solution , compatible with POP consumption mode and Push consumption mode [rocketmq]

2024-08-01 Thread via GitHub
syhleo commented on PR #8469: URL: https://github.com/apache/rocketmq/pull/8469#issuecomment-2263046929 > If the grayscale message and normal message data formats are inconsistent, and grayscale is enabled for production but not for consumption, will the grayscale data consumed normally fai

Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]

2024-08-01 Thread via GitHub
TeFuirnever commented on PR #8477: URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2263475260 Hello, is there something wrong with this test item(Build and Run Tests by Bazel / bazel-compile (ubuntu-latest) (pull_request))? ![image](https://github.com/user-attachments/asse

Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]

2024-08-01 Thread via GitHub
TeFuirnever commented on PR #8477: URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2263476449 > Hello, is there something wrong with this test item(Build and Run Tests by Bazel / bazel-compile (ubuntu-latest) (pull_request))? ![image](https://private-user-images.githubusercon

Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]

2024-08-01 Thread via GitHub
TeFuirnever commented on PR #8477: URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2263479243 I see a lot of people having this problem, what can be done to fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]

2024-08-01 Thread via GitHub
TheR1sing3un commented on PR #8477: URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2263489363 > I see a lot of people having this problem, what can be done to fix it? This bazel-build check isn't 'required' for pr merging, but u can try to fix these flaky tests if you

Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]

2024-08-01 Thread via GitHub
TeFuirnever commented on PR #8477: URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2263505769 > > I see a lot of people having this problem, what can be done to fix it? > > This bazel-build check isn't 'required' for pr merging, but u can try to fix these flaky tests if

Re: [PR] [ISSUE #8476] Add test cases for org.apache.rocketmq.common.attribute [rocketmq]

2024-08-01 Thread via GitHub
ShannonDing commented on PR #8477: URL: https://github.com/apache/rocketmq/pull/8477#issuecomment-2264390168 @TeFuirnever A reminder from the Tianchi platform: it‘s better to submit your results to the [official website](https://tianchi.aliyun.com/competition/entrance/532215/information) a

Re: [PR] [ISSUE #8458] Add more test coverage for ProcessQueue [rocketmq]

2024-08-01 Thread via GitHub
ShannonDing commented on PR #8459: URL: https://github.com/apache/rocketmq/pull/8459#issuecomment-2264392882 @yx9o A reminder from the Tianchi platform: it‘s better to submit your results to the [official website](https://tianchi.aliyun.com/competition/entrance/532215/information) asap.

[I] [Enhancement] Improve delete and rolling strategy for tiered storage modules [rocketmq]

2024-08-01 Thread via GitHub
lizhimins opened a new issue, #8481: URL: https://github.com/apache/rocketmq/issues/8481 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary 改进和修复分级存储模块相关的几个小问题

[PR] Fix crash issue of TelemetryBidiReactor and MetricBidiReactor [rocketmq-clients]

2024-08-01 Thread via GitHub
0902horn opened a new pull request, #809: URL: https://github.com/apache/rocketmq-clients/pull/809 ### Which Issue(s) This PR Fixes Fixes #789 #790 #791 #792 #795 #796, and maybe #794 #797 . ### Brief Description ### How Did You Test This Chang

[GH] (rocketmq-clients): Workflow run "CodeSpell Check" is working again!

2024-08-01 Thread GitBox
The GitHub Actions job "CodeSpell Check" on rocketmq-clients.git has succeeded. Run started by GitHub user 0902horn (triggered by lizhanhui). Head commit for run: 690d7980829d1f32e33287ddf7f6caa982151873 / 0902horn <0902h...@gmail.com> Fix crash issue of TelemetryBidiReactor and MetricBidiReacto

[GH] (rocketmq-clients): Workflow run "License Checker" is working again!

2024-08-01 Thread GitBox
The GitHub Actions job "License Checker" on rocketmq-clients.git has succeeded. Run started by GitHub user 0902horn (triggered by lizhanhui). Head commit for run: 690d7980829d1f32e33287ddf7f6caa982151873 / 0902horn <0902h...@gmail.com> Fix crash issue of TelemetryBidiReactor and MetricBidiReacto

Re: [PR] Fix crash issue of TelemetryBidiReactor and MetricBidiReactor [rocketmq-clients]

2024-08-01 Thread via GitHub
lizhanhui commented on code in PR #809: URL: https://github.com/apache/rocketmq-clients/pull/809#discussion_r1701293802 ## cpp/source/client/TelemetryBidiReactor.cpp: ## @@ -383,134 +279,61 @@ void TelemetryBidiReactor::write(TelemetryCommand command) { void TelemetryBidiRea

Re: [PR] Fix crash issue of TelemetryBidiReactor and MetricBidiReactor [rocketmq-clients]

2024-08-01 Thread via GitHub
lizhanhui commented on PR #809: URL: https://github.com/apache/rocketmq-clients/pull/809#issuecomment-2264604447 grpc::ClientContext#TryCancel is something I missed and It helps simplify the workflow a lot. Good Job. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Fix crash issue of TelemetryBidiReactor and MetricBidiReactor [rocketmq-clients]

2024-08-01 Thread via GitHub
lizhanhui commented on code in PR #809: URL: https://github.com/apache/rocketmq-clients/pull/809#discussion_r1701304750 ## cpp/source/client/include/TelemetryBidiReactor.h: ## @@ -122,7 +111,7 @@ class TelemetryBidiReactor : public grpc::ClientBidiReactor

Re: [PR] Fix crash issue of TelemetryBidiReactor and MetricBidiReactor [rocketmq-clients]

2024-08-01 Thread via GitHub
lizhanhui commented on code in PR #809: URL: https://github.com/apache/rocketmq-clients/pull/809#discussion_r1701310065 ## cpp/source/stats/include/MetricBidiReactor.h: ## @@ -36,8 +36,8 @@ class MetricBidiReactor : public grpc::ClientBidiReactor { public: - MetricBidiRea

[PR] [ISSUE #8479] Fix pop revive infinite retry caused by deleting one topic then re-create it in a short time [rocketmq]

2024-08-01 Thread via GitHub
redlsz opened a new pull request, #8482: URL: https://github.com/apache/rocketmq/pull/8482 ### Which Issue(s) This PR Fixes Fixes #8479 ### Brief Description Skip reviving if get message result is OFFSET_OVERFLOW_ONE or OFFSET_OVERFLOW_BADLY

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-08-01 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user redlsz (triggered by redlsz). Head commit for run: 066a3c5cb03b7b6184d44cbb34f62074b7dad869 / redlsz fix: revive skip OFFSET_OVERFLOW_ONE & OFFSET_OVERFLOW_BADLY Report URL: https://gi

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-08-01 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user redlsz (triggered by redlsz). Head commit for run: 2ed4ba23e0448d5a7a4f68c29d0f9bb7a6d30ee3 / TestBoost <153348110+testbo...@users.noreply.github.com> nly initialize all the variables once

Re: [PR] [ISSUE #8460] Improve the pop revive process when reading biz messages from a remote broker [rocketmq]

2024-08-01 Thread via GitHub
RongtongJin merged PR #8475: URL: https://github.com/apache/rocketmq/pull/8475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocke

(rocketmq) branch develop updated: [ISSUE #8460] Improve the pop revive process when reading biz messages from a remote broker (#8475)

2024-08-01 Thread jinrongtong
This is an automated email from the ASF dual-hosted git repository. jinrongtong pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq.git The following commit(s) were added to refs/heads/develop by this push: new aab646ce83 [ISSUE #8460] Improve the po

Re: [PR] [ISSUE #8479] Fix pop revive infinite retry caused by deleting one topic then re-create it in a short time [rocketmq]

2024-08-01 Thread via GitHub
codecov-commenter commented on PR #8482: URL: https://github.com/apache/rocketmq/pull/8482#issuecomment-2264678712 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8482?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-08-01 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: aab646ce83930454d8b5956779aa28a80e326e24 / imzs [ISSUE #8460] Improve the pop revive process when reading biz messages from