Re: [I] [Enhancement] Add test cases for common module #8413 [rocketmq]

2024-07-21 Thread via GitHub
TeFuirnever commented on issue #8417: URL: https://github.com/apache/rocketmq/issues/8417#issuecomment-2241514333 link https://github.com/apache/rocketmq/issues/8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[I] [Enhancement] Add test cases for common module #8413 [rocketmq]

2024-07-21 Thread via GitHub
TeFuirnever opened a new issue, #8417: URL: https://github.com/apache/rocketmq/issues/8417 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary Add test cases for co

[PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig #8417 [rocketmq]

2024-07-21 Thread via GitHub
TeFuirnever opened a new pull request, #8418: URL: https://github.com/apache/rocketmq/pull/8418 ### Which Issue(s) This PR Fixes [Enhancement] Add test cases for org.apache.rocketmq.common.AclConfig #8417 Fixes #8417 ### Brief Description add some test cases for or

Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]

2024-07-21 Thread via GitHub
TeFuirnever commented on PR #8418: URL: https://github.com/apache/rocketmq/pull/8418#issuecomment-2241521407 for soc in https://github.com/apache/rocketmq/issues/8262 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]

2024-07-21 Thread via GitHub
yx9o commented on code in PR #8418: URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685710344 ## common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]

2024-07-21 Thread via GitHub
TeFuirnever commented on code in PR #8418: URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685710869 ## common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]

2024-07-21 Thread via GitHub
yx9o commented on code in PR #8418: URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685711325 ## common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]

2024-07-21 Thread via GitHub
TeFuirnever commented on code in PR #8418: URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685726409 ## common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]

2024-07-21 Thread via GitHub
yx9o commented on code in PR #8418: URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685739978 ## common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]

2024-07-21 Thread via GitHub
TeFuirnever commented on code in PR #8418: URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685747817 ## common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]

2024-07-21 Thread via GitHub
TeFuirnever commented on code in PR #8418: URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685749292 ## common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GH] (rocketmq): Workflow run "Snapshot Daily Release Automation" is working again!

2024-07-21 Thread GitBox
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has succeeded. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: d9d53d58cf7f32143485f12d4851d5c119d0855a / Tan Xiang <82364837+tanxiang...@users.noreply.github.com> add some tests for

Re: [I] [Enhancement] Find ways to reduce tiered storage module's GC pressure [rocketmq]

2024-07-21 Thread via GitHub
bxfjb commented on issue #8408: URL: https://github.com/apache/rocketmq/issues/8408#issuecomment-2241895055 > It looks like your cache is holding SelectBufferResult, which wraps a ByteBuffer. From your description, it sounds like it’s non-direct (on-heap). Since they are long lived you migh

[I] [Bug] LitePullConsumer will Continuously print error logs util receive new msg [rocketmq]

2024-07-21 Thread via GitHub
keranbingaa opened a new issue, #8419: URL: https://github.com/apache/rocketmq/issues/8419 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X]

[I] The wrong log type is used for log printing during error handling [rocketmq-spring]

2024-07-21 Thread via GitHub
LJiangTao opened a new issue, #670: URL: https://github.com/apache/rocketmq-spring/issues/670 ## environment ```xml org.apache.rocketmq rocketmq-spring-boot-starter 2.3.0 ``` > current latest version also has issue. ## describe using w

Re: [PR] [ISSUE #8405] Add the ability to write ConsumeQueue using fileChannel to prevent JVM crashes in some situations [rocketmq]

2024-07-21 Thread via GitHub
RongtongJin commented on PR #8403: URL: https://github.com/apache/rocketmq/pull/8403#issuecomment-2241907195 > How can this prevent JVM crashes? Is it because fileChannel uses off-heap memory? yes -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [I] [Enhancement] Add more test coverage for DefaultMQPushConsumerImpl [rocketmq]

2024-07-21 Thread via GitHub
RongtongJin closed issue #8411: [Enhancement] Add more test coverage for DefaultMQPushConsumerImpl URL: https://github.com/apache/rocketmq/issues/8411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl [rocketmq]

2024-07-21 Thread via GitHub
RongtongJin merged PR #8412: URL: https://github.com/apache/rocketmq/pull/8412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocke

(rocketmq) branch develop updated: [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl (#8412)

2024-07-21 Thread jinrongtong
This is an automated email from the ASF dual-hosted git repository. jinrongtong pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq.git The following commit(s) were added to refs/heads/develop by this push: new bd61774b1f [ISSUE #8411] Add more test

[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2024-07-21 Thread GitBox
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: bd61774b1fc19f92c8c3a466420d50899ed61d9b / yx9o [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl (#8412) * [ISSUE #8411] Add mo

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-07-21 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user TeFuirnever (triggered by TeFuirnever). Head commit for run: bd61774b1fc19f92c8c3a466420d50899ed61d9b / yx9o [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl (#8412) * [I

[PR] [ISSUE #8419] update consume offset when not get msg in litepullconsumer [rocketmq]

2024-07-21 Thread via GitHub
keranbingaa opened a new pull request, #8420: URL: https://github.com/apache/rocketmq/pull/8420 Fixes #8419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]

2024-07-21 Thread via GitHub
codecov-commenter commented on PR #8418: URL: https://github.com/apache/rocketmq/pull/8418#issuecomment-2241937943 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8418?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-07-21 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user keranbingaa (triggered by keranbingaa). Head commit for run: bd61774b1fc19f92c8c3a466420d50899ed61d9b / yx9o [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl (#8412) * [I

Re: [PR] [ISSUE #8419] update consume offset when not get msg in litepullconsumer [rocketmq]

2024-07-21 Thread via GitHub
codecov-commenter commented on PR #8420: URL: https://github.com/apache/rocketmq/pull/8420#issuecomment-2241957263 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8420?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

Re: [PR] [ISSUE #8413]add some test cases for commom module [rocketmq]

2024-07-21 Thread via GitHub
RongtongJin merged PR #8414: URL: https://github.com/apache/rocketmq/pull/8414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocke

Re: [I] [Enhancement] Add test cases for common module [rocketmq]

2024-07-21 Thread via GitHub
RongtongJin closed issue #8413: [Enhancement] Add test cases for common module URL: https://github.com/apache/rocketmq/issues/8413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

(rocketmq) branch develop updated: [ISSUE #8413] Add some test cases for commom module

2024-07-21 Thread jinrongtong
This is an automated email from the ASF dual-hosted git repository. jinrongtong pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq.git The following commit(s) were added to refs/heads/develop by this push: new 6ecdc48223 [ISSUE #8413] Add some test

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2024-07-21 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: bd61774b1fc19f92c8c3a466420d50899ed61d9b / yx9o [ISSUE #8411] Add more test coverage for DefaultMQPushConsumerImpl (#8412

[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2024-07-21 Thread GitBox
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 6ecdc482232918a3b2a8b0fd36cb1d9a03a60415 / yueran [ISSUE #8413] Add some test cases for commom module Report URL: https://github.com/apache/rocke

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2024-07-21 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user keranbingaa (triggered by keranbingaa). Head commit for run: 1c5b3d44e6624d3499c120e2d2aa9e068e78648e / keranbingaa <397294...@qq.com> [ISSUE #8419] update consume offset when not get ms

Re: [PR] [ISSUE #8417]add some test cases for org.apache.rocketmq.common.AclConfig [rocketmq]

2024-07-21 Thread via GitHub
yx9o commented on code in PR #8418: URL: https://github.com/apache/rocketmq/pull/8418#discussion_r1685931528 ## common/src/test/java/org/apache/rocketmq/common/AclConfigTest.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[I] [Enhancement] Add more test coverage for broker.slave.SlaveSynchronize [rocketmq]

2024-07-21 Thread via GitHub
TanXiang7o opened a new issue, #8421: URL: https://github.com/apache/rocketmq/issues/8421 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary add more tests

[PR] [ISSUE #8421]add more test coverage for SlaveSynchronize [rocketmq]

2024-07-21 Thread via GitHub
TanXiang7o opened a new pull request, #8422: URL: https://github.com/apache/rocketmq/pull/8422 fix #8421 before: ![image](https://github.com/user-attachments/assets/92b44827-88c1-4c6b-8e91-2acc36edd5a8) after: ![image](https://github.com/user-attachments/assets/69500723-28d0-4c

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2024-07-21 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 6ecdc482232918a3b2a8b0fd36cb1d9a03a60415 / yueran [ISSUE #8413] Add some test cases for commom module Report URL: https:

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-07-21 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user TanXiang7o (triggered by TanXiang7o). Head commit for run: 6ecdc482232918a3b2a8b0fd36cb1d9a03a60415 / yueran [ISSUE #8413] Add some test cases for commom module Report URL: https://github.

Re: [PR] [ISSUE #8421]add more test coverage for SlaveSynchronize [rocketmq]

2024-07-21 Thread via GitHub
codecov-commenter commented on PR #8422: URL: https://github.com/apache/rocketmq/pull/8422#issuecomment-2242078258 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8422?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

[I] [Feature] When will pushconsumer for go can be implemented? [rocketmq-clients]

2024-07-21 Thread via GitHub
AllenZMC opened a new issue, #800: URL: https://github.com/apache/rocketmq-clients/issues/800 ### Programming Language of the Client Go ### Is Your Feature Request Related to a Problem? We need to align features with Java/C++/... ### Describe the Solution You'd Lik

Re: [I] [Enhancement] Add more test coverage for broker.slave.SlaveSynchronize [rocketmq]

2024-07-21 Thread via GitHub
ShannonDing commented on issue #8421: URL: https://github.com/apache/rocketmq/issues/8421#issuecomment-2242159844 link #8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [ISSUE #8421]add more test coverage for SlaveSynchronize [rocketmq]

2024-07-21 Thread via GitHub
ShannonDing commented on PR #8422: URL: https://github.com/apache/rocketmq/pull/8422#issuecomment-2242160413 link #8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [ISSUE #8392] add tests for QueryMessageProcessor [rocketmq]

2024-07-21 Thread via GitHub
ShannonDing commented on PR #8393: URL: https://github.com/apache/rocketmq/pull/8393#issuecomment-2242195357 link #8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [ISSUE #8372] Add more test coverage for AdminBrokerProcessor [rocketmq]

2024-07-21 Thread via GitHub
ShannonDing commented on PR #8373: URL: https://github.com/apache/rocketmq/pull/8373#issuecomment-2242196758 link #8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] [Enhancement] Add more test coverage for QueryMessageProcessor [rocketmq]

2024-07-21 Thread via GitHub
ShannonDing commented on issue #8392: URL: https://github.com/apache/rocketmq/issues/8392#issuecomment-2242200664 link #8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] [Enhancement] Add more test coverage for AdminBrokerProcessor [rocketmq]

2024-07-21 Thread via GitHub
ShannonDing commented on issue #8372: URL: https://github.com/apache/rocketmq/issues/8372#issuecomment-2242202025 link #8262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.