Re: [PR] [ISSUE #8384] Add more test coverage for ClientConfig [rocketmq]

2024-07-14 Thread via GitHub
RongtongJin commented on code in PR #8385: URL: https://github.com/apache/rocketmq/pull/8385#discussion_r1677067060 ## client/src/test/java/org/apache/rocketmq/client/ClientConfigTest.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

Re: [PR] [ISSUE #8372] Add more test coverage for AdminBrokerProcessor [rocketmq]

2024-07-14 Thread via GitHub
RongtongJin commented on PR #8373: URL: https://github.com/apache/rocketmq/pull/8373#issuecomment-2227231738 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-07-14 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user tanXiang003 (triggered by tanXiang003). Head commit for run: 6c3781f17e22ec35ddb2113bab5cdc4967cb8260 / 吴星灿 <37405937+qianye1...@users.noreply.github.com> [ISSUE #8365] add non-oneway updat

Re: [PR] [ISSUE #8372] Add more test coverage for AdminBrokerProcessor [rocketmq]

2024-07-14 Thread via GitHub
codecov-commenter commented on PR #8373: URL: https://github.com/apache/rocketmq/pull/8373#issuecomment-2227239253 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8373?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

Re: [PR] [ISSUE #8384] Add more test coverage for ClientConfig [rocketmq]

2024-07-14 Thread via GitHub
yx9o commented on code in PR #8385: URL: https://github.com/apache/rocketmq/pull/8385#discussion_r1677081439 ## client/src/test/java/org/apache/rocketmq/client/ClientConfigTest.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2024-07-14 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user YanYunyang (triggered by RongtongJin). Head commit for run: 6c81af9ccf6e8170254ca656e54f81930f9108b9 / sheep_yan <313169...@qq.com> Merge branch 'apache:develop' into ISSUE-8366-fix Rep

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2024-07-14 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user tanXiang003 (triggered by RongtongJin). Head commit for run: fb19731836df38d3ecf90f5b8b1f4a1b9b18cb7a / Tan Xiang <82364837+tanxiang...@users.noreply.github.com> Merge branch 'apache:de

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-07-14 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: 6c3781f17e22ec35ddb2113bab5cdc4967cb8260 / 吴星灿 <37405937+qianye1...@users.noreply.github.com> [ISSUE #8365] add non-oneway updateConsumerOffse

Re: [PR] [ISSUE #8372] Add more test coverage for AdminBrokerProcessor [rocketmq]

2024-07-14 Thread via GitHub
tanXiang003 commented on PR #8373: URL: https://github.com/apache/rocketmq/pull/8373#issuecomment-2227274155 @RongtongJin Im sorry. I reviewed the code carefully. This error doesn't seem to have anything to do with me?I just add tests for broker not store ![image](https://github.com/

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2024-07-14 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: 67684160aa921cc730b0656a11ee7fbad77abf14 / yx9o Update test Report URL: https://github.com/apache/rocketmq/actions/runs/9926569524 Wi

Re: [PR] [ISSUE #8384] Add more test coverage for ClientConfig [rocketmq]

2024-07-14 Thread via GitHub
yx9o commented on PR #8385: URL: https://github.com/apache/rocketmq/pull/8385#issuecomment-2227282458 @RongtongJin Done, please review, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [Enhancement] 请RocketMQ dotnet客户端升级到新版 [rocketmq-clients]

2024-07-14 Thread via GitHub
github-actions[bot] closed issue #770: [Enhancement] 请RocketMQ dotnet客户端升级到新版 URL: https://github.com/apache/rocketmq-clients/issues/770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [I] [Enhancement] 请RocketMQ dotnet客户端升级到新版 [rocketmq-clients]

2024-07-14 Thread via GitHub
github-actions[bot] commented on issue #770: URL: https://github.com/apache/rocketmq-clients/issues/770#issuecomment-2227536931 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] [csharp] update TFM to net6 and net8 [rocketmq-clients]

2024-07-14 Thread via GitHub
catcherwong commented on PR #799: URL: https://github.com/apache/rocketmq-clients/pull/799#issuecomment-2227558470 I don't know why the build failed about macos-11, and no log for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] 代理模式控制台查看消费者---“终端”和"消费详情" 提示地址为空 [rocketmq-dashboard]

2024-07-14 Thread via GitHub
1294566108 commented on issue #221: URL: https://github.com/apache/rocketmq-dashboard/issues/221#issuecomment-2227625983 请确认下是否已经在proxy栏添加并选择了代理服务地址,或在application.yml文件配置了代理服务地址,例如 ![image](https://github.com/user-attachments/assets/f6add5b7-97f8-4eba-a270-e2a0177eca1f) -- This is

Re: [I] 代理模式控制台查看消费者---“终端”和"消费详情" 提示地址为空 [rocketmq-dashboard]

2024-07-14 Thread via GitHub
Changego commented on issue #221: URL: https://github.com/apache/rocketmq-dashboard/issues/221#issuecomment-2227726698 application.yml 是配置的。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] 代理模式控制台查看消费者---“终端”和"消费详情" 提示地址为空 [rocketmq-dashboard]

2024-07-14 Thread via GitHub
Changego commented on issue #221: URL: https://github.com/apache/rocketmq-dashboard/issues/221#issuecomment-2227733863 ![图片](https://github.com/user-attachments/assets/cb2e738c-ff84-40c5-87d1-fa7f3bb1a037) -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] 代理模式控制台查看消费者---“终端”和"消费详情" 提示地址为空 [rocketmq-dashboard]

2024-07-14 Thread via GitHub
1294566108 commented on issue #221: URL: https://github.com/apache/rocketmq-dashboard/issues/221#issuecomment-2227778131 > application.yml 是配置的。 确认下dashboard右上角是否已经切换版本到V5,再到proxy栏中update下试试 ![20240715-142243](https://github.com/user-attachments/assets/0f34768d-5fc1-4c84-82fb-9d31