(rocketmq-docker) branch master updated (cb46b84 -> 962ffc7)

2024-02-21 Thread lizhanhui
This is an automated email from the ASF dual-hosted git repository. lizhanhui pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/rocketmq-docker.git from cb46b84 Merge pull request #101 from zzjcool/feat/rmq5-docker add c00652a fix: use docker compose v

(rocketmq-docker) 01/01: Merge pull request #102 from lizhanhui/fix_script

2024-02-21 Thread lizhanhui
This is an automated email from the ASF dual-hosted git repository. lizhanhui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/rocketmq-docker.git commit 962ffc74b14867231e330a451f6671f587bf24cf Merge: cb46b84 c00652a Author: Zhanhui Li AuthorDate: Wed Feb 21 16

[GH] (rocketmq-clients): Workflow run "Rust Coverage" is working again!

2024-02-21 Thread GitBox
The GitHub Actions job "Rust Coverage" on rocketmq-clients.git has succeeded. Run started by GitHub user glcrazier (triggered by glcrazier). Head commit for run: 0871eb68242d5a8695429e947bad6126de561025 / qipingluo enable local-offset feature on time module Report URL: https://github.com/apach

Re: [PR] [rust] support handling settings command in Producer [rocketmq-clients]

2024-02-21 Thread via GitHub
codecov-commenter commented on PR #682: URL: https://github.com/apache/rocketmq-clients/pull/682#issuecomment-1956115310 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq-clients/pull/682?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm

[GH] (rocketmq-clients): Workflow run "Build" failed!

2024-02-21 Thread GitBox
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user glcrazier (triggered by glcrazier). Head commit for run: 0871eb68242d5a8695429e947bad6126de561025 / qipingluo enable local-offset feature on time module Report URL: https://github.com/apache/rocketmq-

[GH] (rocketmq-clients): Workflow run "Build" failed!

2024-02-21 Thread GitBox
The GitHub Actions job "Build" on rocketmq-clients.git has failed. Run started by GitHub user glcrazier (triggered by glcrazier). Head commit for run: c21112dcd505d871fc2707ecb1ce40df05fac9d1 / qipingluo use tokio RwLock instead of parking_lot version Report URL: https://github.com/apache/rock

[GH] (rocketmq-clients): Workflow run "Build" is working again!

2024-02-21 Thread GitBox
The GitHub Actions job "Build" on rocketmq-clients.git has succeeded. Run started by GitHub user glcrazier (triggered by glcrazier). Head commit for run: 77f4af84f74b5ba83622bfddee67bf32ae3355fa / qipingluo reformat code Report URL: https://github.com/apache/rocketmq-clients/actions/runs/79862

Re: [PR] [rust] support handling settings command in Producer [rocketmq-clients]

2024-02-21 Thread via GitHub
lizhanhui commented on code in PR #682: URL: https://github.com/apache/rocketmq-clients/pull/682#discussion_r1497165946 ## rust/src/producer.rs: ## @@ -118,7 +196,53 @@ impl Producer { Ok(()) } -fn transform_messages_to_protobuf( +async fn handle_recover_

Re: [PR] [rust] support handling settings command in Producer [rocketmq-clients]

2024-02-21 Thread via GitHub
glcrazier commented on code in PR #682: URL: https://github.com/apache/rocketmq-clients/pull/682#discussion_r1497177364 ## rust/src/producer.rs: ## @@ -118,7 +196,53 @@ impl Producer { Ok(()) } -fn transform_messages_to_protobuf( +async fn handle_recover_

Re: [PR] [4.9.x] Add validation in broker/namesrv configure updating command [rocketmq]

2024-02-21 Thread via GitHub
absolute8511 commented on code in PR #7649: URL: https://github.com/apache/rocketmq/pull/7649#discussion_r1497200242 ## broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java: ## @@ -522,6 +534,11 @@ private synchronized RemotingCommand updateBroker

Re: [PR] [4.9.x] Add validation in broker/namesrv configure updating command [rocketmq]

2024-02-21 Thread via GitHub
RongtongJin commented on code in PR #7649: URL: https://github.com/apache/rocketmq/pull/7649#discussion_r1497218316 ## broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java: ## @@ -522,6 +534,11 @@ private synchronized RemotingCommand updateBrokerC

Re: [PR] Hot reload ssl certificate [rocketmq-mqtt]

2024-02-21 Thread via GitHub
DongyuanPan commented on code in PR #238: URL: https://github.com/apache/rocketmq-mqtt/pull/238#discussion_r1497522276 ## mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/ssl/SslFactory.java: ## @@ -71,6 +76,55 @@ private void initSslContext() { } } +

Re: [PR] [rust] support handling settings command in Producer [rocketmq-clients]

2024-02-21 Thread via GitHub
lizhanhui commented on code in PR #682: URL: https://github.com/apache/rocketmq-clients/pull/682#discussion_r1497660393 ## rust/src/producer.rs: ## @@ -93,23 +116,80 @@ impl Producer { }; let logger = log::logger(option.logging_format()); let settings

Re: [PR] [rust] support handling settings command in Producer [rocketmq-clients]

2024-02-21 Thread via GitHub
glcrazier commented on code in PR #682: URL: https://github.com/apache/rocketmq-clients/pull/682#discussion_r1497689223 ## rust/src/producer.rs: ## @@ -93,23 +116,80 @@ impl Producer { }; let logger = log::logger(option.logging_format()); let settings

Re: [PR] [rust] support handling settings command in Producer [rocketmq-clients]

2024-02-21 Thread via GitHub
lizhanhui commented on code in PR #682: URL: https://github.com/apache/rocketmq-clients/pull/682#discussion_r1497711161 ## rust/src/producer.rs: ## @@ -93,23 +116,80 @@ impl Producer { }; let logger = log::logger(option.logging_format()); let settings

Re: [PR] [rust] support handling settings command in Producer [rocketmq-clients]

2024-02-21 Thread via GitHub
lizhanhui merged PR #682: URL: https://github.com/apache/rocketmq-clients/pull/682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@r

Re: [I] [Rust] failed to parse config at client.handle_telemetry_command sending messages [rocketmq-clients]

2024-02-21 Thread via GitHub
lizhanhui closed issue #634: [Rust] failed to parse config at client.handle_telemetry_command sending messages URL: https://github.com/apache/rocketmq-clients/issues/634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] [Bug] Rust client Failed to parse config at client.handle_telemetry_command [rocketmq-clients]

2024-02-21 Thread via GitHub
lizhanhui closed issue #598: [Bug] Rust client Failed to parse config at client.handle_telemetry_command URL: https://github.com/apache/rocketmq-clients/issues/598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

(rocketmq-clients) branch master updated: [rust] support handling settings command in Producer (#682)

2024-02-21 Thread lizhanhui
This is an automated email from the ASF dual-hosted git repository. lizhanhui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/rocketmq-clients.git The following commit(s) were added to refs/heads/master by this push: new 2eedee02 [rust] support handling se

[I] [Feature] Implement PushConsumer for Rust SDK [rocketmq-clients]

2024-02-21 Thread via GitHub
lizhanhui opened a new issue, #683: URL: https://github.com/apache/rocketmq-clients/issues/683 ### Programming Language of the Client Rust ### Is Your Feature Request Related to a Problem? We need to align features with Java/C++/... ### Describe the Solution You'd

[I] [Feature] Adopt tracing over slog for Rust SDK [rocketmq-clients]

2024-02-21 Thread via GitHub
lizhanhui opened a new issue, #684: URL: https://github.com/apache/rocketmq-clients/issues/684 ### Programming Language of the Client Rust ### Is Your Feature Request Related to a Problem? Tokio-tracing offers more intuitive observation, experience than what slog can, in

Re: [I] [Feature] Is python client development going well? [rocketmq-clients]

2024-02-21 Thread via GitHub
lizhanhui commented on issue #678: URL: https://github.com/apache/rocketmq-clients/issues/678#issuecomment-1956864250 To my knowledge, it's still at the alpha stage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[I] [Enhancement] Simplify the AbstractSendMessageProcessor#buildMsgContext code using Optional [rocketmq]

2024-02-21 Thread via GitHub
mxsm opened a new issue, #7845: URL: https://github.com/apache/rocketmq/issues/7845 ### Before Creating the Enhancement Request - [X] I have confirmed that this should be classified as an enhancement rather than a bug/feature. ### Summary ![image](https://github.com

[PR] [ISSUE #7845]implify the AbstractSendMessageProcessor#buildMsgContext code using Optional [rocketmq]

2024-02-21 Thread via GitHub
mxsm opened a new pull request, #7846: URL: https://github.com/apache/rocketmq/pull/7846 ### Which Issue(s) This PR Fixes Fixes #7845 ### Brief Description - Simplify the AbstractSendMessageProcessor#buildMsgContext code using Optional ### How

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-02-21 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user mxsm (triggered by mxsm). Head commit for run: 77e9915c8494dba616c4a0062127e5fdb7ab7e65 / mxsm [ISSUE #7845]implify the AbstractSendMessageProcessor#buildMsgContext code using Optional

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-02-21 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user mxsm (triggered by mxsm). Head commit for run: 0b05e9c7c13d1016057bd17dd12f4cc0238feb39 / mxsm [ISSUE #7840] Update the version in the README.md document to 5.2.0 (#7841) Report URL: https

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2024-02-21 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user mxsm (triggered by mxsm). Head commit for run: 77e9915c8494dba616c4a0062127e5fdb7ab7e65 / mxsm [ISSUE #7845]implify the AbstractSendMessageProcessor#buildMsgContext code using Optio

Re: [I] Polish some code in `ShutdownHookThread` [rocketmq]

2024-02-21 Thread via GitHub
github-actions[bot] commented on issue #6129: URL: https://github.com/apache/rocketmq/issues/6129#issuecomment-1958423913 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message

Re: [I] fix issues that could be null and optimize code [rocketmq]

2024-02-21 Thread via GitHub
github-actions[bot] commented on issue #6098: URL: https://github.com/apache/rocketmq/issues/6098#issuecomment-1958423965 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Dledger mode,before broker role change,first unregister metadata on nameserver [rocketmq]

2024-02-21 Thread via GitHub
github-actions[bot] commented on PR #3172: URL: https://github.com/apache/rocketmq/pull/3172#issuecomment-1958424026 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, pleas

Re: [I] getSystemTopicListFromBroker shoule contains topics which startwith rmq_sys_ [rocketmq]

2024-02-21 Thread via GitHub
github-actions[bot] commented on issue #6086: URL: https://github.com/apache/rocketmq/issues/6086#issuecomment-1958423993 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to t

Re: [I] getSystemTopicListFromBroker shoule contains topics which startwith rmq_sys_ [rocketmq]

2024-02-21 Thread via GitHub
github-actions[bot] closed issue #6086: getSystemTopicListFromBroker shoule contains topics which startwith rmq_sys_ URL: https://github.com/apache/rocketmq/issues/6086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [ISSUE#2949]delete the method of correctDeliverTimestamp in DeliverDelayedMessageTimerTask [rocketmq]

2024-02-21 Thread via GitHub
github-actions[bot] commented on PR #2959: URL: https://github.com/apache/rocketmq/pull/2959#issuecomment-1958424062 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, pleas

Re: [PR] [ISSUE #2931 ]fix and optimize methods for sending and storing batch message [rocketmq]

2024-02-21 Thread via GitHub
github-actions[bot] commented on PR #2932: URL: https://github.com/apache/rocketmq/pull/2932#issuecomment-1958424093 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, pleas

Re: [PR] [ISSUE#2819]fix: Synchronize the consumerOffset.json、delayOffset.json and subscriptionGroup.json using 10909 [rocketmq]

2024-02-21 Thread via GitHub
github-actions[bot] commented on PR #2829: URL: https://github.com/apache/rocketmq/pull/2829#issuecomment-1958424118 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, pleas

Re: [PR] [ISSUE #2476] Fix HaClient Infinite loop [rocketmq]

2024-02-21 Thread via GitHub
github-actions[bot] commented on PR #2487: URL: https://github.com/apache/rocketmq/pull/2487#issuecomment-1958424150 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, pleas

Re: [PR] [ISSUE #1938] Fix logical problem in latency fault strategy. [rocketmq]

2024-02-21 Thread via GitHub
github-actions[bot] commented on PR #1947: URL: https://github.com/apache/rocketmq/pull/1947#issuecomment-1958424171 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, pleas

Re: [PR] [ISSUE #1882] Support StartDeliverTime [rocketmq]

2024-02-21 Thread via GitHub
github-actions[bot] commented on PR #1874: URL: https://github.com/apache/rocketmq/pull/1874#issuecomment-1958424197 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, pleas

Re: [PR] [ISSUE #1605] use ThreadLocalRandom instead of Random [rocketmq]

2024-02-21 Thread via GitHub
github-actions[bot] commented on PR #1606: URL: https://github.com/apache/rocketmq/pull/1606#issuecomment-1958424220 This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, pleas

Re: [I] [Feature] Implement PushConsumer for Rust SDK [rocketmq-clients]

2024-02-21 Thread via GitHub
glcrazier commented on issue #683: URL: https://github.com/apache/rocketmq-clients/issues/683#issuecomment-1958471139 I'd like to take a shot. Is there anything required before I submit the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] [Feature] Implement PushConsumer for Rust SDK [rocketmq-clients]

2024-02-21 Thread via GitHub
lizhanhui commented on issue #683: URL: https://github.com/apache/rocketmq-clients/issues/683#issuecomment-1958510987 > I'd like to take a shot. Is there anything required before I submit the PR? Implementing this feature would result in a large change set, in order to make the devel

Re: [I] [Feature] Implement PushConsumer for Rust SDK [rocketmq-clients]

2024-02-21 Thread via GitHub
glcrazier commented on issue #683: URL: https://github.com/apache/rocketmq-clients/issues/683#issuecomment-1958527261 > > I'd like to take a shot. Is there anything required before I submit the PR? > > Implementing this feature would result in a large change set, in order to make th

Re: [I] [Bug] the consumer wouldn't receive msg when i set consumeGroup's retryTime as -1 [rocketmq]

2024-02-21 Thread via GitHub
leizhiyuan commented on issue #7842: URL: https://github.com/apache/rocketmq/issues/7842#issuecomment-1958577456 FIFO topic + FIFO consumer? this scene,will etry infinitely,do not set anything in consumerGroup config or normal topic,normal consumer -- This is an automated

Re: [I] [Bug] loop error of FlowMonitor in broker.log [rocketmq]

2024-02-21 Thread via GitHub
leizhiyuan commented on issue #7839: URL: https://github.com/apache/rocketmq/issues/7839#issuecomment-1958589760 2024-01-16 17:50:30 INFO ReadSocketService - join thread[FlowMonitor], elapsed time: 0ms, join time:9ms this log only printed in shutdown , and this is ha scene, you sh

Re: [PR] Support for ibm J9 [rocketmq]

2024-02-21 Thread via GitHub
yanhom1314 commented on PR #4267: URL: https://github.com/apache/rocketmq/pull/4267#issuecomment-1958611837 Can this PR be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Hot reload ssl certificate [rocketmq-mqtt]

2024-02-21 Thread via GitHub
pingww merged PR #238: URL: https://github.com/apache/rocketmq-mqtt/pull/238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketm

(rocketmq-mqtt) branch develop updated (0d51d3a -> 4331ec4)

2024-02-21 Thread pingww
This is an automated email from the ASF dual-hosted git repository. pingww pushed a change to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git from 0d51d3a Merge pull request #227 from EssinZhang/delete-logback-conflict add 6072ead feat: Hot reload s

(rocketmq-mqtt) 01/01: Merge pull request #238 from zzjcool/feat/on-ssl-cert-change

2024-02-21 Thread pingww
This is an automated email from the ASF dual-hosted git repository. pingww pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git commit 4331ec4b557e116cacede8f5729a14e1c3964212 Merge: 0d51d3a 6072ead Author: pingww AuthorDate: Thu Feb 22 15:23:29 2

[I] [Bug] Exception when pop messages with multiple LMQ indexes [rocketmq]

2024-02-21 Thread via GitHub
redlsz opened a new issue, #7848: URL: https://github.com/apache/rocketmq/issues/7848 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X] I hav

Re: [PR] [ISSUE #7565] Fix the issue of canceling scheduled tasks for discarde… [rocketmq]

2024-02-21 Thread via GitHub
lokistars commented on PR #7566: URL: https://github.com/apache/rocketmq/pull/7566#issuecomment-1958884385 > 错误测试: DefaultLitePullConsumerTest.unnecessary Mockito 存根 » UnnecessaryStubbing org.apache.rocketmq.client.consumer.DefaultMQPushConsumerTest.org.apache.rocketmq.client.consumer.Defau

Re: [I] [Bug] Exception when pop messages with multiple LMQ indexes [rocketmq]

2024-02-21 Thread via GitHub
redlsz commented on issue #7848: URL: https://github.com/apache/rocketmq/issues/7848#issuecomment-1958889091 https://github.com/apache/rocketmq/assets/103550934/397440df-9c83-4026-abb8-7b38baa7de09";> The property PROPERTY_INNER_MULTI_DISPATCH and PROPERTY_INNER_MULTI_QUEUE_OFFSET may

Re: [I] [Bug] the consumer wouldn't receive msg when i set consumeGroup's retryTime as -1 [rocketmq]

2024-02-21 Thread via GitHub
Yelijah commented on issue #7842: URL: https://github.com/apache/rocketmq/issues/7842#issuecomment-1958891202 > FIFO topic + FIFO consumer? > > this scene,will etry infinitely,do not set anything in consumerGroup config > > or normal topic,normal consumer FIFO topic + FIF