Re: [PR] [JAVA]only readable message queues are allowed to be assigned to push consumer [rocketmq-clients]

2024-01-11 Thread via GitHub
aaron-ai commented on code in PR #665: URL: https://github.com/apache/rocketmq-clients/pull/665#discussion_r1448452521 ## java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/PushConsumerImpl.java: ## @@ -389,6 +390,14 @@ public void onSuccess(Assignments late

Re: [PR] [JAVA]only readable message queues are allowed to be assigned to push consumer [rocketmq-clients]

2024-01-11 Thread via GitHub
glcrazier commented on code in PR #665: URL: https://github.com/apache/rocketmq-clients/pull/665#discussion_r1448457023 ## java/client/src/main/java/org/apache/rocketmq/client/java/impl/consumer/PushConsumerImpl.java: ## @@ -389,6 +390,14 @@ public void onSuccess(Assignments lat

Re: [PR] [JAVA]only readable message queues are allowed to be assigned to push consumer [rocketmq-clients]

2024-01-11 Thread via GitHub
aaron-ai commented on PR #665: URL: https://github.com/apache/rocketmq-clients/pull/665#issuecomment-1886647603 The queue returned by the server must always be readable, which is actually an agreement established with the server side. @drpmma please review whether this modification i

[I] update offset to broker success这个日志输出太多 [rocketmq-client-go]

2024-01-11 Thread via GitHub
WRAllen opened a new issue, #1127: URL: https://github.com/apache/rocketmq-client-go/issues/1127 每次看diamond里面的log,用到mq的pod看日志一次可以打三十几行的:update offset to broker success ![image](https://github.com/apache/rocketmq-client-go/assets/25947700/f1b207ce-b359-4eec-9cab-e9d7dd45b58b) 而且

[PR] [ISSUE #201] Fix (OOM) errors in Broker's pods when thet startup by accurately adhering to their allocated memory, rather than relying on the host's total memory. [rocketmq-operator]

2024-01-11 Thread via GitHub
MrLYG opened a new pull request, #210: URL: https://github.com/apache/rocketmq-operator/pull/210 ## What is the purpose of the change This update prevents Out-Of-Memory (OOM) errors in Broker's pods when they startup by accurately adhering to their allocated memory, rather than r

Re: [PR] [ISSUE #201] Fix (OOM) errors in Broker's pods when thet startup by accurately adhering to their allocated memory, rather than relying on the host's total memory. [rocketmq-operator]

2024-01-11 Thread via GitHub
MrLYG commented on PR #210: URL: https://github.com/apache/rocketmq-operator/pull/210#issuecomment-1886670944 fix https://github.com/apache/rocketmq-operator/issues/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

(rocketmq) 01/01: Revert "[ISSUE #7707] Refector Context with link node implementation (#7708)"

2024-01-11 Thread zhouxzhan
This is an automated email from the ASF dual-hosted git repository. zhouxzhan pushed a commit to branch revert-7708-feature/context in repository https://gitbox.apache.org/repos/asf/rocketmq.git commit dfd2cf9e74fcc4d8343bf52eb41ec22959357309 Author: Zhouxiang Zhan AuthorDate: Thu Jan 11 17:44:2

[PR] Revert "[ISSUE #7707] Refector Context with link node implementation" [rocketmq]

2024-01-11 Thread via GitHub
drpmma opened a new pull request, #7742: URL: https://github.com/apache/rocketmq/pull/7742 Reverts apache/rocketmq#7708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-01-11 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: dfd2cf9e74fcc4d8343bf52eb41ec22959357309 / Zhouxiang Zhan Revert "[ISSUE #7707] Refector Context with link node implementation (#7708

(rocketmq) branch revert-7708-feature/context created (now dfd2cf9e74)

2024-01-11 Thread zhouxzhan
This is an automated email from the ASF dual-hosted git repository. zhouxzhan pushed a change to branch revert-7708-feature/context in repository https://gitbox.apache.org/repos/asf/rocketmq.git at dfd2cf9e74 Revert "[ISSUE #7707] Refector Context with link node implementation (#7708)" T

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-01-11 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: 8a36471a19aea4a9052a2ad4508c9ed75ad0fe0d / Zhouxiang Zhan [ISSUE #7543] Add enableRetryTopicV2 brokerConfig (#7734) * Add enableRetryTop

Re: [I] Insufficient disk space but frequent alarms [rocketmq]

2024-01-11 Thread via GitHub
leizhiyuan commented on issue #7738: URL: https://github.com/apache/rocketmq/issues/7738#issuecomment-1886948508 可以看一下 1. 这个监控中的指标,是怎么获取的 2. 在上涨期间,可以观察一下第一个那个指标在机器上的那个对应的信息。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [I] [Bug] ConcurrentModificationException when acl changed [rocketmq]

2024-01-11 Thread via GitHub
leizhiyuan closed issue #7579: [Bug] ConcurrentModificationException when acl changed URL: https://github.com/apache/rocketmq/issues/7579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[PR] [ISSUE #7658] Fix bug of timer message metrics with setDelayTimeMs [rocketmq]

2024-01-11 Thread via GitHub
leizhiyuan opened a new pull request, #7743: URL: https://github.com/apache/rocketmq/pull/7743 ### Which Issue(s) This PR Fixes Fixes #7658 ### Brief Description ### How Did You Test This Change? -- This is an automated message from

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-01-11 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user leizhiyuan (triggered by leizhiyuan). Head commit for run: 7cf20eb8defa0365058b650c408e375acaee295c / leizhiyuan fix: fix bug of timer message metrics with setDelayTimeMs Report URL:

Re: [I] [Bug] Incorrect result otlp collect when send delay message [rocketmq]

2024-01-11 Thread via GitHub
leizhiyuan commented on issue #7658: URL: https://github.com/apache/rocketmq/issues/7658#issuecomment-1886973996 when get message type in brokermetrics, there losts PROPERTY_TIMER_DELAY_MS -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [ISSUE #7651] support to send trace for batchSend [rocketmq]

2024-01-11 Thread via GitHub
leizhiyuan commented on PR #7652: URL: https://github.com/apache/rocketmq/pull/7652#issuecomment-1886992109 LGTM There will be significant improvement in the performance of the trajectory. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2024-01-11 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user leizhiyuan (triggered by leizhiyuan). Head commit for run: 8a36471a19aea4a9052a2ad4508c9ed75ad0fe0d / Zhouxiang Zhan [ISSUE #7543] Add enableRetryTopicV2 brokerConfig (#7734) * Add enable

Re: [PR] [ISSUE #7658] Fix bug of timer message metrics with setDelayTimeMs [rocketmq]

2024-01-11 Thread via GitHub
codecov-commenter commented on PR #7743: URL: https://github.com/apache/rocketmq/pull/7743#issuecomment-1887033115 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7743?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [I] Insufficient disk space but frequent alarms [rocketmq]

2024-01-11 Thread via GitHub
1925747950 commented on issue #7738: URL: https://github.com/apache/rocketmq/issues/7738#issuecomment-1887345872 > 可以看一下 > > 1. 这个监控中的指标,是怎么获取的 > 2. 在上涨期间,可以观察一下第一个那个指标在机器上的那个对应的信息。 监控指标是基础磁盘指标,告警时登录服务器使用df命令查看/data占用接近500G,使用率也接近100%,但是使用du命令查看又只占用20G左右,等待磁盘达到100%后就立刻恢复成正常的

Re: [I] Insufficient disk space but frequent alarms [rocketmq]

2024-01-11 Thread via GitHub
leizhiyuan commented on issue #7738: URL: https://github.com/apache/rocketmq/issues/7738#issuecomment-1888143893 df和du统计对于已删除句柄但是还没有真正删除的有差异。当df统计到很大的时候。可以 lsof -n|grep deleted 看一下,参考 https://www.cnblogs.com/heyonggang/p/3644736.html HGQ ***@***.***> 于 2024年1月11日周四 下午10:5

Re: [I] Failed to examine pop consumer group status/progress/connection, no topic route for retry topic [rocketmq]

2024-01-11 Thread via GitHub
github-actions[bot] commented on issue #5844: URL: https://github.com/apache/rocketmq/issues/5844#issuecomment-1888166692 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message

Re: [I] set the value of order when create or update topic [rocketmq]

2024-01-11 Thread via GitHub
github-actions[bot] commented on issue #5860: URL: https://github.com/apache/rocketmq/issues/5860#issuecomment-1888166623 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message

[GH] (rocketmq): Workflow run "Snapshot Daily Release Automation" is working again!

2024-01-11 Thread GitBox
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has succeeded. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 8a36471a19aea4a9052a2ad4508c9ed75ad0fe0d / Zhouxiang Zhan [ISSUE #7543] Add enableRetryTopicV2 brokerConfig (#7734) *

Re: [PR] Revert "[ISSUE #7707] Refector Context with link node implementation" [rocketmq]

2024-01-11 Thread via GitHub
drpmma merged PR #7742: URL: https://github.com/apache/rocketmq/pull/7742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.a

(rocketmq) branch develop updated: Revert "[ISSUE #7707] Refector Context with link node implementation (#7708)" (#7742)

2024-01-11 Thread zhouxzhan
This is an automated email from the ASF dual-hosted git repository. zhouxzhan pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq.git The following commit(s) were added to refs/heads/develop by this push: new d2b818d993 Revert "[ISSUE #7707] Refector

(rocketmq) branch revert-7708-feature/context deleted (was dfd2cf9e74)

2024-01-11 Thread zhouxzhan
This is an automated email from the ASF dual-hosted git repository. zhouxzhan pushed a change to branch revert-7708-feature/context in repository https://gitbox.apache.org/repos/asf/rocketmq.git was dfd2cf9e74 Revert "[ISSUE #7707] Refector Context with link node implementation (#7708)" T

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-01-11 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d2b818d99366ad3ef8ba83d77780b7d15c318d13 / Zhouxiang Zhan Revert "[ISSUE #7707] Refector Context with link node implementation (#7708

[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2024-01-11 Thread GitBox
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d2b818d99366ad3ef8ba83d77780b7d15c318d13 / Zhouxiang Zhan Revert "[ISSUE #7707] Refector Context with link node implementation (#7708)" (#7742) This reve

[GH] (rocketmq): Workflow run "Coverage" failed!

2024-01-11 Thread GitBox
The GitHub Actions job "Coverage" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: d2b818d99366ad3ef8ba83d77780b7d15c318d13 / Zhouxiang Zhan Revert "[ISSUE #7707] Refector Context with link node implementation (#7708)" (#7742) This rev

Re: [PR] [ISSUE #7699] Add namespace v2 in client [rocketmq]

2024-01-11 Thread via GitHub
drpmma merged PR #7700: URL: https://github.com/apache/rocketmq/pull/7700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketmq.a

Re: [I] [Enhancement] Add namespace v2 in client [rocketmq]

2024-01-11 Thread via GitHub
drpmma closed issue #7699: [Enhancement] Add namespace v2 in client URL: https://github.com/apache/rocketmq/issues/7699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-01-11 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: b1d8d306a54321e1d729a095b7b6962776636dae / Zhouxiang Zhan [ISSUE #7699] Add namespace v2 in client (#7700) * Add namespace v2 * Add

[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2024-01-11 Thread GitBox
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: b1d8d306a54321e1d729a095b7b6962776636dae / Zhouxiang Zhan [ISSUE #7699] Add namespace v2 in client (#7700) * Add namespace v2 * Add NamespaceRpcHook * R

[GH] (rocketmq): Workflow run "Coverage" is working again!

2024-01-11 Thread GitBox
The GitHub Actions job "Coverage" on rocketmq.git has succeeded. Run started by GitHub user drpmma (triggered by drpmma). Head commit for run: b1d8d306a54321e1d729a095b7b6962776636dae / Zhouxiang Zhan [ISSUE #7699] Add namespace v2 in client (#7700) * Add namespace v2 * Add NamespaceRpcHook

Re: [I] [Bug] PopReviveService may revive incorrect message [rocketmq]

2024-01-11 Thread via GitHub
lizhimins commented on issue #7724: URL: https://github.com/apache/rocketmq/issues/7724#issuecomment-1888372936 描述的有点复杂,pop 消费的 ck 到期了,数据被清理, 此时 getBizMessage 拿到了 min offset 的消息,不一定满足 skip 的条件,导致 ck 产生 retry。 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [ISSUE #7658] Fix bug of timer message metrics with setDelayTimeMs [rocketmq]

2024-01-11 Thread via GitHub
RongtongJin merged PR #7743: URL: https://github.com/apache/rocketmq/pull/7743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocke

Re: [I] [Bug] Incorrect result otlp collect when send delay message [rocketmq]

2024-01-11 Thread via GitHub
RongtongJin closed issue #7658: [Bug] Incorrect result otlp collect when send delay message URL: https://github.com/apache/rocketmq/issues/7658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

(rocketmq) branch develop updated: [ISSUE #7658] Fix bug of timer message metrics with setDelayTimeMs

2024-01-11 Thread jinrongtong
This is an automated email from the ASF dual-hosted git repository. jinrongtong pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq.git The following commit(s) were added to refs/heads/develop by this push: new 50974adaaa [ISSUE #7658] Fix bug of ti

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-01-11 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user redlsz (triggered by lizhimins). Head commit for run: 87cb899c628c61bc1d28a7c6c734a6d2d330a326 / redlsz Fix revive incorrect message when the original message is not alive Report URL:

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-01-11 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 50974adaaa75200092a4bb7fad48c6a3d4c2b1ee / Lei Zhiyuan [ISSUE #7658] Fix bug of timer message metrics with setDelayTimeMs

[GH] (rocketmq): Workflow run "PUSH-CI" failed!

2024-01-11 Thread GitBox
The GitHub Actions job "PUSH-CI" on rocketmq.git has failed. Run started by GitHub user RongtongJin (triggered by RongtongJin). Head commit for run: 50974adaaa75200092a4bb7fad48c6a3d4c2b1ee / Lei Zhiyuan [ISSUE #7658] Fix bug of timer message metrics with setDelayTimeMs Report URL: https://gi

Re: [I] [Bug] 使用的rocketmq-client客户端,在github action中不消费或消费慢 [rocketmq-clients]

2024-01-11 Thread via GitHub
aaron-ai closed issue #664: [Bug] 使用的rocketmq-client客户端,在github action中不消费或消费慢 URL: https://github.com/apache/rocketmq-clients/issues/664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[I] When will the version containing the merged changes for this issue(#1102) be released? [rocketmq-client-go]

2024-01-11 Thread via GitHub
ONG-YA opened a new issue, #1128: URL: https://github.com/apache/rocketmq-client-go/issues/1128 The issue tracker is **ONLY** used for the go client (feature request of RocketMQ need to follow [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal)). Keep in mi

[PR] Support Springboot 3.X [rocketmq-spring]

2024-01-11 Thread via GitHub
accjiyun opened a new pull request, #611: URL: https://github.com/apache/rocketmq-spring/pull/611 ## What is the purpose of the change Support Springboot 3.X ## Brief changelog 1. Replace `@PostConstruct` with constructor 2. log format style 3. Springboot 3.x autoco

[GH] (rocketmq): Workflow run "Build and Run Tests by Bazel" failed!

2024-01-11 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has failed. Run started by GitHub user redlsz (triggered by redlsz). Head commit for run: 436e2ac42513114ebf6010cfca2e9bb384f01759 / redlsz Add comments Report URL: https://github.com/apache/rocketmq/actions/runs/7498820103

Re: [PR] Support Springboot 3.X [rocketmq-spring]

2024-01-11 Thread via GitHub
cserwen commented on PR #611: URL: https://github.com/apache/rocketmq-spring/pull/611#issuecomment-1888519520 @accjiyun 最好可以创建一个 issue ,描述下具体的问题 ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [ISSUE #7724] Fix revive incorrect message when the original message is not alive [rocketmq]

2024-01-11 Thread via GitHub
redlsz commented on PR #7739: URL: https://github.com/apache/rocketmq/pull/7739#issuecomment-1888529295 > CompletableFuture> future = getBizMessage(popCheckPoint.getTopic(), msgOffset, popCheckPoint.getQueueId(), popCheckPoint.getBrokerName()) > > 这里建议加个注释,Boolean 表示消费结果,false 时需要 re

[GH] (rocketmq): Workflow run "E2E test for pull request" is working again!

2024-01-11 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has succeeded. Run started by GitHub user redlsz (triggered by redlsz). Head commit for run: 50974adaaa75200092a4bb7fad48c6a3d4c2b1ee / Lei Zhiyuan [ISSUE #7658] Fix bug of timer message metrics with setDelayTimeMs Report URL

[I] Support Springboot 3.X [rocketmq-spring]

2024-01-11 Thread via GitHub
accjiyun opened a new issue, #612: URL: https://github.com/apache/rocketmq-spring/issues/612 1. Starting from Java 17, the `javax` package name prefix will be changed to `jakarta`. This means that our usage of `@PostConstruct` will not be compatible with both Java 8 and Java 17. Therefore,

Re: [PR] [ISSUE #612] Support Springboot 3.X [rocketmq-spring]

2024-01-11 Thread via GitHub
accjiyun commented on PR #611: URL: https://github.com/apache/rocketmq-spring/pull/611#issuecomment-1888535968 > @accjiyun 最好可以创建一个 issue ,描述下具体的问题 ~ https://github.com/apache/rocketmq-spring/issues/612 -- This is an automated message from the Apache Git Service. To respond to the m