Re: [PR] fix slave acting master bug [rocketmq]

2023-12-03 Thread via GitHub
gaoyf commented on code in PR #7603: URL: https://github.com/apache/rocketmq/pull/7603#discussion_r1413285830 ## store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java: ## @@ -1140,8 +1146,8 @@ public MessageExtBrokerInner convertMessage(MessageExt msgExt, b

Re: [PR] fix slave acting master bug [rocketmq]

2023-12-03 Thread via GitHub
gaoyf commented on code in PR #7603: URL: https://github.com/apache/rocketmq/pull/7603#discussion_r1413285830 ## store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java: ## @@ -1140,8 +1146,8 @@ public MessageExtBrokerInner convertMessage(MessageExt msgExt, b

Re: [PR] fix slave acting master bug [rocketmq]

2023-12-03 Thread via GitHub
gaoyf commented on code in PR #7603: URL: https://github.com/apache/rocketmq/pull/7603#discussion_r1413285830 ## store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java: ## @@ -1140,8 +1146,8 @@ public MessageExtBrokerInner convertMessage(MessageExt msgExt, b

Re: [PR] fix slave acting master bug [rocketmq]

2023-12-03 Thread via GitHub
gaoyf commented on code in PR #7603: URL: https://github.com/apache/rocketmq/pull/7603#discussion_r1413285830 ## store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java: ## @@ -1140,8 +1146,8 @@ public MessageExtBrokerInner convertMessage(MessageExt msgExt, b

Re: [PR] fix slave acting master bug [rocketmq]

2023-12-03 Thread via GitHub
gaoyf commented on code in PR #7603: URL: https://github.com/apache/rocketmq/pull/7603#discussion_r1413285830 ## store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java: ## @@ -1140,8 +1146,8 @@ public MessageExtBrokerInner convertMessage(MessageExt msgExt, b

[I] Inconsistent serviceAccountNames [rocketmq-operator]

2023-12-03 Thread via GitHub
sinloss opened a new issue, #196: URL: https://github.com/apache/rocketmq-operator/issues/196 **BUG REPORT** When trying to deploy the `rocketmq-operator` using the [chart](https://github.com/apache/rocketmq-operator/tree/master/charts/rocketmq-operator) , though rare, user may want

[PR] [ISSUE #196] Fix serviceAccountName inconsistency [rocketmq-operator]

2023-12-03 Thread via GitHub
sinloss opened a new pull request, #197: URL: https://github.com/apache/rocketmq-operator/pull/197 ## What is the purpose of the change Closes #196 ## Brief changelog Change the serviceAccountName in the `operator.yaml` to `{{ template "rocketmq-operator.serviceAccountN

[I] [Bug] Bug title [rocketmq]

2023-12-03 Thread via GitHub
smallemployees opened a new issue, #7610: URL: https://github.com/apache/rocketmq/issues/7610 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" is working again!

2023-12-03 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 956fdd8a32359344104851d15edaa79c17873ef4 / lizhimins <707364...@qq.com> [ISSUE #7585] Support message filtering in rocketmq ti

Re: [PR] [ISSUE #1112] feat: optimize producer send async [rocketmq-client-go]

2023-12-03 Thread via GitHub
ShannonDing merged PR #: URL: https://github.com/apache/rocketmq-client-go/pull/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

(rocketmq-client-go) branch master updated: [ISSUE #1112] feat: optimize producer send async (#1111)

2023-12-03 Thread dinglei
This is an automated email from the ASF dual-hosted git repository. dinglei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/rocketmq-client-go.git The following commit(s) were added to refs/heads/master by this push: new 7ffb599 [ISSUE #1112] feat: optimi

Re: [PR] [ISSUE #1114] fix: response future should close channel before callback [rocketmq-client-go]

2023-12-03 Thread via GitHub
ShannonDing merged PR #1113: URL: https://github.com/apache/rocketmq-client-go/pull/1113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

(rocketmq-client-go) branch master updated: fix: response future should close channel before callback (#1113)

2023-12-03 Thread dinglei
This is an automated email from the ASF dual-hosted git repository. dinglei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/rocketmq-client-go.git The following commit(s) were added to refs/heads/master by this push: new 3f9c59f fix: response future shoul

Re: [PR] fix WithRecover 无法recover问题 [rocketmq-client-go]

2023-12-03 Thread via GitHub
twz915 commented on PR #1074: URL: https://github.com/apache/rocketmq-client-go/pull/1074#issuecomment-1837775085 Previously, users could reassign the PanicHandler to their own handler, but now they can’t do it. Please keep the code compatible, thanks! -- This is an automated message

Re: [PR] Support Timing Messages with Arbitrary Time Delay.(#83) [rocketmq-apis]

2023-12-03 Thread via GitHub
echooymxq commented on PR #84: URL: https://github.com/apache/rocketmq-apis/pull/84#issuecomment-1837784542 @lizhanhui Sorry for late reply, really respect your wrok. As I understand it, like (JMS(ActiveMQ), the delivery_delay should be send to broker and the broker calculated the actually

[PR] [ISSUE #7545] Fix set mapped file to null cause file can not destroy [rocketmq]

2023-12-03 Thread via GitHub
lizhimins opened a new pull request, #7612: URL: https://github.com/apache/rocketmq/pull/7612 ### Which Issue(s) This PR Fixes Fixes #7545, Fix set mapped file to null cause file can not destroy in tiered storage index ### Brief Description ### Ho

[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2023-12-03 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: 65faea22fd54fd9875f2ca9d3088b4dc46d31cce / keranbingaa <397294...@qq.com> [ISSUE #7534] Use high performance concurrent set to replac

Re: [PR] [ISSUE #7545] Fix set mapped file to null cause file can not destroy [rocketmq]

2023-12-03 Thread via GitHub
codecov-commenter commented on PR #7612: URL: https://github.com/apache/rocketmq/pull/7612#issuecomment-1837805978 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7612?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2023-12-03 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: c9c80a5d49d57da0e9de6006d16679ec9b986a05 / lizhimins <707364...@qq.com> [ISSUE #7545] Fix set mapped file to null cause file can

Re: [PR] Delete logback1.2.3 version conflict [rocketmq-mqtt]

2023-12-03 Thread via GitHub
pingww merged PR #227: URL: https://github.com/apache/rocketmq-mqtt/pull/227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocketm

(rocketmq-mqtt) branch develop updated: delete logback1.2.3 version conflict

2023-12-03 Thread pingww
This is an automated email from the ASF dual-hosted git repository. pingww pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/rocketmq-mqtt.git The following commit(s) were added to refs/heads/develop by this push: new f66ecb0 delete logback1.2.3 version co

Re: [I] 项目升级rocketmq-client 5.1.4版本后,org.apache.rocketmq.mqtt.ds.store.LmqQueueStoreManager#maxOffset 方法,报throw new MQClientException("The broker[" + queue.getBrokerName() + "] not exist", null); [roc

2023-12-03 Thread via GitHub
DongyuanPan commented on issue #228: URL: https://github.com/apache/rocketmq-mqtt/issues/228#issuecomment-1837899458 下面这个逻辑也没走到吗? ![image](https://github.com/apache/rocketmq-mqtt/assets/18721508/47af0495-3af1-4a4a-9424-5ee54a1cb8f6) -- This is an automated message from the Apache G

Re: [PR] [ISSUE #103] Fix seek offset and deserialize bug in newSource [rocketmq-flink]

2023-12-03 Thread via GitHub
lizhimins merged PR #104: URL: https://github.com/apache/rocketmq-flink/pull/104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@roc

(rocketmq-flink) branch main updated: [ISSUE #103] Fix seek offset and deserialize bug in newSource (#104)

2023-12-03 Thread lizhimin
This is an automated email from the ASF dual-hosted git repository. lizhimin pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/rocketmq-flink.git The following commit(s) were added to refs/heads/main by this push: new 1576ae2 [ISSUE #103] Fix seek offset and

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2023-12-03 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lollipopjin). Head commit for run: c9c80a5d49d57da0e9de6006d16679ec9b986a05 / lizhimins <707364...@qq.com> [ISSUE #7545] Fix set mapped file to null cause file ca

Re: [PR] [ISSUE #7585] Support message filtering in rocketmq tiered storage [rocketmq]

2023-12-03 Thread via GitHub
lollipopjin commented on code in PR #7594: URL: https://github.com/apache/rocketmq/pull/7594#discussion_r1413322104 ## tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageFetcher.java: ## @@ -303,74 +270,94 @@ public CompletableFuture getMessageFromCacheAsync

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2023-12-03 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user lizhimins (triggered by lizhimins). Head commit for run: c9c80a5d49d57da0e9de6006d16679ec9b986a05 / lizhimins <707364...@qq.com> [ISSUE #7545] Fix set mapped file to null cause file can

Re: [PR] [ISSUE #7585] Support message filtering in rocketmq tiered storage [rocketmq]

2023-12-03 Thread via GitHub
lizhimins commented on code in PR #7594: URL: https://github.com/apache/rocketmq/pull/7594#discussion_r1413454902 ## tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageFetcher.java: ## @@ -303,74 +270,94 @@ public CompletableFuture getMessageFromCacheAsync(C

Re: [PR] [ISSUE #7585] Support message filtering in rocketmq tiered storage [rocketmq]

2023-12-03 Thread via GitHub
lizhimins commented on code in PR #7594: URL: https://github.com/apache/rocketmq/pull/7594#discussion_r1413454902 ## tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredMessageFetcher.java: ## @@ -303,74 +270,94 @@ public CompletableFuture getMessageFromCacheAsync(C

Re: [PR] [ISSUE #7263& ISSUE #7264]Fix to delete synchronously the consumption offset data of the subscription group on the standby node, when execute command 'mqadmin deleteSubGroup -b xxx -g xxx -r

2023-12-03 Thread via GitHub
frinda commented on PR #7273: URL: https://github.com/apache/rocketmq/pull/7273#issuecomment-1837987681 > I think the title might be too long, suggest renaming `[ISSUE xx& ISSUE xxx] Fix: xxx` It's been changed. Please submit it -- This is an automated message from the Apache Git S

Re: [PR] golang: optimize the logic of obtaining routing tasks [rocketmq-clients]

2023-12-03 Thread via GitHub
leizhiyuan commented on PR #580: URL: https://github.com/apache/rocketmq-clients/pull/580#issuecomment-1837994026 After running for a period of time, the consumer may encounter a timeout in the request routing table due to network fluctuations or other abnormal reasons. In previous versions

Re: [PR] [ISSUE #7263& ISSUE #7264]Fix to delete synchronously the consumption offset data of the subscription group on the standby node, when execute command 'mqadmin deleteSubGroup -b xxx -g xxx -r

2023-12-03 Thread via GitHub
iamgd67 commented on PR #7273: URL: https://github.com/apache/rocketmq/pull/7273#issuecomment-1837998805 > > I think the title might be too long, suggest renaming `[ISSUE xx& ISSUE xxx] Fix: xxx` > > @ joeCarf It's been changed. Please submit it,Thanks still too long, maybe thi

[I] [Bug] Consumer still consume new message but the offset of two queues always keep the old value [rocketmq]

2023-12-03 Thread via GitHub
tongtaodragon opened a new issue, #7613: URL: https://github.com/apache/rocketmq/issues/7613 ### Before Creating the Bug Report - [X] I found a bug, not just asking a question, which should be created in [GitHub Discussions](https://github.com/apache/rocketmq/discussions). - [X