[GH] (rocketmq): Workflow run "E2E test for pull request" failed!

2023-12-01 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user gaoyf (triggered by gaoyf). Head commit for run: 65faea22fd54fd9875f2ca9d3088b4dc46d31cce / keranbingaa <397294...@qq.com> [ISSUE #7534] Use high performance concurrent set to replace copyon

Re: [PR] lock.lock() before try [rocketmq]

2023-12-01 Thread via GitHub
lizhimins commented on PR #7582: URL: https://github.com/apache/rocketmq/pull/7582#issuecomment-1835656950 在外面没什么问题。参考:https://juejin.cn/post/7269962653795270671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] fix slave acting master bug [rocketmq]

2023-12-01 Thread via GitHub
codecov-commenter commented on PR #7603: URL: https://github.com/apache/rocketmq/pull/7603#issuecomment-1835658936 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7603?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] lock.lock() before try [rocketmq]

2023-12-01 Thread via GitHub
joeCarf commented on PR #7582: URL: https://github.com/apache/rocketmq/pull/7582#issuecomment-1835661113 > 在外面没什么问题。参考:https://juejin.cn/post/7269962653795270671 原写法是写到里面了,这个pr是改到外面的 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] lock.lock() before try [rocketmq]

2023-12-01 Thread via GitHub
shenjianeng commented on PR #7582: URL: https://github.com/apache/rocketmq/pull/7582#issuecomment-1835681345 > 在外面没什么问题。参考:https://juejin.cn/post/7269962653795270671 看下 jdk 的官方文档建议吧,https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/locks/ReentrantLock.html > It is

[GH] (rocketmq): Workflow run "Build and Run Tests by Maven" failed!

2023-12-01 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has failed. Run started by GitHub user gaoyf (triggered by gaoyf). Head commit for run: 350962115900b3c376395c354f8f4881c5fa205d / yongfeigao fix timerCheckPoint of the master is not updated, causing the timer message to be

[I] 项目升级rocketmq-client 5.1.4版本后,org.apache.rocketmq.mqtt.ds.store.LmqQueueStoreManager#maxOffset 方法,报throw new MQClientException("The broker[" + queue.getBrokerName() + "] not exist", null); [rocketm

2023-12-01 Thread via GitHub
lzkisok opened a new issue, #228: URL: https://github.com/apache/rocketmq-mqtt/issues/228 原因如下: ![image](https://github.com/apache/rocketmq-mqtt/assets/24490175/42f8170f-4720-4e6b-926c-8f62b02e95cd) 如上图,获取不到brokerAddr 更近一步的原因是: ![image](https://github.com/apache/rocketmq-mqtt/as

Re: [I] 项目升级rocketmq-client 5.1.4版本后,org.apache.rocketmq.mqtt.ds.store.LmqQueueStoreManager#maxOffset 方法,报throw new MQClientException("The broker[" + queue.getBrokerName() + "] not exist", null); [roc

2023-12-01 Thread via GitHub
lzkisok commented on issue #228: URL: https://github.com/apache/rocketmq-mqtt/issues/228#issuecomment-1835810291 ![image](https://github.com/apache/rocketmq-mqtt/assets/24490175/706ab426-168f-4fba-976c-5ab748291554) 请问目前我的解决办法是否够优雅? -- This is an automated message from the Apache G

Re: [I] [RIP-68] RocketMQ ACL 2.0 [rocketmq]

2023-12-01 Thread via GitHub
echooymxq commented on issue #7560: URL: https://github.com/apache/rocketmq/issues/7560#issuecomment-1835936073 @dingshuangxi888 The namesrv not stateless actually. such as in controller mode, maybe the controller mode is special case. but there's some kvConfig.json about orderConf, and ro

[I] Support Timing Messages with Arbitrary Time Delay. [rocketmq-apis]

2023-12-01 Thread via GitHub
echooymxq opened a new issue, #83: URL: https://github.com/apache/rocketmq-apis/issues/83 When there are clock issues on the client and server side, it can cause timer message deliver not correct. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [I] Support Timing Messages with Arbitrary Time Delay. [rocketmq-apis]

2023-12-01 Thread via GitHub
fanlunyong commented on issue #83: URL: https://github.com/apache/rocketmq-apis/issues/83#issuecomment-1836368538 这是来自QQ邮箱的自动回复邮件。   您好,请您放心您的邮件我已经收到。我将在看过邮件后,尽快给您回复。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[PR] Support Timing Messages with Arbitrary Time Delay.(#83) [rocketmq-apis]

2023-12-01 Thread via GitHub
echooymxq opened a new pull request, #84: URL: https://github.com/apache/rocketmq-apis/pull/84 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[I] [Feature] Support Timing Messages with Arbitrary Time Delay. [rocketmq-clients]

2023-12-01 Thread via GitHub
echooymxq opened a new issue, #643: URL: https://github.com/apache/rocketmq-clients/issues/643 ### Programming Language of the Client Not related to the specified programming language ### Is Your Feature Request Related to a Problem? When there are clock issues on the cli

Re: [I] [Feature] Support Timing Messages with Arbitrary Time Delay. [rocketmq-clients]

2023-12-01 Thread via GitHub
echooymxq commented on issue #643: URL: https://github.com/apache/rocketmq-clients/issues/643#issuecomment-1836425287 link https://github.com/apache/rocketmq-apis/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[PR] Trigger a build for rocketmq [rocketmq]

2023-12-01 Thread via GitHub
Aishwarya-Lad opened a new pull request, #7605: URL: https://github.com/apache/rocketmq/pull/7605 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description ### How Did You Test This Change? -- This is an automated messag

Re: [PR] Trigger a build for rocketmq [rocketmq]

2023-12-01 Thread via GitHub
Aishwarya-Lad closed pull request #7605: Trigger a build for rocketmq URL: https://github.com/apache/rocketmq/pull/7605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] Test ti pr 2 [rocketmq]

2023-12-01 Thread via GitHub
Aishwarya-Lad opened a new pull request, #7606: URL: https://github.com/apache/rocketmq/pull/7606 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description ### How Did You Test This Change? -- This is an automated messag

Re: [PR] Support Timing Messages with Arbitrary Time Delay.(#83) [rocketmq-apis]

2023-12-01 Thread via GitHub
lizhanhui commented on PR #84: URL: https://github.com/apache/rocketmq-apis/pull/84#issuecomment-1837001012 It's true that there is some nuance between delay-delivery-message and scheduled-message when time source is considered. But, IMO, we may offer two API for them using the same underl

Re: [I] [Feature] Support Timing Messages with Arbitrary Time Delay. [rocketmq-clients]

2023-12-01 Thread via GitHub
lizhanhui commented on issue #643: URL: https://github.com/apache/rocketmq-clients/issues/643#issuecomment-1837001863 @echooymxq Left a message [here](https://github.com/apache/rocketmq-apis/pull/84#issuecomment-1837001012) and look forward to your feedback -- This is an automated messa

Re: [PR] fix slave acting master bug [rocketmq]

2023-12-01 Thread via GitHub
joeCarf commented on code in PR #7603: URL: https://github.com/apache/rocketmq/pull/7603#discussion_r1412724350 ## store/src/main/java/org/apache/rocketmq/store/timer/TimerMessageStore.java: ## @@ -1140,8 +1146,8 @@ public MessageExtBrokerInner convertMessage(MessageExt msgExt,