Re: [I] An unstable unit test: BrokerOuterAPITest.test_needRegister_timeout [rocketmq]

2023-10-03 Thread via GitHub
ashutosh-roy commented on issue #6654: URL: https://github.com/apache/rocketmq/issues/6654#issuecomment-1744343253 Hi @zhouxinyu , Couldn't reproduce this scenario in my local. This test is passing. https://github.com/apache/rocketmq/assets/44959785/f8a9d058-c2b3-4f84-bf22-15fe4cbccb6

Re: [PR] [ISSUE #7300] jRaft-Controller Implemention [rocketmq]

2023-10-03 Thread via GitHub
joeCarf commented on code in PR #7301: URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1343790397 ## common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java: ## @@ -24,7 +24,9 @@ public class ControllerConfig { private String rocketmqHome = Sy

Re: [PR] [ISSUE #7300] jRaft-Controller Implemention [rocketmq]

2023-10-03 Thread via GitHub
joeCarf commented on code in PR #7301: URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1343917297 ## controller/src/main/java/org/apache/rocketmq/controller/Controller.java: ## @@ -17,21 +17,21 @@ package org.apache.rocketmq.controller; -import java.util.List;

Re: [I] Broker may lost messages in extreme condition [rocketmq]

2023-10-03 Thread via GitHub
github-actions[bot] commented on issue #5235: URL: https://github.com/apache/rocketmq/issues/5235#issuecomment-1745915624 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message

[GitHub] [rocketmq]: Workflow run "Snapshot Daily Release Automation" failed!

2023-10-03 Thread GitBox
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 4f1b42a7c5557bcadd6b9982a0c9bd876622c69e / ShuangxiDing [ISSUE #7410] Handle the Exception when the Proxy requests the cli

Re: [PR] [ISSUE #7300] jRaft-Controller Implemention [rocketmq]

2023-10-03 Thread via GitHub
yulangz commented on code in PR #7301: URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1345151334 ## controller/src/main/java/org/apache/rocketmq/controller/impl/DLedgerControllerStateMachine.java: ## @@ -21,14 +21,15 @@ import io.openmessaging.storage.dledger.sna

Re: [PR] [ISSUE #7300] jRaft-Controller Implemention [rocketmq]

2023-10-03 Thread via GitHub
yulangz commented on code in PR #7301: URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1345151684 ## controller/src/main/java/org/apache/rocketmq/controller/impl/DLedgerController.java: ## @@ -303,7 +303,7 @@ private boolean appendToDLedgerAndWait(final AppendEntr

Re: [PR] [ISSUE #7300] jRaft-Controller Implemention [rocketmq]

2023-10-03 Thread via GitHub
yulangz commented on code in PR #7301: URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1345153126 ## common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java: ## @@ -24,7 +24,9 @@ public class ControllerConfig { private String rocketmqHome = Sy

Re: [PR] [ISSUE #7300] jRaft-Controller Implemention [rocketmq]

2023-10-03 Thread via GitHub
yulangz commented on code in PR #7301: URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1345153306 ## controller/src/main/java/org/apache/rocketmq/controller/ControllerStartup.java: ## @@ -16,12 +16,6 @@ */ package org.apache.rocketmq.controller; -import java.i

Re: [PR] [ISSUE #7300] jRaft-Controller Implemention [rocketmq]

2023-10-03 Thread via GitHub
joeCarf commented on code in PR #7301: URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1345232848 ## controller/src/main/java/org/apache/rocketmq/controller/ControllerStartup.java: ## @@ -16,12 +16,6 @@ */ package org.apache.rocketmq.controller; -import java.i

Re: [PR] [ISSUE #7300] jRaft-Controller Implemention [rocketmq]

2023-10-03 Thread via GitHub
joeCarf commented on code in PR #7301: URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1345233062 ## common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java: ## @@ -24,7 +24,9 @@ public class ControllerConfig { private String rocketmqHome = Sy

Re: [PR] [ISSUE 7265] Doc: Adding how to debug in Idea document [rocketmq]

2023-10-03 Thread via GitHub
joeCarf commented on PR #7266: URL: https://github.com/apache/rocketmq/pull/7266#issuecomment-1746240402 > 也来个英语版? Good idea! I will work on it these days -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL