[GitHub] [rocketmq] xdkxlk commented on a diff in pull request #7209: [ISSUE #7208] fix: when deleting topic also delete its pop retry topic

2023-08-18 Thread via GitHub
xdkxlk commented on code in PR #7209: URL: https://github.com/apache/rocketmq/pull/7209#discussion_r1298108056 ## common/src/main/java/org/apache/rocketmq/common/KeyBuilder.java: ## @@ -31,6 +31,13 @@ public static String parseNormalTopic(String topic, String cid) { }

[GitHub] [rocketmq-operator] caigy merged pull request #169: [ISSUE #168] Upload auto generated files for third-party reference

2023-08-18 Thread via GitHub
caigy merged PR #169: URL: https://github.com/apache/rocketmq-operator/pull/169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rock

[rocketmq-operator] branch master updated: [ISSUE #168] Upload auto generated files for third-party reference (#169)

2023-08-18 Thread caigy
This is an automated email from the ASF dual-hosted git repository. caigy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/rocketmq-operator.git The following commit(s) were added to refs/heads/master by this push: new ad72466 [ISSUE #168] Upload auto gene

[GitHub] [rocketmq-operator] caigy closed issue #168: got error when import pkg/apis/rocketmq to get broker list

2023-08-18 Thread via GitHub
caigy closed issue #168: got error when import pkg/apis/rocketmq to get broker list URL: https://github.com/apache/rocketmq-operator/issues/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [rocketmq] yx9o opened a new pull request, #7210: [ISSUE #7166] Optimize the display format of admin

2023-08-18 Thread via GitHub
yx9o opened a new pull request, #7210: URL: https://github.com/apache/rocketmq/pull/7210 Fixes #7166, optimize the display format of admin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [rocketmq]: Workflow run "Build and Run Tests by Bazel" is working again!

2023-08-18 Thread GitBox
The GitHub Actions job "Build and Run Tests by Bazel" on rocketmq.git has succeeded. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: 313d357f877cf7c129008cdbecd400d7e8f9fba6 / yx9o [ISSUE #7166] Optimize the display format of admin Report URL: https://github.com/apac

[GitHub] [rocketmq] codecov-commenter commented on pull request #7210: [ISSUE #7166] Optimize the display format of admin

2023-08-18 Thread via GitHub
codecov-commenter commented on PR #7210: URL: https://github.com/apache/rocketmq/pull/7210#issuecomment-1684030659 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7210?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[GitHub] [rocketmq]: Workflow run "E2E test for pull request" failed!

2023-08-18 Thread GitBox
The GitHub Actions job "E2E test for pull request" on rocketmq.git has failed. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: 72d796f2b20b3ec6aebca8c004d9275d7c749a95 / lk [ISSUE #7205] support batch ack for pop orderly (#7206) Report URL: https://github.com/apache/r

[GitHub] [rocketmq]: Workflow run "Build and Run Tests by Maven" is working again!

2023-08-18 Thread GitBox
The GitHub Actions job "Build and Run Tests by Maven" on rocketmq.git has succeeded. Run started by GitHub user yx9o (triggered by yx9o). Head commit for run: 313d357f877cf7c129008cdbecd400d7e8f9fba6 / yx9o [ISSUE #7166] Optimize the display format of admin Report URL: https://github.com/apac

[GitHub] [rocketmq-spring] texousliu opened a new issue, #583: 使用starter的时候需要自定义全局拦截器在 listener onMessage 之前处理 MessageExt

2023-08-18 Thread via GitHub
texousliu opened a new issue, #583: URL: https://github.com/apache/rocketmq-spring/issues/583 **FEATURE REQUEST** 1. 使用starter的时候需要自定义全局拦截器在 listener onMessage 之前处理 MessageExt 2. Provide any additional detail on your proposed use case for this feature. 3. 添加message处理器 ```java

[GitHub] [rocketmq-spring] texousliu commented on issue #583: 使用starter的时候需要自定义全局拦截器在 listener onMessage 之前处理 MessageExt

2023-08-18 Thread via GitHub
texousliu commented on issue #583: URL: https://github.com/apache/rocketmq-spring/issues/583#issuecomment-1684155418 我觉得这是一个比较重要的功能,在获取消息之后能够全局拦截并预先处理。比如说:需要全链路追踪的时候,可以通过这个扩展拦截器处理额外的信息到 context 中 -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [rocketmq-spring] texousliu commented on issue #583: 使用starter的时候需要自定义全局拦截器在 listener onMessage 之前处理 MessageExt

2023-08-18 Thread via GitHub
texousliu commented on issue #583: URL: https://github.com/apache/rocketmq-spring/issues/583#issuecomment-1684157276 因为我在 starter 的源代码中没有看到相关的扩展接口,如果需要强制实现的话需要重写 `ListenerContainerConfiguration`,我认为这是不太友好的方式 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [rocketmq]: Workflow run "Snapshot Daily Release Automation" failed!

2023-08-18 Thread GitBox
The GitHub Actions job "Snapshot Daily Release Automation" on rocketmq.git has failed. Run started by GitHub user lizhanhui (triggered by lizhanhui). Head commit for run: 72d796f2b20b3ec6aebca8c004d9275d7c749a95 / lk [ISSUE #7205] support batch ack for pop orderly (#7206) Report URL: https://