RongtongJin merged PR #750:
URL: https://github.com/apache/rocketmq-clients/pull/750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...
guyinyou commented on code in PR #750:
URL: https://github.com/apache/rocketmq-clients/pull/750#discussion_r1601244958
##
nodejs/src/consumer/SimpleConsumer.ts:
##
@@ -60,8 +60,11 @@ export class SimpleConsumer extends Consumer {
}
}
this.#awaitDuration = option
fengmk2 commented on PR #750:
URL: https://github.com/apache/rocketmq-clients/pull/750#issuecomment-2109907570
@zhaohai666 codecov 服务最近无法工作了，可以删除它
https://github.com/apache/rocketmq-clients/blob/master/.github/workflows/nodejs_coverage.yml#L40
--
This is an automated message from the Apac
fengmk2 commented on code in PR #750:
URL: https://github.com/apache/rocketmq-clients/pull/750#discussion_r1597398731
##
nodejs/src/client/Settings.ts:
##
@@ -20,15 +20,17 @@ import { Endpoints } from '../route/Endpoints';
import { RetryPolicy } from '../retry';
export abstr
fengmk2 commented on code in PR #750:
URL: https://github.com/apache/rocketmq-clients/pull/750#discussion_r1597398596
##
nodejs/src/client/BaseClient.ts:
##
@@ -76,6 +77,7 @@ export abstract class BaseClient {
readonly clientType = ClientType.CLIENT_TYPE_UNSPECIFIED;
reado
