Re: [PR] [rust] implement pushconsumer [rocketmq-clients]

2024-08-08 Thread via GitHub
lizhanhui merged PR #767: URL: https://github.com/apache/rocketmq-clients/pull/767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@r

Re: [PR] [rust] implement pushconsumer [rocketmq-clients]

2024-08-06 Thread via GitHub
ShadowySpirits commented on code in PR #767: URL: https://github.com/apache/rocketmq-clients/pull/767#discussion_r1705444520 ## .github/workflows/rust_build.yml: ## @@ -45,27 +52,26 @@ jobs: with: toolchain: stable - name: Build doc -working-di

Re: [PR] [rust] implement pushconsumer [rocketmq-clients]

2024-08-06 Thread via GitHub
lizhanhui commented on PR #767: URL: https://github.com/apache/rocketmq-clients/pull/767#issuecomment-2271053671 MSRV set to 1.61 does not make sense run cargo msrv, we are having https://github.com/user-attachments/assets/483a539c-ebfd-4018-92b0-d2df88af9b15";> -- This is an a

Re: [PR] [rust] implement pushconsumer [rocketmq-clients]

2024-08-06 Thread via GitHub
lizhanhui commented on code in PR #767: URL: https://github.com/apache/rocketmq-clients/pull/767#discussion_r1705339663 ## rust/src/push_consumer.rs: ## @@ -0,0 +1,1303 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreemen

Re: [PR] [rust] implement pushconsumer [rocketmq-clients]

2024-07-22 Thread via GitHub
codecov-commenter commented on PR #767: URL: https://github.com/apache/rocketmq-clients/pull/767#issuecomment-2244109529 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq-clients/pull/767?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campai

Re: [PR] [rust] implement pushconsumer [rocketmq-clients]

2024-07-20 Thread via GitHub
glcrazier commented on code in PR #767: URL: https://github.com/apache/rocketmq-clients/pull/767#discussion_r1685358315 ## rust/src/push_consumer.rs: ## @@ -0,0 +1,1303 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreemen

Re: [PR] [rust] implement pushconsumer [rocketmq-clients]

2024-07-20 Thread via GitHub
glcrazier commented on code in PR #767: URL: https://github.com/apache/rocketmq-clients/pull/767#discussion_r1685358156 ## rust/src/push_consumer.rs: ## @@ -0,0 +1,1303 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreemen