drpmma merged PR #7544:
URL: https://github.com/apache/rocketmq/pull/7544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.a
drpmma commented on PR #7544:
URL: https://github.com/apache/rocketmq/pull/7544#issuecomment-1823785333
> Can the forward slash be used for folders in Linux? The "topic" of Pop
ultimately ends up as a folder on the machine?
>
> Or, in other words, is the design utilizing a multi-level
leizhiyuan commented on PR #7544:
URL: https://github.com/apache/rocketmq/pull/7544#issuecomment-1803315774
Can the forward slash be used for folders in Linux? The "topic" of Pop
ultimately ends up as a folder on the machine?
Or is it talking about the modification that relies on rock
drpmma commented on PR #7544:
URL: https://github.com/apache/rocketmq/pull/7544#issuecomment-1803280259
> We need to consider the modifications from #7208 in order to ensure
compatibility.
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message,
codecov-commenter commented on PR #7544:
URL: https://github.com/apache/rocketmq/pull/7544#issuecomment-1801415211
##
[Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7544?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
RongtongJin commented on code in PR #7544:
URL: https://github.com/apache/rocketmq/pull/7544#discussion_r1386221982
##
common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java:
##
@@ -223,6 +223,8 @@ public class BrokerConfig extends BrokerIdentity {
private boolea
xdkxlk commented on PR #7544:
URL: https://github.com/apache/rocketmq/pull/7544#issuecomment-1798027448
We need to consider the modifications from #7208 in order to ensure
compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on