Re: [PR] [ISSUE #7437] Add the CRC check of commitlog [rocketmq]

2023-10-24 Thread via GitHub
RongtongJin merged PR #7468: URL: https://github.com/apache/rocketmq/pull/7468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocke

Re: [PR] [ISSUE #7437] Add the CRC check of commitlog [rocketmq]

2023-10-24 Thread via GitHub
codecov-commenter commented on PR #7468: URL: https://github.com/apache/rocketmq/pull/7468#issuecomment-1778517415 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [ISSUE #7437] Add the CRC check of commitlog [rocketmq]

2023-10-24 Thread via GitHub
guyinyou commented on PR #7468: URL: https://github.com/apache/rocketmq/pull/7468#issuecomment-1778403089 > Add some UTs done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [ISSUE #7437] Add the CRC check of commitlog [rocketmq]

2023-10-24 Thread via GitHub
guyinyou commented on code in PR #7468: URL: https://github.com/apache/rocketmq/pull/7468#discussion_r1371065944 ## store/src/main/java/org/apache/rocketmq/store/CommitLog.java: ## @@ -61,7 +61,6 @@ import org.apache.rocketmq.store.logfile.MappedFile; import org.apache.rocketm

Re: [PR] [ISSUE #7437] Add the CRC check of commitlog [rocketmq]

2023-10-20 Thread via GitHub
joeCarf commented on code in PR #7468: URL: https://github.com/apache/rocketmq/pull/7468#discussion_r1367675718 ## store/src/main/java/org/apache/rocketmq/store/CommitLog.java: ## @@ -61,7 +61,6 @@ import org.apache.rocketmq.store.logfile.MappedFile; import org.apache.rocketmq

Re: [PR] [ISSUE #7437] Add the CRC check of commitlog [rocketmq]

2023-10-16 Thread via GitHub
guyinyou closed pull request #7438: [ISSUE #7437] Add the CRC check of commitlog URL: https://github.com/apache/rocketmq/pull/7438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme