RongtongJin merged PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocke
RongtongJin commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1469476925
##
WORKSPACE:
##
@@ -107,6 +107,8 @@ maven_install(
"com.adobe.testing:s3mock-junit4:2.11.0",
"io.github.aliyunmq:rocketmq-grpc-netty-codec-hapro
RongtongJin commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1425024512
##
common/src/main/java/org/apache/rocketmq/common/JraftConfig.java:
##
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
leizhiyuan commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1415553072
##
controller/src/main/resources/rmq.controller.logback.xml:
##
@@ -41,7 +44,9 @@
${user.home}${file.separator}logs${file.separator}rocketmqlogs${file.sep
leizhiyuan commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1415552573
##
controller/src/main/java/org/apache/rocketmq/controller/impl/JRaftController.java:
##
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
leizhiyuan commented on PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#issuecomment-1840708569
I will take over this pull request later.
cc @yulangz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
leizhiyuan commented on PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#issuecomment-1840695660
> Hello, I am replicating and enhancing the jraft experiment. I would like
to consult you on the following questions:您好，我正在复制和增强 jraft 实验。我想就以下问题咨询您：
>
> 1. In your experiment,
RongtongJin commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1396960356
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -67,6 +68,13 @@ public class ControllerConfig {
*/
private long scanInac
GenerousMan commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1398938302
##
controller/src/main/java/org/apache/rocketmq/controller/impl/heartbeat/RaftBrokerHeartBeatManager.java:
##
@@ -0,0 +1,261 @@
+/*
+ * Licensed to the Apache Soft
GenerousMan commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1396767643
##
controller/src/main/java/org/apache/rocketmq/controller/impl/JRaftController.java:
##
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
GenerousMan commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1396767331
##
controller/src/main/java/org/apache/rocketmq/controller/impl/JRaftController.java:
##
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
GenerousMan commented on PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#issuecomment-1807512518
Hello, I am replicating and enhancing the jraft experiment. I would like to
consult you on the following questions:
1. In your experiment, are the controller, broker, etc. all
yulangz commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1349962801
##
example/src/main/java/org/apache/rocketmq/example/quickstart/Producer.java:
##
@@ -30,7 +30,7 @@ public class Producer {
/**
* The number of produced mes
joeCarf commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1349626480
##
example/src/main/java/org/apache/rocketmq/example/quickstart/Producer.java:
##
@@ -30,7 +30,7 @@ public class Producer {
/**
* The number of produced mes
joeCarf commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1345233062
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -24,7 +24,9 @@ public class ControllerConfig {
private String rocketmqHome =
Sy
joeCarf commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1345232848
##
controller/src/main/java/org/apache/rocketmq/controller/ControllerStartup.java:
##
@@ -16,12 +16,6 @@
*/
package org.apache.rocketmq.controller;
-import java.i
yulangz commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1345153306
##
controller/src/main/java/org/apache/rocketmq/controller/ControllerStartup.java:
##
@@ -16,12 +16,6 @@
*/
package org.apache.rocketmq.controller;
-import java.i
yulangz commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1345153126
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -24,7 +24,9 @@ public class ControllerConfig {
private String rocketmqHome =
Sy
yulangz commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1345151684
##
controller/src/main/java/org/apache/rocketmq/controller/impl/DLedgerController.java:
##
@@ -303,7 +303,7 @@ private boolean appendToDLedgerAndWait(final
AppendEntr
yulangz commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1345151334
##
controller/src/main/java/org/apache/rocketmq/controller/impl/DLedgerControllerStateMachine.java:
##
@@ -21,14 +21,15 @@
import io.openmessaging.storage.dledger.sna
joeCarf commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1343917297
##
controller/src/main/java/org/apache/rocketmq/controller/Controller.java:
##
@@ -17,21 +17,21 @@
package org.apache.rocketmq.controller;
-import java.util.List;
joeCarf commented on code in PR #7301:
URL: https://github.com/apache/rocketmq/pull/7301#discussion_r1343790397
##
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##
@@ -24,7 +24,9 @@ public class ControllerConfig {
private String rocketmqHome =
Sy
22 matches
Mail list logo
