Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]

2023-10-24 Thread via GitHub
RongtongJin merged PR #7486: URL: https://github.com/apache/rocketmq/pull/7486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocke

Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]

2023-10-23 Thread via GitHub
caigy commented on code in PR #7486: URL: https://github.com/apache/rocketmq/pull/7486#discussion_r1369630044 ## remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RequestCode.java: ## @@ -80,8 +80,6 @@ public class RequestCode { public static final int UPDATE_G

Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]

2023-10-23 Thread via GitHub
onejimmyboy commented on PR #7486: URL: https://github.com/apache/rocketmq/pull/7486#issuecomment-1774787858 > > Why delete this method? How to obtain ACL configuration through the interface after deletion > > Suggested to check on the corresponding broker machine > >> Yes, thi

Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]

2023-10-23 Thread via GitHub
onejimmyboy commented on PR #7486: URL: https://github.com/apache/rocketmq/pull/7486#issuecomment-1774781573 > > Why delete this method? How to obtain ACL configuration through the interface after deletion > > Suggested to check on the corresponding broker machine Yes, this is inde

Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]

2023-10-23 Thread via GitHub
RongtongJin commented on PR #7486: URL: https://github.com/apache/rocketmq/pull/7486#issuecomment-1774711634 > Why delete this method? How to obtain ACL configuration through the interface after deletion Suggested to check on the corresponding broker machine -- This is an automated

Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]

2023-10-19 Thread via GitHub
codecov-commenter commented on PR #7486: URL: https://github.com/apache/rocketmq/pull/7486#issuecomment-1772002750 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7486?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]

2023-10-19 Thread via GitHub
onejimmyboy commented on PR #7486: URL: https://github.com/apache/rocketmq/pull/7486#issuecomment-1771990441 Why delete this method? How to obtain ACL configuration through the interface after deletion -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] Remove getBrokerClusterAclConfig from admin and server [rocketmq]

2023-10-19 Thread via GitHub
RongtongJin opened a new pull request, #7486: URL: https://github.com/apache/rocketmq/pull/7486 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description ### How Did You Test This Change? -- This is an automated message