DivyanshIITB commented on PR #9257:
URL: https://github.com/apache/rocketmq/pull/9257#issuecomment-2821537280
Hi @RongtongJin,
I wanted to check if you had any thoughts on my response. Please let me know
if any clarifications or further details are needed. Thanks for your time!
--
This
DivyanshIITB commented on PR #9257:
URL: https://github.com/apache/rocketmq/pull/9257#issuecomment-2759162478
Hi Rongtong, I wanted to check if you had any thoughts on my response.
Please let me know if any clarifications or further details are needed. Thanks
for your time!
--
This is an
DivyanshIITB commented on code in PR #9257:
URL: https://github.com/apache/rocketmq/pull/9257#discussion_r2006186195
##
client/src/main/java/org/apache/rocketmq/client/impl/producer/TopicPublishInfo.java:
##
@@ -120,12 +120,27 @@ public MessageQueue selectOneMessageQueue(final S
DivyanshIITB commented on PR #9257:
URL: https://github.com/apache/rocketmq/pull/9257#issuecomment-2745206450
Hi @RongtongJin,
I hope you're doing well! I wanted to check if you had a chance to review
this PR. Please let me know if there are any changes or improvements needed—I’d
be
DivyanshIITB commented on PR #9257:
URL: https://github.com/apache/rocketmq/pull/9257#issuecomment-2745194925
Gentle reminder
@RongtongJin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
DivyanshIITB commented on PR #9257:
URL: https://github.com/apache/rocketmq/pull/9257#issuecomment-2744949363
@RongtongJin
I have resolved and replied to your review.
Let me know if any further changes are required !
--
This is an automated message from the Apache Git Service.
To r
DivyanshIITB commented on PR #9257:
URL: https://github.com/apache/rocketmq/pull/9257#issuecomment-2742785857
Just a gentle reminder
@RongtongJin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
RongtongJin commented on code in PR #9257:
URL: https://github.com/apache/rocketmq/pull/9257#discussion_r2004635576
##
client/src/main/java/org/apache/rocketmq/client/impl/producer/TopicPublishInfo.java:
##
@@ -120,12 +120,27 @@ public MessageQueue selectOneMessageQueue(final St
DivyanshIITB commented on PR #9257:
URL: https://github.com/apache/rocketmq/pull/9257#issuecomment-2737672041
Just a gentle reminder
@RongtongJin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
codecov-commenter commented on PR #9257:
URL: https://github.com/apache/rocketmq/pull/9257#issuecomment-2730966677
##
[Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9257?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment
DivyanshIITB opened a new pull request, #9257:
URL: https://github.com/apache/rocketmq/pull/9257
Refactored TopicPublishInfo to remove duplicate code
- Extracted common logic into a private method `getMessageQueue`.
- Updated `selectOneMessageQueue` to use the new method.
- Added
11 matches
Mail list logo
