lizhanhui merged PR #7419:
URL: https://github.com/apache/rocketmq/pull/7419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketm
lizhanhui commented on PR #7419:
URL: https://github.com/apache/rocketmq/pull/7419#issuecomment-1803110138
@mureinik This pull request is good and shall be merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mureinik commented on PR #7419:
URL: https://github.com/apache/rocketmq/pull/7419#issuecomment-1765808449
I've rebased this PR on to of the current `develop` branch that includes
#7445.
IMHO, this is a "cleaner" solution to the same problem, although #7445
already properly fixes it.
codecov-commenter commented on PR #7419:
URL: https://github.com/apache/rocketmq/pull/7419#issuecomment-1757324401
##
[Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7419?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
mureinik commented on PR #7419:
URL: https://github.com/apache/rocketmq/pull/7419#issuecomment-1742670672
@lizhimins thanks for approving this!
The code coverage test is failing, but it seems like a problem with a 3rd
party, not with the MR itself:
```
[2023-10-02T08:26:29.267Z] ['i
