[PR] Add validation in broker/namesrv configure updating command [rocketmq]

2023-12-12 Thread via GitHub
RongtongJin opened a new pull request, #7649: URL: https://github.com/apache/rocketmq/pull/7649 ### Which Issue(s) This PR Fixes Fixes #issue_id ### Brief Description ### How Did You Test This Change? -- This is an automated message

Re: [PR] Add validation in broker/namesrv configure updating command. [rocketmq]

2023-11-27 Thread via GitHub
RongtongJin merged PR #7584: URL: https://github.com/apache/rocketmq/pull/7584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocke

Re: [PR] Add validation in broker/namesrv configure updating command. [rocketmq]

2023-11-27 Thread via GitHub
codecov-commenter commented on PR #7584: URL: https://github.com/apache/rocketmq/pull/7584#issuecomment-1827429470 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7584?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] Add validation in broker/namesrv configure updating command. [rocketmq]

2023-11-27 Thread via GitHub
RongtongJin commented on code in PR #7584: URL: https://github.com/apache/rocketmq/pull/7584#discussion_r1405793665 ## broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java: ## @@ -193,9 +194,15 @@ public class AdminBrokerProcessor implements Netty

Re: [PR] Add validation in broker/namesrv configure updating command. [rocketmq]

2023-11-27 Thread via GitHub
RongtongJin commented on code in PR #7584: URL: https://github.com/apache/rocketmq/pull/7584#discussion_r1405783024 ## namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java: ## @@ -71,8 +74,16 @@ public class DefaultRequestProcessor implements

[PR] Add validation in broker/namesrv configure updating command. [rocketmq]

2023-11-27 Thread via GitHub
ShannonDing opened a new pull request, #7584: URL: https://github.com/apache/rocketmq/pull/7584 Add validation in broker/namesrv configure updating command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a