Re: [PR] [ISSUE #9147] Remove unused code [rocketmq]

2025-01-20 Thread via GitHub
caigy commented on code in PR #9148: URL: https://github.com/apache/rocketmq/pull/9148#discussion_r1922967827 ## client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPullConsumerImpl.java: ## @@ -773,14 +773,6 @@ private void checkConfig() throws MQClientExcept

Re: [PR] [ISSUE #9147] Remove unused code [rocketmq]

2025-01-19 Thread via GitHub
codecov-commenter commented on PR #9148: URL: https://github.com/apache/rocketmq/pull/9148#issuecomment-2601275509 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9148?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

[PR] [ISSUE #9147] Remove unused code [rocketmq]

2025-01-19 Thread via GitHub
mawen12 opened a new pull request, #9148: URL: https://github.com/apache/rocketmq/pull/9148 ### Which Issue(s) This PR Fixes Fixes #9147 ### Brief Description producer group don't need repeat check. ### How Did You Test This Change? D