lizhimins merged PR #8971:
URL: https://github.com/apache/rocketmq/pull/8971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketm
weihubeats commented on PR #8971:
URL: https://github.com/apache/rocketmq/pull/8971#issuecomment-2530167430
@lizhimins Can you help me review this merge request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
weihubeats commented on PR #8971:
URL: https://github.com/apache/rocketmq/pull/8971#issuecomment-2507012574
@lizhimins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
weihubeats commented on PR #8971:
URL: https://github.com/apache/rocketmq/pull/8971#issuecomment-2503008010
> Heartbeats are sent to the broker during client start, rebalancing,
scheduled tasks, and Channel creation. A locking is used to prevent duplicate
heartbeat transmissions. This is a
qianye1001 commented on PR #8971:
URL: https://github.com/apache/rocketmq/pull/8971#issuecomment-2503009623
@lizhimins
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
qianye1001 commented on PR #8971:
URL: https://github.com/apache/rocketmq/pull/8971#issuecomment-2502901015
Heartbeats are sent to the broker during client start, rebalancing,
scheduled tasks, and Channel creation. A locking is used to prevent duplicate
heartbeat transmissions. This is a re
RongtongJin commented on PR #8971:
URL: https://github.com/apache/rocketmq/pull/8971#issuecomment-2499601281
> LGTM
Sorry, I didn't realize it would affect the lossless release code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
weihubeats commented on PR #8971:
URL: https://github.com/apache/rocketmq/pull/8971#issuecomment-2496546286
@qianye1001 How does this sit with you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
weihubeats commented on PR #8971:
URL: https://github.com/apache/rocketmq/pull/8971#issuecomment-2492808930
So we can do a connection logging on the broker, if it's the first
connection then the client sends the heartbeat itself, if it's a go away
reconnection then the heartbeat is triggere
qianye1001 commented on PR #8971:
URL: https://github.com/apache/rocketmq/pull/8971#issuecomment-2492732043
> > it is used to make sure any proxy can receive heartbeat request before
receive send or pull request when some proxy services share LB
>
> Can you give me an example?
weihubeats commented on PR #8971:
URL: https://github.com/apache/rocketmq/pull/8971#issuecomment-2492723724
> it is used to make sure any proxy can receive heartbeat request before
receive send or pull request when some proxy services share LB
Can you give me an example?
--
This is
qianye1001 commented on PR #8971:
URL: https://github.com/apache/rocketmq/pull/8971#issuecomment-2492709073
it is used to make sure any proxy can receive heartbeat request before
receive send or pull request when some proxy services share LB
--
This is an automated message from the Apache
RongtongJin commented on PR #8971:
URL: https://github.com/apache/rocketmq/pull/8971#issuecomment-2492695198
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
weihubeats opened a new pull request, #8971:
URL: https://github.com/apache/rocketmq/pull/8971
https://github.com/apache/rocketmq/issues/8970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
codecov-commenter commented on PR #8971:
URL: https://github.com/apache/rocketmq/pull/8971#issuecomment-2490919648
##
[Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8971?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment
15 matches
Mail list logo
