Re: [PR] [ISSUE #8852] Add more test coverage for ClientMetadata [rocketmq]

2024-10-28 Thread via GitHub
RongtongJin merged PR #8853: URL: https://github.com/apache/rocketmq/pull/8853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocke

Re: [PR] [ISSUE #8852] Add more test coverage for ClientMetadata [rocketmq]

2024-10-22 Thread via GitHub
yx9o commented on code in PR #8853: URL: https://github.com/apache/rocketmq/pull/8853#discussion_r1811860350 ## remoting/src/test/java/org/apache/rocketmq/remoting/rpc/ClientMetadataTest.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] [ISSUE #8852] Add more test coverage for ClientMetadata [rocketmq]

2024-10-22 Thread via GitHub
RongtongJin commented on code in PR #8853: URL: https://github.com/apache/rocketmq/pull/8853#discussion_r1811601083 ## remoting/src/test/java/org/apache/rocketmq/remoting/rpc/ClientMetadataTest.java: ## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] [ISSUE #8852] Add more test coverage for ClientMetadata [rocketmq]

2024-10-22 Thread via GitHub
codecov-commenter commented on PR #8853: URL: https://github.com/apache/rocketmq/pull/8853#issuecomment-2429205356 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8853?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comment

[PR] [ISSUE #8852] Add more test coverage for ClientMetadata [rocketmq]

2024-10-22 Thread via GitHub
yx9o opened a new pull request, #8853: URL: https://github.com/apache/rocketmq/pull/8853 Fixes #8852 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib