Re: [PR] [ISSUE #7454] Utilizing cache to avoid duplicate parsing [rocketmq]

2023-10-18 Thread via GitHub
RongtongJin merged PR #7455: URL: https://github.com/apache/rocketmq/pull/7455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@rocke

Re: [PR] [ISSUE #7454] Utilizing cache to avoid duplicate parsing [rocketmq]

2023-10-16 Thread via GitHub
guyinyou commented on PR #7455: URL: https://github.com/apache/rocketmq/pull/7455#issuecomment-1764061520 have changed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [ISSUE #7454] Utilizing cache to avoid duplicate parsing [rocketmq]

2023-10-12 Thread via GitHub
joeCarf commented on code in PR #7455: URL: https://github.com/apache/rocketmq/pull/7455#discussion_r1357669323 ## remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingCommand.java: ## @@ -260,7 +261,11 @@ public void writeCustomHeader(CommandCustomHeader custom

Re: [PR] [ISSUE #7454] Utilizing cache to avoid duplicate parsing [rocketmq]

2023-10-12 Thread via GitHub
echooymxq commented on PR #7455: URL: https://github.com/apache/rocketmq/pull/7455#issuecomment-1760633945 How about add a method argument to decide cacheable?🤔️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [ISSUE #7454] Utilizing cache to avoid duplicate parsing [rocketmq]

2023-10-12 Thread via GitHub
guyinyou opened a new pull request, #7455: URL: https://github.com/apache/rocketmq/pull/7455 ### Which Issue(s) This PR Fixes Fixes #7454 ### Brief Description ### How Did You Test This Change? -- This is an automated message from th